Skip to content

Add pagination on Audit API#2487

Merged
t-bast merged 5 commits into
ACINQ:masterfrom
rorp:issue_2451
Dec 9, 2022
Merged

Add pagination on Audit API#2487
t-bast merged 5 commits into
ACINQ:masterfrom
rorp:issue_2451

Conversation

@rorp
Copy link
Copy Markdown
Contributor

@rorp rorp commented Nov 14, 2022

Comment thread eclair-core/src/main/scala/fr/acinq/eclair/db/AuditDb.scala Outdated
Comment thread docs/release-notes/eclair-vnext.md Outdated
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2487 (2b1ea08) into master (908d87f) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

❗ Current head 2b1ea08 differs from pull request most recent head 45b0758. Consider uploading reports for the commit 45b0758 to get more accurate results

@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
- Coverage   84.99%   84.94%   -0.05%     
==========================================
  Files         200      200              
  Lines       15826    15832       +6     
  Branches      679      671       -8     
==========================================
- Hits        13451    13449       -2     
- Misses       2375     2383       +8     
Impacted Files Coverage Δ
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 52.10% <0.00%> (ø)
.../main/scala/fr/acinq/eclair/db/DualDatabases.scala 11.27% <0.00%> (ø)
...c/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala 99.68% <100.00%> (+<0.01%) ⬆️
...cala/fr/acinq/eclair/db/sqlite/SqliteAuditDb.scala 99.66% <100.00%> (+<0.01%) ⬆️
...src/main/scala/fr/acinq/eclair/db/pg/PgUtils.scala 89.39% <0.00%> (-1.52%) ⬇️
...clair/channel/publish/ReplaceableTxPublisher.scala 74.19% <0.00%> (-1.30%) ⬇️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 85.76% <0.00%> (-0.73%) ⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.86% <0.00%> (-0.69%) ⬇️
...fr/acinq/eclair/channel/InteractiveTxBuilder.scala 84.79% <0.00%> (-0.52%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Helpers.scala 94.87% <0.00%> (-0.19%) ⬇️
... and 1 more

Copy link
Copy Markdown
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@t-bast t-bast merged commit 2a7649d into ACINQ:master Dec 9, 2022
t-bast added a commit that referenced this pull request Jun 16, 2023
This release introduces a few API changes:

- `audit` now accepts `--count` and `--skip` parameters to limit the
  number of retrieved items (#2474, #2487)
- `sendtoroute` removes the `--trampolineNodes` argument and
  implicitly uses a single trampoline hop (#2480)
- `sendtoroute` now accept `--maxFeeMsat` to specify an upper bound
  of fees (#2626)
- `payinvoice` always returns the payment result when used with
  `--blocking`, even when using MPP (#2525)
- `node` returns high-level information about a remote node (#2568)
- `channel-created` is a new websocket event that is published when
  a channel's funding transaction has been broadcast (#2567)
- `channel-opened` websocket event was updated to contain the final
  `channel_id` and be published when a channel is ready to process
  payments (#2567)
- `getsentinfo` can now be used with `--offer` to list payments sent
  to a specific offer
- `listreceivedpayments` lists payments received by your node (#2607)
- `closedchannels` lists closed channels. It accepts `--count` and
  `--skip` parameters to limit the number of retrieved items as well
  (#2642)
- `cpfpbumpfees` can be used to unblock chains of unconfirmed
  transactions by creating a child transaction that pays a high fee
  (#1783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pagination on Audit API

3 participants