Skip to content

Add GetNode router API#2568

Merged
t-bast merged 1 commit into
masterfrom
router-get-node
Jan 16, 2023
Merged

Add GetNode router API#2568
t-bast merged 1 commit into
masterfrom
router-get-node

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented Jan 13, 2023

Add a new API to return information about a specific node: its announcement, number of active channels and total capacity. This has been requested several times by node operators.

Add a new API to return information about a specific node: its announcement,
number of active channels and total capacity.
Comment thread eclair-core/src/test/scala/fr/acinq/eclair/router/RouterSpec.scala
@t-bast t-bast requested review from pm47 and remyers January 13, 2023 14:53
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2568 (2e9fb19) into master (4dd4829) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
- Coverage   85.32%   85.30%   -0.02%     
==========================================
  Files         205      205              
  Lines       16121    16130       +9     
  Branches      703      706       +3     
==========================================
+ Hits        13755    13760       +5     
- Misses       2366     2370       +4     
Impacted Files Coverage Δ
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 61.65% <100.00%> (+0.60%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 94.71% <100.00%> (+0.14%) ⬆️
...air-core/src/main/scala/fr/acinq/eclair/Logs.scala 83.33% <0.00%> (-3.34%) ⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 96.45% <0.00%> (-1.42%) ⬇️
...inq/eclair/channel/fund/InteractiveTxBuilder.scala 87.26% <0.00%> (-0.64%) ⬇️
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 86.78% <0.00%> (-0.12%) ⬇️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala 91.16% <0.00%> (+0.55%) ⬆️
...cinq/eclair/payment/receive/MultiPartHandler.scala 95.28% <0.00%> (+1.04%) ⬆️

Copy link
Copy Markdown
Contributor

@remyers remyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very useful for what I'm doing - so big concept ACK. Changest LGTM too.

@t-bast t-bast merged commit 6486449 into master Jan 16, 2023
@t-bast t-bast deleted the router-get-node branch January 16, 2023 14:13
t-bast added a commit that referenced this pull request Jun 16, 2023
This release introduces a few API changes:

- `audit` now accepts `--count` and `--skip` parameters to limit the
  number of retrieved items (#2474, #2487)
- `sendtoroute` removes the `--trampolineNodes` argument and
  implicitly uses a single trampoline hop (#2480)
- `sendtoroute` now accept `--maxFeeMsat` to specify an upper bound
  of fees (#2626)
- `payinvoice` always returns the payment result when used with
  `--blocking`, even when using MPP (#2525)
- `node` returns high-level information about a remote node (#2568)
- `channel-created` is a new websocket event that is published when
  a channel's funding transaction has been broadcast (#2567)
- `channel-opened` websocket event was updated to contain the final
  `channel_id` and be published when a channel is ready to process
  payments (#2567)
- `getsentinfo` can now be used with `--offer` to list payments sent
  to a specific offer
- `listreceivedpayments` lists payments received by your node (#2607)
- `closedchannels` lists closed channels. It accepts `--count` and
  `--skip` parameters to limit the number of retrieved items as well
  (#2642)
- `cpfpbumpfees` can be used to unblock chains of unconfirmed
  transactions by creating a child transaction that pays a high fee
  (#1783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants