Improve payinvoice API response#2525
Merged
Merged
Conversation
t-bast
force-pushed
the
improve-pay-invoice-result
branch
from
e33ce81 to
1f26363
Compare
When sending an outgoing multi-part payment, we forward the preimage back to the sender as soon as we receive the first `update_fulfill_htlc`. This is particularly useful when relaying trampoline payments, to be able to propagate the fulfill upstream as early as possible. However this meant that callers of the HTTP API would receive this preimage event instead of the final payment result, which was quite bad. We now disable this first event when used with the `--blocking` argument, which ensures that the API always returns the payment result. Fixes #2389
t-bast
force-pushed
the
improve-pay-invoice-result
branch
from
1f26363 to
f51b867
Compare
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 85.17% 85.18% +0.01%
==========================================
Files 202 202
Lines 15996 15994 -2
Branches 689 664 -25
==========================================
Hits 13624 13624
+ Misses 2372 2370 -2
|
pm47
approved these changes
Dec 20, 2022
t-bast
added a commit
that referenced
this pull request
Jun 16, 2023
This release introduces a few API changes: - `audit` now accepts `--count` and `--skip` parameters to limit the number of retrieved items (#2474, #2487) - `sendtoroute` removes the `--trampolineNodes` argument and implicitly uses a single trampoline hop (#2480) - `sendtoroute` now accept `--maxFeeMsat` to specify an upper bound of fees (#2626) - `payinvoice` always returns the payment result when used with `--blocking`, even when using MPP (#2525) - `node` returns high-level information about a remote node (#2568) - `channel-created` is a new websocket event that is published when a channel's funding transaction has been broadcast (#2567) - `channel-opened` websocket event was updated to contain the final `channel_id` and be published when a channel is ready to process payments (#2567) - `getsentinfo` can now be used with `--offer` to list payments sent to a specific offer - `listreceivedpayments` lists payments received by your node (#2607) - `closedchannels` lists closed channels. It accepts `--count` and `--skip` parameters to limit the number of retrieved items as well (#2642) - `cpfpbumpfees` can be used to unblock chains of unconfirmed transactions by creating a child transaction that pays a high fee (#1783)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending an outgoing multi-part payment, we forward the preimage back to the sender as soon as we receive the first
update_fulfill_htlc. This is particularly useful when relaying trampoline payments, to be able to propagate the fulfill upstream as early as possible.However this meant that callers of the HTTP API would receive this preimage event instead of the final payment result, which was quite bad. We now disable this first event when used with the
--blockingargument, which ensures that the API always returns the payment result.Fixes #2389