Add maxFeeMsat parameter to sendtoroute RPC call#2626
Merged
Conversation
t-bast
reviewed
May 5, 2023
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Sorry for the late review! Can you update the release notes accordingly?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2626 +/- ##
==========================================
- Coverage 85.88% 85.86% -0.03%
==========================================
Files 214 214
Lines 17591 17598 +7
Branches 728 715 -13
==========================================
+ Hits 15108 15110 +2
- Misses 2483 2488 +5
🚀 New features to boost your workflow:
|
t-bast
approved these changes
Jun 7, 2023
t-bast
added a commit
that referenced
this pull request
Jun 16, 2023
This release introduces a few API changes: - `audit` now accepts `--count` and `--skip` parameters to limit the number of retrieved items (#2474, #2487) - `sendtoroute` removes the `--trampolineNodes` argument and implicitly uses a single trampoline hop (#2480) - `sendtoroute` now accept `--maxFeeMsat` to specify an upper bound of fees (#2626) - `payinvoice` always returns the payment result when used with `--blocking`, even when using MPP (#2525) - `node` returns high-level information about a remote node (#2568) - `channel-created` is a new websocket event that is published when a channel's funding transaction has been broadcast (#2567) - `channel-opened` websocket event was updated to contain the final `channel_id` and be published when a channel is ready to process payments (#2567) - `getsentinfo` can now be used with `--offer` to list payments sent to a specific offer - `listreceivedpayments` lists payments received by your node (#2607) - `closedchannels` lists closed channels. It accepts `--count` and `--skip` parameters to limit the number of retrieved items as well (#2642) - `cpfpbumpfees` can be used to unblock chains of unconfirmed transactions by creating a child transaction that pays a high fee (#1783)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale for this PR is to avoid this situation:
findroute*withmaxFeeMsatto exclude the most expensive routes.sendtorouteand ends up paying much more in fees than they expected.This PR allows to set
maxFeeMsatforsendtorouteRPC call. If the routing fees exceed the max fee the router returns a local error.