Add ChannelOpened event#2567
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
- Coverage 85.32% 85.29% -0.03%
==========================================
Files 205 205
Lines 16121 16122 +1
Branches 703 681 -22
==========================================
- Hits 13755 13752 -3
- Misses 2366 2370 +4
|
remyers
reviewed
Jan 13, 2023
Contributor
remyers
left a comment
remyers
left a comment
There was a problem hiding this comment.
Apart from some confusion in the release notes, it looks good to me!
pm47
previously approved these changes
Jan 16, 2023
Emit an event when a channel is opened and ready to process payments. This event is distinct from the `ChannelCreated` event which is sent earlier, once we think a funding transaction has been successfully created (but cannot guarantee when we're not the initiator).
This is a breaking change, but it should be ok since the previous event wasn't reliable: it was emitted at a time where we couldn't guarantee that the channel would really confirm.
t-bast
force-pushed
the
channel-opened-event
branch
from
27f51ef to
55c2f56
Compare
Member
Author
|
Rebased to fix conflicts. |
t-bast
added a commit
that referenced
this pull request
Jun 16, 2023
This release introduces a few API changes: - `audit` now accepts `--count` and `--skip` parameters to limit the number of retrieved items (#2474, #2487) - `sendtoroute` removes the `--trampolineNodes` argument and implicitly uses a single trampoline hop (#2480) - `sendtoroute` now accept `--maxFeeMsat` to specify an upper bound of fees (#2626) - `payinvoice` always returns the payment result when used with `--blocking`, even when using MPP (#2525) - `node` returns high-level information about a remote node (#2568) - `channel-created` is a new websocket event that is published when a channel's funding transaction has been broadcast (#2567) - `channel-opened` websocket event was updated to contain the final `channel_id` and be published when a channel is ready to process payments (#2567) - `getsentinfo` can now be used with `--offer` to list payments sent to a specific offer - `listreceivedpayments` lists payments received by your node (#2607) - `closedchannels` lists closed channels. It accepts `--count` and `--skip` parameters to limit the number of retrieved items as well (#2642) - `cpfpbumpfees` can be used to unblock chains of unconfirmed transactions by creating a child transaction that pays a high fee (#1783)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit an event when a channel is opened and ready to process payments. This event is distinct from the
ChannelCreatedevent which is sent earlier, once we think a funding transaction has been successfully created (but cannot guarantee when we're not the initiator).I've regularly worked around the lack of such an event, and I think it's useful to have, especially for plugins that would like to know when a new channel is really available without having to watch all state transitions.