{App Service} Hotfix: Remove fileshare validation#31237
Closed
seligj95 wants to merge 38 commits intoAzure:releasefrom
Closed
{App Service} Hotfix: Remove fileshare validation#31237seligj95 wants to merge 38 commits intoAzure:releasefrom
seligj95 wants to merge 38 commits intoAzure:releasefrom
Conversation
…b app a non-required parameter (Azure#30958)
…w omitting `principalName` property (Azure#30693)
…abric Mirroring is enabled (Azure#31149) * {RDBMS} az postgres flexible-server update: Cannot enable HA when Fabric Mirroring is enabled * update message * add pylint exception * move pylint exception * fix test * address feedback * address feedback --------- Co-authored-by: Matthew Boentoro <mboentoro@microsoft.com>
…API check to the `--version` parameter and allow user to upgrade to PG17 when it is available (Azure#31146) * {RDBMS} az postgres flexible-server upgrade: Add server capability API check to the --version parameter * fix help text --------- Co-authored-by: Matthew Boentoro <mboentoro@microsoft.com>
…n when turning off autoupgrade (Azure#31018)
* {core} add breaking change warning for azure stack users
* add breaking change messages
…zure#31060) * Initialize Conditional BC in core * Support Register BC in core * Specify the name as login * Update Conditional BC doc * Fix indent in doc * Fix file name issue * Revert BC announcement in core * Fix style * Support Breaking Changes announced in core * Fix Conditional breaking change style * Add a custom message to deprecate info in Breaking Change method
…efine the logic of `--root-cert-data` (Azure#31166) * fix root-cert-data logic * remove unused import
…fault-outbound-access` (Azure#31175) * chore: short summary * chore: remove breaking info
…by file (Azure#31153) * fix extra version line in encodedTask created by file * add comment to call out version requirement for cmd source --------- Co-authored-by: wju <wju@microsoft.com>
* Initial helm announce * Use deprecate info * Fix * Apply suggestions from code review Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> --------- Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
️✔️AzureCLI-FullTest
|
|
Hi @seligj95, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
3 tasks
seligj95
requested review from
AllyW,
FumingZhang,
bebound,
calvinhzy,
evelyn-ys,
jiasli,
kairu-ms and
necusjz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config storage-account add
Description
Validation was added Fix #21721, however this validation doesn't work as intended so removing it until this can be further investigated. There's commentary in #30990 that explains the issues and why this change needs to be rolled back.
Testing Guide
az webapp config storage-account add -g <RESSOURCE_GROUP_NAME> -n <APP_SERVICE_NAME> --custom-id "test-az-cli" --storage-type AzureFiles --account-name <STORAGE_ACCOUNT_NAME> --share-name <FILE_SHARE_NAME> --access-key <STORAGE_ACCOUNT_ACCESS_KEY> --mount-path <MOUNT_PATH_ON_APP_SERVICE_FS>
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.