Skip to content

fix: fix crossbow system#27

Merged
AyakorK merged 1 commit intodevelopfrom
feature/add_traps
Oct 24, 2024
Merged

fix: fix crossbow system#27
AyakorK merged 1 commit intodevelopfrom
feature/add_traps

Conversation

@Thomlam
Copy link
Copy Markdown
Contributor

@Thomlam Thomlam commented Oct 24, 2024 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

Notes de version

  • Nouvelles fonctionnalités

    • Ajout de nouveaux pièges : Arrow_prefab_side et crossbow_side_right_prefab.
    • Renommage du piège crossbow_side_prefab en crossbow_side_left_prefab.

  • Améliorations

    • Ajustement de la mécanique de tir des flèches pour un tir plus rapide et directionnel.
    • Modifications de la position et de l'orientation des objets dans la scène EmptyRoom_2.

  • Corrections de bugs

    • Suppression de la variable de direction dans la classe Arrow, rendant le mouvement de la flèche constant vers le haut.

@Thomlam Thomlam self-assigned this Oct 24, 2024
@Thomlam Thomlam requested a review from AyakorK October 24, 2024 12:13
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 24, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Cette pull request introduit plusieurs nouvelles fonctionnalités et modifications dans un projet Unity, notamment l'ajout de nouveaux préfabriqués pour des pièges tels qu'un piège à flèches et un piège à arbalète. Les préfabriqués incluent divers composants comme des Transform, SpriteRenderer, MonoBehaviour, BoxCollider2D et Rigidbody2D. Des modifications ont également été apportées aux métadonnées des préfabriqués, ainsi qu'à la configuration de la scène EmptyRoom_2. De plus, des ajustements ont été effectués dans les classes de scripts pour améliorer la logique de tir des flèches et la gestion des pièges.

Changes

Fichier Résumé des changements
Assets/Prefabs/Traps/Arrow/Arrow_prefab_side.prefab Nouveau préfabriqué ajouté pour un piège à flèches, comprenant des composants Transform, SpriteRenderer, MonoBehaviour, BoxCollider2D et Rigidbody2D.
Assets/Prefabs/Traps/Arrow/Arrow_prefab_side.prefab.meta Mise à jour du GUID du fichier de métadonnées du préfabriqué.
Assets/Prefabs/Traps/Crossbow/crossbow_side_left_prefab.prefab Renommage du préfabriqué de crossbow_side_prefab à crossbow_side_left_prefab et ajustement de la position locale.
Assets/Prefabs/Traps/Crossbow/crossbow_side_left_prefab.prefab.meta Création d'un nouveau fichier de métadonnées pour le préfabriqué crossbow_side_left_prefab.
Assets/Prefabs/Traps/Crossbow/crossbow_side_right_prefab.prefab Nouveau préfabriqué ajouté pour un piège à arbalète, comprenant divers composants comme Transform, SpriteRenderer, Animator, Tilemap et MonoBehaviour.
Assets/Prefabs/Traps/Crossbow/crossbow_side_right_prefab.prefab.meta Création d'un nouveau fichier de métadonnées pour le préfabriqué crossbow_side_right_prefab.
Assets/Scenes/EmptyRoom_2.unity Modifications significatives des instances de préfabriqués et de leurs propriétés dans la scène, y compris des ajustements de position et de rotation pour plusieurs objets.
Assets/Scripts/Trap/Arrow/Arrow.cs Suppression de la variable direction, l'arbre se déplace maintenant toujours vers le haut.
Assets/Scripts/Trap/Crossbow/Crossbow.cs Modifications apportées à la mécanique de tir, incluant une réduction du temps d'attente entre les tirs et l'ajout d'un calcul pour l'angle de tir des flèches.
Assets/Scripts/Trap/TrapManager.cs Mise à jour des entrées du dictionnaire trapPrefabDictionary pour refléter les nouveaux noms de préfabriqués.

Possibly related PRs

  • Feature/add traps #19: Les changements dans cette PR impliquent l'ajout d'un nouveau préfabriqué de piège à ours et de sa fonctionnalité associée, qui est directement liée au préfabriqué de piège à flèches introduit dans cette PR, car les deux font partie de la catégorie des pièges dans le projet Unity.

Suggested reviewers

  • AyakorK

🐇 Dans le jardin, un piège à flèches,
Avec des flèches qui dansent et s'élèvent,
Un nouvel arbalète à gauche, à droite,
Les pièges s'alignent, prêts à la bataille,
Dans le monde de Unity, tout s'illumine,
Les aventures s'éveillent, la magie s'exprime. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AyakorK AyakorK merged commit 3a64658 into develop Oct 24, 2024
Thomlam added a commit that referenced this pull request Oct 26, 2024
@Thomlam
fix: fix crossbow system (#27)
2e41885
AyakorK added a commit that referenced this pull request Oct 27, 2024
@Thomlam @AyakorK
Develop (#37)
84a1f47 
* Chore/shadering map (#24)

* technical : add shadering and post-traitement system, adapt asset and sprite for using this

* feat: update Room2

* feat: Link the chat to the back sockets (#25)

* feat: Link chat to backend (#26)

* feat: Link the chat to the back sockets

* fix: Move the dialogue script outside the canvas to avoid it to be disabled while the canvas is going to be disabled

* fix: remove dual camera

* fix: fix crossbow system (#27)

* fix: add request to back (room name)

* fix: Revert trap manager

* hotfix: Fix things that weren't working

* feat: RPS (#29)

* feat : add multiple option and itemscollider for RockPaperCissor

* feat: Link Rock Paper Scissors to backend socket

* feat: Link RockPaperScissors, but display missing

---------

Co-authored-by: Thomas Lamiable <lamiablethomas@gmail.com>

* hotfix: Change RPS size to match the screen

* fix: fix Crossbow up sprite and arrow system, change color pixel dead font

* chore: change EmptyRoom2

* feat: add death system (#30)

* feat: add death system

* chore: add socket emiter for end game

* fix: fix heart generator if develop don't have socket

* fix: remove crossbow

* feature: add audio system and fix crossbow with sound (#32)

Co-authored-by: Guillaume MORET <90462045+AyakorK@users.noreply.github.com>

* chore: Fix env for windows (#31)

* feat: add death system

* chore: add socket emiter for end game

* fix: fix heart generator if develop don't have socket

* fix: remove crossbow

* chore: try to fix .env for Windows and Unity

* fix: Quick Fix in production

* fix: QuickFx PlayerHealth fail merge

* Fix: fix Room

* feat: Adapt Waiting Room (#33)

* feat: Instantiate waiting room when arriving in the corridor 0

* fix: Add a flag to change message one time and avoid repetition of it

* feat: Add the creation of the room when instanciating the WaitingRoom process

* feat: Try to remove the Door collider before game has started

* fix: fix lock and door system, add waiting room, last fix for dialogue system for pity

---------

Co-authored-by: Thomlam <lamiablethomas@gmail.com>

* fix: rename bear_trap to prefab

* fix: quick fix prefab room for crossbow

* fix: quickfix for bear_trap

* feat: Add room deletion when disconnection from a game

* Wip/streaming back (#35)

* feat: add streaming system with recording and sending frame jpeg

* feat: add config

* feat: first try to add socketIOSystem

* feat: Add the right socket

* feature : deploy for 60fps

---------

Co-authored-by: AyakorK <guillaume.moret@yahoo.com>

* hotfix: Get rid of a Debug

* fix: fix arrows component and stade 24 fps to streaming

* fix: Global rendering fixes (#36)

* fix: Update corridor displays + additions of colliders to avoid glitching

* fix: Add a door transition lock

* feat: Add collision to the walls in the room

* fix: Fix collisions of the hole

* fix: Fix glitched hitboxes

* fix: Destory arrows when going to an other room

---------

Co-authored-by: Guillaume MORET <90462045+AyakorK@users.noreply.github.com>
Co-authored-by: AyakorK <guillaume.moret@yahoo.com>
@AyakorK AyakorK deleted the feature/add_traps branch October 28, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AyakorK AyakorK AyakorK approved these changes

Assignees

@Thomlam Thomlam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thomlam @AyakorK