[Backport 7.77.x] Detect the correct launch type for ECS Managed Instances when deployed as Daemon#47003
Conversation
…d as Daemon (#46947) ### What does this PR do? Fixes launch type detection so that tasks on ECS Managed Instances are correctly reported as `MANAGED_INSTANCES` in workloadmeta when the agent runs in daemon mode. ### Motivation When the agent runs as a daemon on ECS Managed Instances, task and container entities in workloadmeta were not always getting the correct launch type. This change ensures the ECS collector sets `LaunchType` to `ECSLaunchTypeManagedInstances` for tasks with `LaunchType` `MANAGED_INSTANCES`, for both V1 and V4 metadata parsing. ### Describe how you validated your changes - Deployed the Agent on ECS Managed Instances. - Confirmed that the correct launch type appears in the agent workload. - ECS Explorer reports correct launch type: <img width="1048" height="269" alt="image" src="https://github.com/user-attachments/assets/07592fc4-93fa-4247-9680-69730bb9b5f2" /> Co-authored-by: steve.zou <steve.zou@datadoghq.com> (cherry picked from commit 9335d64) ___ Co-authored-by: Steven Zou <steve.zou@datadoghq.com>
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
28 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 69849fb Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.49 | [-1.58, +4.55] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.49 | [-1.58, +4.55] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.58 | [+0.48, +0.68] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.51 | [+0.45, +0.57] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.34 | [+0.19, +0.50] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.31 | [+0.24, +0.38] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.22 | [+0.18, +0.27] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.15 | [-0.08, +0.38] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.11 | [-0.11, +0.33] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.10 | [-0.06, +0.25] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.03, +0.06] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.11, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.08, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.38, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.14, +0.14] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.03 | [-0.44, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.04 | [-0.10, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.08 | [-0.58, +0.43] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.12 | [-0.17, -0.06] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.19 | [-0.22, -0.15] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.33 | [-1.83, +1.17] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.68 | [-0.90, -0.47] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.89 | [-1.09, -0.69] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.03 | [-1.11, -0.96] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
maycmlee
left a comment
There was a problem hiding this comment.
Small suggestion, but approving
| --- | ||
| fixes: | ||
| - | | ||
| Detect correct launch type for ECS Managed Instances when running in daemon mode. |
There was a problem hiding this comment.
| Detect correct launch type for ECS Managed Instances when running in daemon mode. | |
| Detect the correct launch type for ECS Managed Instances when running in daemon mode. |
Add project-specific review guidelines for AI code reviewers (Codex, Claude Code), covering: E2E coverage with fakeintake, branch-conditional CI blind spots, multi-platform divergence, concurrency lifecycle, graceful degradation, documentation freshness, and PR template adherence. Also add a maintenance section encouraging organic growth of guidelines. Derived from analysis of backport bug fixes: #47251, #47185, #47073, #47509, #47028, #46978, #46979, #47003, #46955, #47256. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport 9335d64 from #46947.
What does this PR do?
Fixes launch type detection so that tasks on ECS Managed Instances are correctly reported as
MANAGED_INSTANCESin workloadmeta when the agent runs in daemon mode.Motivation
When the agent runs as a daemon on ECS Managed Instances, task and container entities in workloadmeta were not always getting the correct launch type. This change ensures the ECS collector sets
LaunchTypetoECSLaunchTypeManagedInstancesfor tasks withLaunchTypeMANAGED_INSTANCES, for both V1 and V4 metadata parsing.Describe how you validated your changes