Skip to content

[Backport 7.77.x] Detect the correct launch type for ECS Managed Instances when deployed as Daemon#47003

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.77.xfrom
backport-46947-to-7.77.x
Feb 27, 2026
Merged

[Backport 7.77.x] Detect the correct launch type for ECS Managed Instances when deployed as Daemon#47003
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.77.xfrom
backport-46947-to-7.77.x

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented Feb 26, 2026

Backport 9335d64 from #46947.


What does this PR do?

Fixes launch type detection so that tasks on ECS Managed Instances are correctly reported as MANAGED_INSTANCES in workloadmeta when the agent runs in daemon mode.

Motivation

When the agent runs as a daemon on ECS Managed Instances, task and container entities in workloadmeta were not always getting the correct launch type. This change ensures the ECS collector sets LaunchType to ECSLaunchTypeManagedInstances for tasks with LaunchType MANAGED_INSTANCES, for both V1 and V4 metadata parsing.

Describe how you validated your changes

  • Deployed the Agent on ECS Managed Instances.
  • Confirmed that the correct launch type appears in the agent workload.
  • ECS Explorer reports correct launch type:
image

…d as Daemon (#46947) ### What does this PR do? Fixes launch type detection so that tasks on ECS Managed Instances are correctly reported as `MANAGED_INSTANCES` in workloadmeta when the agent runs in daemon mode.

### Motivation
When the agent runs as a daemon on ECS Managed Instances, task and container entities in workloadmeta were not always getting the correct launch type. This change ensures the ECS collector sets `LaunchType` to `ECSLaunchTypeManagedInstances` for tasks with `LaunchType` `MANAGED_INSTANCES`, for both V1 and V4 metadata parsing.

### Describe how you validated your changes
- Deployed the Agent on ECS Managed Instances.
- Confirmed that the correct launch type appears in the agent workload.
- ECS Explorer reports correct launch type:
<img width="1048" height="269" alt="image" src="https://github.com/user-attachments/assets/07592fc4-93fa-4247-9680-69730bb9b5f2" />

Co-authored-by: steve.zou <steve.zou@datadoghq.com>
(cherry picked from commit 9335d64)

___

Co-authored-by: Steven Zou <steve.zou@datadoghq.com>
@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner February 26, 2026 18:59
@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner February 26, 2026 18:59
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR medium review PR review might take time labels Feb 26, 2026
@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner February 26, 2026 18:59
@dd-octo-sts dd-octo-sts Bot added qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/agent-runtimes team/container-platform The Container Platform Team team/ecs-experiences Issues and PRs owned by the ECS Experiences team labels Feb 26, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Feb 26, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1f40bb3
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64_fips +4.0 KiB (0.00% increase) 715.081 → 715.085 → 720.180
agent_rpm_amd64_fips +4.0 KiB (0.00% increase) 715.065 → 715.069 → 720.160
agent_suse_amd64_fips +4.0 KiB (0.00% increase) 715.065 → 715.069 → 720.160
28 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 756.403 MiB
agent_heroku_amd64 323.755 MiB
agent_msi 622.537 MiB
agent_rpm_amd64 756.387 MiB
agent_rpm_arm64 734.516 MiB
agent_rpm_arm64_fips 696.207 MiB
agent_suse_amd64 756.387 MiB
agent_suse_arm64 734.516 MiB
agent_suse_arm64_fips 696.207 MiB
docker_agent_amd64 817.424 MiB
docker_agent_arm64 820.288 MiB
docker_agent_jmx_amd64 1008.336 MiB
docker_agent_jmx_arm64 999.982 MiB
docker_cluster_agent_amd64 203.000 MiB
docker_cluster_agent_arm64 217.454 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.500 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.724 MiB
dogstatsd_deb_arm64 27.881 MiB
dogstatsd_rpm_amd64 29.724 MiB
dogstatsd_suse_amd64 29.724 MiB
iot_agent_deb_amd64 42.617 MiB
iot_agent_deb_arm64 39.719 MiB
iot_agent_deb_armhf 40.447 MiB
iot_agent_rpm_amd64 42.618 MiB
iot_agent_suse_amd64 42.618 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -7.34 KiB (0.00% reduction) 185.688 → 185.681 → 186.090
agent_deb_amd64_fips +6.09 KiB (0.00% increase) 176.280 → 176.286 → 180.330
agent_heroku_amd64 -4.9 KiB (0.01% reduction) 87.105 → 87.101 → 88.440
agent_msi +8.0 KiB (0.01% increase) 149.355 → 149.363 → 154.470
agent_rpm_amd64 -6.39 KiB (0.00% reduction) 187.609 → 187.603 → 189.170
agent_rpm_amd64_fips -21.13 KiB (0.01% reduction) 178.422 → 178.401 → 181.060
agent_rpm_arm64 neutral 169.836 MiB → 170.020
agent_rpm_arm64_fips +20.05 KiB (0.01% increase) 162.492 → 162.512 → 164.130
agent_suse_amd64 -6.39 KiB (0.00% reduction) 187.609 → 187.603 → 189.170
agent_suse_amd64_fips -21.13 KiB (0.01% reduction) 178.422 → 178.401 → 181.060
agent_suse_arm64 neutral 169.836 MiB → 170.020
agent_suse_arm64_fips +20.05 KiB (0.01% increase) 162.492 → 162.512 → 164.130
docker_agent_amd64 neutral 277.941 MiB → 279.410
docker_agent_arm64 neutral 265.199 MiB → 267.960
docker_agent_jmx_amd64 neutral 346.588 MiB → 348.040
docker_agent_jmx_arm64 neutral 329.841 MiB → 332.560
docker_cluster_agent_amd64 neutral 71.131 MiB → 71.920
docker_cluster_agent_arm64 neutral 66.772 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
docker_dogstatsd_arm64 +3.33 KiB (0.02% increase) 14.234 → 14.237 → 14.830
dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.741 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.864 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.864 MiB → 8.800
iot_agent_deb_amd64 neutral 11.238 MiB → 12.040
iot_agent_deb_arm64 neutral 9.601 MiB → 10.450
iot_agent_deb_armhf neutral 9.803 MiB → 10.620
iot_agent_rpm_amd64 -2.25 KiB (0.02% reduction) 11.257 → 11.255 → 12.060
iot_agent_suse_amd64 -2.25 KiB (0.02% reduction) 11.257 → 11.255 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Feb 26, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 98ac7ae3-c448-484b-99e4-334495e69ea3

Baseline: 69849fb
Comparison: 74e16b1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.49 [-1.58, +4.55] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.49 [-1.58, +4.55] 1 Logs
otlp_ingest_logs memory utilization +0.58 [+0.48, +0.68] 1 Logs
ddot_logs memory utilization +0.51 [+0.45, +0.57] 1 Logs
otlp_ingest_metrics memory utilization +0.34 [+0.19, +0.50] 1 Logs
docker_containers_memory memory utilization +0.31 [+0.24, +0.38] 1 Logs
quality_gate_idle memory utilization +0.22 [+0.18, +0.27] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.15 [-0.08, +0.38] 1 Logs
ddot_metrics memory utilization +0.11 [-0.11, +0.33] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.10 [-0.06, +0.25] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.03, +0.06] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.08, +0.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.38, +0.39] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.14, +0.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.44, +0.39] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.04 [-0.10, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.58, +0.43] 1 Logs
file_tree memory utilization -0.12 [-0.17, -0.06] 1 Logs
quality_gate_idle_all_features memory utilization -0.19 [-0.22, -0.15] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.33 [-1.83, +1.17] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.68 [-0.90, -0.47] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.89 [-1.09, -0.69] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.03 [-1.11, -0.96] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Copy Markdown
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, but approving

---
fixes:
- |
Detect correct launch type for ECS Managed Instances when running in daemon mode.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Detect correct launch type for ECS Managed Instances when running in daemon mode.
Detect the correct launch type for ECS Managed Instances when running in daemon mode.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 7a193bc into 7.77.x Feb 27, 2026
387 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the backport-46947-to-7.77.x branch February 27, 2026 00:16
@github-actions github-actions Bot added this to the 7.77.0 milestone Feb 27, 2026
AliDatadog added a commit that referenced this pull request Mar 9, 2026
Add project-specific review guidelines for AI code reviewers (Codex,
Claude Code), covering: E2E coverage with fakeintake, branch-conditional
CI blind spots, multi-platform divergence, concurrency lifecycle,
graceful degradation, documentation freshness, and PR template adherence.

Also add a maintenance section encouraging organic growth of guidelines.

Derived from analysis of backport bug fixes: #47251, #47185, #47073,
#47509, #47028, #46978, #46979, #47003, #46955, #47256.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bot internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/agent-runtimes team/container-platform The Container Platform Team team/ecs-experiences Issues and PRs owned by the ECS Experiences team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant