[Backport 7.77.x] [WINA-2414] fix the powershell script path#47251
[Backport 7.77.x] [WINA-2414] fix the powershell script path#47251gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into7.77.xfrom
Conversation
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
Started pipeline #100087488 |
Made-with: Cursor
Made-with: Cursor
9083905 to
718c746
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 4a4893b Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.87 | [+1.76, +7.98] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.87 | [+1.76, +7.98] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.64 | [+0.55, +0.73] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.60 | [+0.44, +0.75] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.44 | [+0.23, +0.66] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.26 | [+0.20, +0.33] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.26 | [+0.15, +0.37] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.16 | [+0.12, +0.20] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.06 | [-0.14, +0.27] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.03 | [-0.13, +0.19] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.04, +0.05] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.13, +0.13] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.15, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.03 | [-0.08, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.04 | [-0.52, +0.44] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.47, +0.38] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.06 | [-0.10, -0.01] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.07 | [-0.45, +0.31] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.19 | [-0.42, +0.04] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.25 | [-0.30, -0.20] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.33 | [-0.42, -0.25] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.58 | [-0.78, -0.38] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.74 | [-2.30, +0.82] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Add project-specific review guidelines for AI code reviewers (Codex, Claude Code), covering: E2E coverage with fakeintake, branch-conditional CI blind spots, multi-platform divergence, concurrency lifecycle, graceful degradation, documentation freshness, and PR template adherence. Also add a maintenance section encouraging organic growth of guidelines. Derived from analysis of backport bug fixes: #47251, #47185, #47073, #47509, #47028, #46978, #46979, #47003, #46955, #47256. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport d1d06eb from #47159.
What does this PR do?
This PR fixes path for the template
powershell-script-config.yamlat installation of the PAR in Windows Agent.Motivation
At installation, the path prefix for the
powershell-script-config.yamlwas assigned in the wrong place, which resulted in a dead-end path and the file was never packaged.Describe how you validated your changes
Installed msi from the artefact from this PR pipeline and confirmed the powershell-script-config.yaml lands under C:\ProgramData\Datadog\private-action-runner\ after installation. Confirmed as well that the auto-created script connection points to this path.
Additional Notes