[Backport 7.76.x] Rework portlist poller to open /proc/net/* fresh on each poll#47028
Conversation
…) ### What does this PR do? After a tentative fix, the present change implements the consensus established in a [review comment](#46927 (comment)). It replaces the fd-caching + seek pattern with plain open-per-poll: - drops `procNetFiles []*os.File` from `linuxImpl`, - opens each `/proc/net/{tcp,tcp4,udp,udp6}` anew in `AppendListeningPorts`, closed immediately after parsing, - eliminates `lseek` on `/proc/net/*` entirely, sidestepping the `ESPIPE` [regression introduced in Linux 6.6.102/6.12.42](https://lore.kernel.org/all/20250815195616.64497967@chagall.paradoxon.rec/). With no fds to release, `Close()` became a no-op on all platforms; it is therefore removed from `osImpl`, `Poller`, and all (empty) implementations, along with `TestClose` and the sole external call site in `port.go`. This allows to always enable portlist unit test by also reverting: - #46909. ### Motivation Triggered by: - #incident-50065 - #incident-50070 - #incident-50071 Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com> (cherry picked from commit f4d3c85) ___ Co-authored-by: Régis Desgroppes <rdesgroppes@gmail.com>
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
29 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 42b6772 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +0.87 | [-2.21, +3.96] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.98 | [+1.76, +2.20] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.89 | [+0.73, +1.04] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | +0.87 | [-2.21, +3.96] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.44 | [+0.37, +0.51] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.41 | [+0.36, +0.45] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.40 | [+0.17, +0.62] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.23 | [+0.19, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.07 | [+0.02, +0.12] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.04 | [-0.05, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.42, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.11, +0.14] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.12, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.50, +0.51] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.11, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.02 | [-0.07, +0.03] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.05 | [-0.12, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.09, -0.01] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.11 | [-0.50, +0.28] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.36 | [-0.52, -0.19] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.58 | [-0.65, -0.51] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -1.17 | [-1.39, -0.96] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.91 | [-3.41, -0.41] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
aac3c91
into
7.76.x
Add project-specific review guidelines for AI code reviewers (Codex, Claude Code), covering: E2E coverage with fakeintake, branch-conditional CI blind spots, multi-platform divergence, concurrency lifecycle, graceful degradation, documentation freshness, and PR template adherence. Also add a maintenance section encouraging organic growth of guidelines. Derived from analysis of backport bug fixes: #47251, #47185, #47073, #47509, #47028, #46978, #46979, #47003, #46955, #47256. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Backport f4d3c85 from #46927.
What does this PR do?
After a tentative fix, the present change implements the consensus established in a review comment.
It replaces the fd-caching + seek pattern with plain open-per-poll:
procNetFiles []*os.FilefromlinuxImpl,/proc/net/{tcp,tcp4,udp,udp6}anew inAppendListeningPorts, closed immediately after parsing,lseekon/proc/net/*entirely, sidestepping theESPIPEregression introduced in Linux 6.6.102/6.12.42.With no fds to release,
Close()became a no-op on all platforms; it is therefore removed fromosImpl,Poller, and all (empty) implementations, along withTestCloseand the sole external call site inport.go.This allows to always enable portlist unit test by also reverting:
Motivation
Triggered by:
(for
7.76.x, that's #incident-50204 and #incident-50205)