Skip to content

[Backport 7.77.x] Fix Viper AllFlattenedSettingsWithSequenceID implementation#47185

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into7.77.xfrom
backport-46997-to-7.77.x
Mar 4, 2026
Merged

[Backport 7.77.x] Fix Viper AllFlattenedSettingsWithSequenceID implementation#47185
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into7.77.xfrom
backport-46997-to-7.77.x

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented Mar 2, 2026

Backport 1782958 from #46997.


What does this PR do?

Fixes AllFlattenedSettingsWithSequenceID() in Viper to match nodetreemodel (NTM) semantics by replacingViper.AllKeys() with a custom leaf-key implementation.

Motivation

Viper.AllKeys() recursively flattens map values with . delimiters, emitting non-schema keys like: additional_endpoints.https://url1.com

Describe how you validated your changes

  • Additional unit tests
  • E22 Test:
    1. Run the agent with additional_endpoints configured.
    2. Run ADP with DD_DATA_PLANE_USE_NEW_CONFIG_STREAM_ENDPOINT=true
    3. Observe that ADP no longer crashes.

Additional Notes

… ### What does this PR do? Fixes `AllFlattenedSettingsWithSequenceID()` in Viper to match nodetreemodel (NTM) semantics by replacing`Viper.AllKeys()` with a custom leaf-key implementation.

### Motivation
 `Viper.AllKeys()` recursively flattens map **values** with `.` delimiters, emitting non-schema keys like: `additional_endpoints.https://url1.com`

### Describe how you validated your changes
- Additional unit tests
- E22 Test:
  1. Run the agent with `additional_endpoints` configured.
  2. Run ADP with `DD_DATA_PLANE_USE_NEW_CONFIG_STREAM_ENDPOINT=true`
  3. Observe that ADP no longer crashes.
### Additional Notes

Co-authored-by: raymond.zhao <raymond.zhao@datadoghq.com>
(cherry picked from commit 1782958)

___

Co-authored-by: Raymond Zhao <35050708+rayz@users.noreply.github.com>
@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner March 2, 2026 18:47
@dd-octo-sts dd-octo-sts Bot added ask-review Ask required teams to review this PR backport bot changelog/no-changelog No changelog entry needed internal Identify a non-fork PR labels Mar 2, 2026
@dd-octo-sts dd-octo-sts Bot requested a review from rahulkaukuntla March 2, 2026 18:47
@dd-octo-sts dd-octo-sts Bot added medium review PR review might take time qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-configuration changelog/no-changelog No changelog entry needed backport bot ask-review Ask required teams to review this PR internal Identify a non-fork PR labels Mar 2, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr Bot commented Mar 2, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4a4893b
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64_fips +4.0 KiB (0.00% increase) 715.088 → 715.092 → 720.180
agent_heroku_amd64 +4.0 KiB (0.00% increase) 323.756 → 323.760 → 329.530
agent_msi +2.5 KiB (0.00% increase) 622.544 → 622.547 → 1073.220
agent_rpm_amd64_fips +4.0 KiB (0.00% increase) 715.072 → 715.076 → 720.160
agent_rpm_arm64_fips +4.0 KiB (0.00% increase) 696.211 → 696.215 → 703.390
agent_suse_amd64_fips +4.0 KiB (0.00% increase) 715.072 → 715.076 → 720.160
agent_suse_arm64_fips +4.0 KiB (0.00% increase) 696.211 → 696.215 → 703.390
24 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 756.411 MiB
agent_rpm_amd64 756.394 MiB
agent_rpm_arm64 734.516 MiB
agent_suse_amd64 756.394 MiB
agent_suse_arm64 734.516 MiB
docker_agent_amd64 817.432 MiB
docker_agent_arm64 820.289 MiB
docker_agent_jmx_amd64 1008.343 MiB
docker_agent_jmx_arm64 999.983 MiB
docker_cluster_agent_amd64 203.000 MiB
docker_cluster_agent_arm64 217.455 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.500 MiB
docker_dogstatsd_arm64 36.812 MiB
dogstatsd_deb_amd64 29.724 MiB
dogstatsd_deb_arm64 27.881 MiB
dogstatsd_rpm_amd64 29.724 MiB
dogstatsd_suse_amd64 29.724 MiB
iot_agent_deb_amd64 42.617 MiB
iot_agent_deb_arm64 39.723 MiB
iot_agent_deb_armhf 40.447 MiB
iot_agent_rpm_amd64 42.618 MiB
iot_agent_suse_amd64 42.618 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +7.21 KiB (0.00% increase) 185.668 → 185.675 → 186.090
agent_deb_amd64_fips -8.52 KiB (0.00% reduction) 176.285 → 176.276 → 180.330
agent_heroku_amd64 neutral 87.105 MiB → 88.440
agent_msi -56.0 KiB (0.04% reduction) 149.391 → 149.336 → 154.470
agent_rpm_amd64 +28.74 KiB (0.01% increase) 187.590 → 187.618 → 189.170
agent_rpm_amd64_fips -9.02 KiB (0.00% reduction) 178.419 → 178.411 → 181.060
agent_rpm_arm64 +43.08 KiB (0.02% increase) 169.832 → 169.874 → 170.020
agent_rpm_arm64_fips -65.86 KiB (0.04% reduction) 162.535 → 162.471 → 164.130
agent_suse_amd64 +28.74 KiB (0.01% increase) 187.590 → 187.618 → 189.170
agent_suse_amd64_fips -9.02 KiB (0.00% reduction) 178.419 → 178.411 → 181.060
agent_suse_arm64 +43.08 KiB (0.02% increase) 169.832 → 169.874 → 170.020
agent_suse_arm64_fips -65.86 KiB (0.04% reduction) 162.535 → 162.471 → 164.130
docker_agent_amd64 +6.46 KiB (0.00% increase) 277.931 → 277.938 → 279.410
docker_agent_arm64 -7.99 KiB (0.00% reduction) 265.210 → 265.202 → 267.960
docker_agent_jmx_amd64 +3.12 KiB (0.00% increase) 346.592 → 346.595 → 348.040
docker_agent_jmx_arm64 neutral 329.847 MiB → 332.560
docker_cluster_agent_amd64 -8.3 KiB (0.01% reduction) 71.131 → 71.123 → 71.920
docker_cluster_agent_arm64 neutral 66.774 MiB → 67.220
docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.236 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.741 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.865 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.865 MiB → 8.800
iot_agent_deb_amd64 +5.74 KiB (0.05% increase) 11.236 → 11.242 → 12.040
iot_agent_deb_arm64 neutral 9.601 MiB → 10.450
iot_agent_deb_armhf neutral 9.801 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.256 MiB → 12.060
iot_agent_suse_amd64 neutral 11.256 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Mar 3, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5f70f67f-cce1-44d4-b3eb-e066d58c29ad

Baseline: 4a4893b
Comparison: 2f4fbaf
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.49 [-3.51, +2.54] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs memory utilization +0.50 [+0.40, +0.59] 1 Logs
docker_containers_memory memory utilization +0.48 [+0.39, +0.56] 1 Logs
quality_gate_idle memory utilization +0.45 [+0.41, +0.50] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.20 [+0.13, +0.26] 1 Logs
ddot_metrics_sum_delta memory utilization +0.16 [-0.04, +0.36] 1 Logs
quality_gate_idle_all_features memory utilization +0.13 [+0.09, +0.17] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization +0.05 [-0.11, +0.20] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.38, +0.44] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.14] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.38, +0.38] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.01 [-0.24, +0.21] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.48, +0.45] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.08, +0.01] 1 Logs
file_tree memory utilization -0.04 [-0.09, +0.00] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.23, -0.08] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.22 [-0.37, -0.07] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.30 [-0.35, -0.24] 1 Logs
ddot_metrics memory utilization -0.30 [-0.52, -0.09] 1 Logs
quality_gate_metrics_logs memory utilization -0.37 [-0.57, -0.16] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -0.49 [-3.51, +2.54] 1 Logs
quality_gate_logs % cpu utilization -1.27 [-2.75, +0.20] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 67c49b8 into 7.77.x Mar 4, 2026
285 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the backport-46997-to-7.77.x branch March 4, 2026 00:20
@github-actions github-actions Bot added this to the 7.77.0 milestone Mar 4, 2026
AliDatadog added a commit that referenced this pull request Mar 9, 2026
Add project-specific review guidelines for AI code reviewers (Codex,
Claude Code), covering: E2E coverage with fakeintake, branch-conditional
CI blind spots, multi-platform divergence, concurrency lifecycle,
graceful degradation, documentation freshness, and PR template adherence.

Also add a maintenance section encouraging organic growth of guidelines.

Derived from analysis of backport bug fixes: #47251, #47185, #47073,
#47509, #47028, #46978, #46979, #47003, #46955, #47256.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR backport bot changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant