Add new guidelines to AGENTS.md#47576
Add new guidelines to AGENTS.md#47576gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
a9e6815 to
3a6227a
Compare
7dcb7b0 to
96454a2
Compare
cf985d5 to
e114950
Compare
Add project-specific review guidelines for AI code reviewers (Codex, Claude Code), covering: E2E coverage with fakeintake, branch-conditional CI blind spots, multi-platform divergence, concurrency lifecycle, graceful degradation, documentation freshness, and PR template adherence. Also add a maintenance section encouraging organic growth of guidelines. Derived from analysis of backport bug fixes: #47251, #47185, #47073, #47509, #47028, #46978, #46979, #47003, #46955, #47256. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e114950 to
b2160c1
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Files inventory check summaryFile checks results against ancestor f608e6b9: Results for datadog-agent_7.78.0~devel.git.422.b2160c1.pipeline.101250376-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b6f8af8 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.29 | [-3.33, +2.75] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_memory | memory utilization | +1.80 | [+1.63, +1.97] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.53 | [+0.39, +0.68] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.48 | [+0.29, +0.67] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.39 | [+0.34, +0.44] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.37 | [+0.33, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.34 | [+0.10, +0.57] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.30 | [+0.19, +0.40] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.09 | [-0.36, +0.55] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.09 | [+0.04, +0.15] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.08 | [-0.02, +0.18] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.03 | [-0.02, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.03 | [-0.37, +0.42] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.02 | [-0.03, +0.08] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.18, +0.17] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.18, +0.17] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.03 | [-0.46, +0.41] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.03 | [-0.08, +0.03] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.05 | [-1.60, +1.49] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.15 | [-0.31, +0.01] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.19 | [-0.42, +0.04] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.28 | [-0.43, -0.13] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.29 | [-3.33, +2.75] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 705 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 275.18MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 727 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.92MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 490.04MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 202.38MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 344.47 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 423.84MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
### What does this PR do? Adds review guidelines and a maintenance section to `AGENTS.md`. ### Motivation Analysis of backport bug fixes revealed recurring patterns. These guidelines give AI reviewers (Codex, Claude Code) project-specific context to catch similar issues earlier. ### Describe how you validated your changes Documentation-only change. ### Additional Notes N/A Co-authored-by: ali.benabdallah <ali.benabdallah@datadoghq.com>
What does this PR do?
Adds review guidelines and a maintenance section to
AGENTS.md.Motivation
Analysis of backport bug fixes revealed recurring patterns. These guidelines give AI reviewers (Codex, Claude Code) project-specific context to catch similar issues earlier.
Describe how you validated your changes
Documentation-only change.
Additional Notes
N/A