forked from openwebwork/pg
-
Notifications
You must be signed in to change notification settings - Fork 0
Edfinity 2.17 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeff-r
wants to merge
252
commits into
master
Choose a base branch
from
edfinity-2.17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve problem with space after function to a power. (openwebwork#598)
Resolve problem with space after function to a power. (openwebwork#598)
…wers = 1; Copied over functions (e.g. "numNeeded") from the original draggableProof.pl which might be called by certain pg problems.
Also, a previous update broke scoring-by-edit-distance. The variable $actualAnswer in draggableProof.pl is redefined to address this.
Fixed NEW_ANS_NAME in DragNDrop.pm POD Removed obsolete comment in POD of draggableProof.pl and draggableSubets.pl
Co-authored-by: Glenn Rice <47527406+drgrice1@users.noreply.github.com>
This fixes issue openwebwork/webwork2#1739. In the PG problem editor, the page in the iframe is not displayed until after the page loads. As such the javascript getComputedStyle method fails. The same things happens with the graphtool. The same solution is now implemented for knowls.
Make knowls wait until the page css has loaded before initializing.
There are no known issues here as there were for webwork2, but this is a precautionary measure.
Add the package-lock.json file here too.
This did not get updated to the new versions of bootstrap and fontawesome.
…utton Fix the mathview button for essay answers.
correct 'LaTeXImage' to 'PGlateximage'
It turns out @taniwallach was correct in that the javascript conversion method does work. See the discussion in openwebwork#728. There is still some more work that is needed here (cleanup really). The se_javascript_for_live3d option needs to be removed, and that needs to be always used. Setting that option to 0 will fail in any case. This pull request makes these problems work at least.
Currently if you graph three consecutive points where each point is one unit to the left of the previously graphed point, then when the third point is graphed there will be an error that causes the graph tool to become mostly unresponsive. The problem was an undefined variable being used in phase3 of that tool.
…ool-third-point-hotfix Fix graphing of the third point for the GraphTool cubictool. (hotfix)
…s-3d-hotfix Restore the functionality of the LiveGraphics3D.pl macro. (hotfix)
…states. I disovered this thanks to an observation of @drdrew's while attempting to diagnose an issue with a Geogebra problem written by another author. It turns out that one part of the problem was the applet state being doubly base64 encoded.
…-encoding-hotfix Fix an errant regex check that doubly base64 encoded Geogebra applet states (hotfix)
With breaking changes coming to MathQuill, PG-2.17 needs to be locked into using the current version of MathQuill. This locks PG-2.17 to the WeBWorK-2.17 tag in our MathQuill repository.
…l-version Lock the MathQuill version installed by npm (hotfix).
Removes [yaml](https://github.com/eemeli/yaml). It's no longer used after updating ancestor dependency [cssnano](https://github.com/cssnano/cssnano). These dependencies need to be updated together. Removes `yaml` Updates `cssnano` from 5.1.12 to 6.0.0 - [Release notes](https://github.com/cssnano/cssnano/releases) - [Commits](https://github.com/cssnano/cssnano/compare/cssnano@5.1.12...cssnano@6.0.0) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect - dependency-name: cssnano dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…d_yarn/htdocs/yaml-and-cssnano--removed Bump yaml and cssnano in /htdocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.