Remove Review button from Inbox and Reports page v2

[nkdengineer]

Explanation of Change

Fixed Issues

$ #72486
$ #74376
$ #74377
$ #74378
$ #74382
$ #74395
$ #74415
$ #74447
PROPOSAL:

Tests

• [Due for payment 2025-12-12] [$125] [CFI] Remove Review button from Inbox and Reports page #72486

1. Create a new workspace
2. Create 2 expenses with violations to this workspace
3. Go to expense chat page
4. Verify that: View button is displayed
5. Go to search page
6. Verify that: Submit button and 'report contains expenses with violations.' is displayed

• [Due for payment 2025-12-12] [Due for payment 2025-11-14] [Due for payment 2025-11-13] Reports - View button is shown instead of Submit button when expense does not have merchant #74377

Precondition:

• Account has self DM and a workspace

1. Go to self DM
2. Create an expense without merchant
3. Open the report
4. Click Report
5. Click Create report
6. Go to Reports > Reports
7. Verify that the submit button is shown

• [Due for payment 2025-12-12] [Due for payment 2025-11-14] [Due for payment 2025-11-13] Reports - Submit button opens the report instead of submitting it when expense is held #74378

1. Go to workspace chat.
2. Create an expense.
3. Open the expense report.
4. Click More > Hold.
5. Enter reason and save it.
6. Go to Reports > Reports.
7. Click Submit on the report row
8. Verify that the report is submitted

• [Due for payment 2025-12-12] [Due for payment 2025-11-14] [Due for payment 2025-11-13] Android - Reports - RBR is cut off and missing violation when report row is collapsed #74382

1. Go to workspace chat
2. Create an expense without category
3. Go to Reports > Reports
4. Verify that the RBR message is not cut off

• [Due for payment 2025-12-12] Reports - Expense violation is shown when collapsed when the report is paid #74395

Precondition: The approval and payment are enabled

1. Go to workspace chat
2. Create an expense without category
3. Click Submit, Approve and Mark as paid
4. Go to Reports > Reports
5. Verify that expense violation will not be displayed when collapsed

• [Due for payment 2025-12-12] Held expenses - Mark as paid button on Reports pays the pending amount without paying option #74447

Precondition: The workspace disabled approval and the payment is enabled

1. Go to workspace chat
2. Create two expenses
3. Hold one expense
4. Submit the expense
5. Go to Reports > Pay
6. Verify that the View button is shown

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

am.mov

iOS: Native

i.mov

iOS: mWeb Safari

im.mov

MacOS: Chrome / Safari

web.mov

Screen.Recording.2025-11-10.at.14.39.47.mov

MacOS: Desktop

des.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	85.98% <ø> (ø)
...ReportPreview/MoneyRequestReportPreviewContent.tsx	59.72% <100.00%> (-2.01%)	⬇️
...portActionItem/MoneyRequestReportPreview/index.tsx	93.10% <ø> (ø)
src/libs/ReportPreviewActionUtils.ts	90.72% <100.00%> (-0.89%)	⬇️
src/libs/TransactionUtils/index.ts	70.90% <100.00%> (-0.24%)	⬇️
src/libs/actions/Search.ts	21.97% <100.00%> (ø)
src/components/MoneyReportHeader.tsx	0.17% <0.00%> (ø)
...ts/SelectionListWithSections/Search/ActionCell.tsx	56.00% <66.66%> (ø)
src/libs/SearchUIUtils.ts	71.32% <85.71%> (-0.44%)	⬇️
src/components/AnimatedCollapsible/index.tsx	71.87% <70.00%> (+2.30%)	⬆️
... and 2 more
... and 13 files with indirect coverage changes

[nkdengineer]

#74447
#74376

@puneetlath For approve and pay action, we can't support approve/pay partial/full pattern on Search page. Should we show View button instead? In the past, the Review button is shown in this case.

[nkdengineer]

@puneetlath #74415. This issue happens because an unexpected violation is created when moving expense offline. We should create a new issue for this since it's on production.

[puneetlath]

@puneetlath #74415. This issue happens because an unexpected violation is created when moving expense offline. We should create a new issue for this since it's on production.

Ok sounds good.

@puneetlath For approve and pay action, we can't support approve/pay partial/full pattern on Search page. Should we show View button instead? In the past, the Review button is shown in this case.

Can you remind me what that pattern is?

[nkdengineer]

Can you remind me what that pattern is?

@puneetlath Here is what I means.

Screen.Recording.2025-11-11.at.16.32.12.mov

[puneetlath]

Ah, got it. I think we should probably implement that functionality on the Reports page then. So that users can use that Approve button correctly there.

[nkdengineer]

Ah, got it. I think we should probably implement that functionality on the Reports page then. So that users can use that Approve button correctly there.

@puneetlath This will require the backend change for WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH API and it might be complicated. I think we should show the view button now or still show the approve button but will redirect the user to the expense report if has the held expense. Then we will implement it as a seperate issue if needed later.

[puneetlath]

Ok, let's use the View button for now, but let's address it in follow-up.

[melvin-bot]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[puneetlath]

@nkdengineer are you saying this lint failure is also occurring on main?

[nkdengineer]

warning Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function rulesdir/no-onyx-connect

This is related to remove Onyx.connect which has failed because we changed this file

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #74541.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
https://74541.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[youssef-lr]

We need to either fix it or silence it in this PR @nkdengineer. Otherwise main will start failing.

[puneetlath]

It seems to work well from my testing of the PR. @nkdengineer can you address the lint issue though as @youssef-lr mentioned?

[puneetlath]

@dubielzyk-expensify mind also confirming you're good with it from a design perspective?

[dannymcclain]

Looking good from a design perspective to me!

[OSBotify]

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.72-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[Julesssss]

Small issue introduced with this change.

[Julesssss]

@nkdengineer @puneetlath @youssef-lr @eVoloshchak could you please resolve #76731 as a follow-up, to avoid requiring more external payments. Thanks

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅