Translation yilei by Zachary-Wu · Pull Request #3989 · Rdatatable/data.table

Zachary-Wu · 2019-10-23T09:05:30Z

No description provided.

MichaelChirico · 2019-10-23T09:13:06Z

Excellent, thanks Yilei! Please help to review @shawnchen1996

Zachary-Wu · 2019-10-23T09:51:16Z

OK, no problem. but it may cost another week. I am a little busy now, cause you know I have to report my lab-work next Friday.

…

On Wed, Oct 23, 2019 at 5:13 PM Michael Chirico ***@***.***> wrote: Excellent, thanks Yilei! Please help to review @ShawnChen1996 <https://github.com/ShawnChen1996> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3989?email_source=notifications&email_token=AHJRQJA27TIRR4XRVCTPTOTQQAIS3A5CNFSM4JD6GILKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAV4IA#issuecomment-545349152>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJRQJAYGC2KAII5ET3KFDLQQAIS3ANCNFSM4JD6GILA> .

MichaelChirico · 2019-10-23T09:56:34Z

@Zachary-Wu oh, sorry, I meant that @ShawnChen1996 should review this PR. Your review task will be for Jianda Shi (not yet filed).

In any case, there will be at least 3 more weeks before I hope to wrap up all the PRs. Fret not!

Zachary-Wu · 2019-10-23T10:09:56Z

O, it is my fault. I am a little confused by @. O(∩_∩)O~

…

On Wed, Oct 23, 2019 at 5:56 PM Michael Chirico ***@***.***> wrote: @Zachary-Wu <https://github.com/Zachary-Wu> oh, sorry, I meant that @ShawnChen1996 <https://github.com/ShawnChen1996> should review this PR. Your review task will be for Jianda Shi (not yet filed). In any case, there will be at least 3 more weeks before I hope to wrap up all the PRs. Fret not! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3989?email_source=notifications&email_token=AHJRQJHNKFZ4DIZQWLJSH2TQQANV3A5CNFSM4JD6GILKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECA2CWA#issuecomment-545366360>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJRQJCBU56HCDEF6HMXGP3QQANV3ANCNFSM4JD6GILA> .

shawnchenx6 · 2019-10-23T14:36:12Z


 msgid "columns but its names are length"
-msgstr ""
+msgstr "很多纵列，但纵列的名字是"


May need context to decide what it really means

The code generating this is from setnames:

if (length(names(x)) != ncol) stop("x has ",ncol," columns but its names are length ",length(names(x)))

This error can be triggered like

DT = list(1, 2) setattr(DT, 'class', class(data.table())) setnames(DT, c('a', 'b'))

Error in setnames(DT, c("a", "b")) : x has 2 columns but its names are length 0

msgstr "列，但其列名的长度为"

shawnchenx6 · 2019-10-23T14:38:13Z


 msgid "Passed a vector of type '"
-msgstr ""
+msgstr "传递了类型向量的长度值；"


should be "传递了一个向量，元素类型是"

shawnchenx6 · 2019-10-23T14:39:36Z


 msgid "'. Needs to be type 'character'."
-msgstr ""
+msgstr "需要按 'character'类型"


. 需要是‘character’ 类型

shawnchenx6

I left comment where I think need some changes. Only the fisrt file is reviewed. quiet busy for the next 1 week

shawnchenx6 · 2019-11-02T11:43:18Z

 #: fmelt.c:673
 msgid "Input is not of type VECSXP, expected a data.table, data.frame or list"
-msgstr ""
+msgstr "输入类型不能是 VECSXP，输入类型应该是 data.table," "data.frame 或 list"


I think it should be "输入类型不是 VECSXP，输入类型应该是 data.table," "data.frame 或 list"
I suppose type VECSXP is a base class of data.table, data.frame or list

The suggested replacement is the same as the original? Sorry I'm not seeing a difference.

FWIW VECSXP is the C-level storage type of list objects in R (and recall in terms of data storage, data.frame and data.table are both just special types of lists)

One character difference between my suggestion and the original.
"不能是VECSXP" and "不是VECSXP".
The former one means "the input can' t be VECSXP". My replacement is "The input is not a VECSXP".

shawnchenx6 · 2019-11-02T11:47:21Z

 #, c-format
 msgid "Failed to realloc thread private group size buffer to %d*4bytes"
-msgstr ""
+msgstr "无法重新将线程私有的组大小缓冲区分割为%d*4字节"


I am not sure if the following is better
"无法将线程私有的组大小缓冲区重新分配为%d*4字节"

shawnchenx6 · 2019-11-02T11:51:50Z

 #, c-format
 msgid "Failed to realloc group size result to %d*4bytes"
-msgstr ""
+msgstr "由于%d*4字节，重新分配组大小失败"


I am a bit confused by this msg. is it that the result should be %d *4 bytes?

When grouping is started, we take a guess at how much storage will be needed. Sometimes, we'll need more than this and have to re-allocate memory to continue; any time memory allocation is done, there's a chance the computer has no memory left and the allocation request will fail.

This error is emitted in one such case -- we're reporting to the user that we tried to realloc %d*4 bytes & failed. %d*4 is the total target amount to be allocated.

Then, my suggestion is "分配%d*4字节内存时失败"

shawnchenx6

I have reviewed the the second file. There are several places that could be made more clear and readable.

MichaelChirico · 2019-12-04T09:40:39Z

Hey @Zachary-Wu please help to incorporate the suggested improvements when you get a chance. Thanks again!

Zachary-Wu · 2019-12-11T00:55:26Z

I think @ShawnChen1996's translation is more accurate.

…on-Yilei

…a.table into Translation-Yilei

MichaelChirico · 2019-12-12T03:37:54Z

Thanks @Zachary-Wu and @ShawnChen1996 !!

@shrektan

* initial exploration of adding a chinese translation of messages working version of chinese translation * adding another .mo file that was untracked * trying to get the .pot for src/ files * adding warning()s from C * C messages with DTPRINT or Rprintf * adding STOP messages * DTWARN messages * Error in forder * odds&ends more messages * cannot use _() with \r * update .pot for src files * moving pot file to po/ * update header metadata for src .pot * run update_pkg_po on the src to get mo files * update_pkg_po after merge * add template message in onAttach() & clear typos/PYDT issue along the way * remove some strings * improve arg checking&message in groupingsets; add some messages * get tests working (fix some bad quotes, adjust to new messages) * update po with latest message edits * Finished the translation assigned to Chun-Hui Gao (#3983) * Finished the translation of line 3058-3231 in po/zh_CN.po. Totally 34 messages. * Finished the translation assigned to Chun-Hui Gao in R-zh_cn.po. Lines 1500-1598 in original R-zh_CN.po. Totally 26 messages. * Resolved reviewer's comments. * Resolved reviewer's comments. * (hopefully) apply encoding fix & check compilation * improve internal error & regenerate messages * Finish translation to zh_CN assigned to group 2 (Hongyuan Jia) (#3986) * Finish translation. * Resolve review comments. * balance quotes * extra nocov * some coverage of fmelt * complete coverage of fmelt * fix test error * update message per DeLuns feedback * update message again; some minor tweaks to nearby code * Translation to zh_CN assigned to group 3 (#3985) * translate assigned to group 3 * translate assigned to group 3 * translate assigned to group 3 * remove merge conflict vestiges * remove merge conflict vestiges * plonk * update translation * minor update * added new message caught by xianghui * Translation haogao gu (#4002) * R-zh_CN_2019-10-26 * 10-26 * restore previous * updated with feedback * regenerate with small fix * regenerate .mo files * Translation finished (soappp) (#4023) * readme link examples, rm old link to a talk (#4001) * Homepage additions (#4006) * pkgdown, keep manual tab, link cranlike page, minor rename (#4008) * fix Rd warnings (#4011) * use Rdevel for revdeps due to bioc-devel (3.11) now needing R 4+ * (hopefully) apply encoding fix & check compilation * improve internal error & regenerate messages * Finish translation to zh_CN assigned to group 2 (Hongyuan Jia) (#3986) * Finish translation. * Resolve review comments. * balance quotes * extra nocov * some coverage of fmelt * complete coverage of fmelt * fix test error * update message per DeLuns feedback * update message again; some minor tweaks to nearby code * translatation completed * fixed somme message 1 * fix format tags for two translations * done some translation! * Finish translation to zh_CN assigned to group 5 (Leo Lee) (#3995) * chinese translation by Leo * Update R-zh_CN.po fix a typo * Update zh_CN.po * add missing quotes * number out-of-order format strings * apply numbering to formatters * Update R-zh_CN.po & Change author * Fix the problems of missing %d in zh_CN.po & Polish translation * Translation dracodoc (#4034) * 895 - 939 * 945 - 1007 * To the real 1007 line msg * convert enconding from GBK to UTF-8 * Revert "convert enconding from GBK to UTF-8" This reverts commit 6e65d0e. * translate start and end of assigned msgs. * till 1899 * two entries then found possible problem of missing messages * 10 missing message not captured? * till 1962 * finished assignment * review and edit * update meta info * macro-within-macro removed * syntax error -- split ternary operator * roll back use of translation in ASSERT internal errors * Update according to @shrektan's comments * re-run update_pkg_po * update binaries * Translation caiquanyou (#4039) * finish translation * Update R-zh_CN.po * Update zh_CN.po * update mo files * translation(partial) into zh_CN by Yuanchen Xie (#4010) * translation(partial) into zh_CN by Yuanchen Xie * Add new translation results, based on messages * update mo file * update transitions as renkun-ken's suggestions * update binary mo * update vs recent master * Translation to zh_CN - Group 7 (#4019) * translate R msgs * src error messages * missing quote * missing quote * remove extra quote * fix-up of merge * update po after merge * update fuzzy translations * update mistaken PRIu64->PRId64 * caught a few more failed merges * line # update * rerun update_pkg_po * Translation shawn (#4050) * done some translation! * done some translation! * done some translation * revised the translation * small tweak * Translation yilei (#3989) * messsage * messsage * messsage * messsage * messsage * done some translation! * done it. * updating some small misses from last pull * Translation to zh_CN assigned to group 12 (#3987) * Update translations * Minor refine * Minor reformatting * no longer using %llu, other small tidying * Translation fengqifang (#3990) * First version, finished all message * 2nd one, multiple lines of msgstr * 3rd, finished * zh_CN.po 1st * after zh_CN.po reviewed * fix encoding issue * manually editing per GH UI submission * run update_pkg_po on new merge * done some translation (#4069) * done some translation * do some revisions * touch-up * Translation to zh_CN assigned to group 4 (#3997) * finish R-zh_CN.po * finish zh_CN.po * finalize two files * change author * make the package * finalize the messages * change the format of numbering * install the pacakge * delete excessive src folders * manually revert coding issues (open to a better solution... `iconv(bad_str, from = 'GBK'|'GB18030', to = 'UTF-8')` both returned something gibberish-y. * update mo files * update .mo * add in suggestions from gaospecial * update mo * My part of translation has been completed. It's so happy! (#4051) * messsage * Update R-zh_CN.po * Update R-zh_CN.po * Update zh_CN.po * some revisions due to foreign char, touch-up, remove fuzzy * Translation yuliang li (#4055) * completed yuliang's translation * yuliang's work * Update zh_CN.po Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * tweaks for syntax mistakes * Translation to zh_CN - Group 17 (#4049) * finish the Chinese message translation for group 17 * change as KingdaShi suggests Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * update mo, fix missing field * Translation yc0802 (#4054) * message * message * added hongyuans review Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * adding "leftover" translations (#4143) * done some translation!-kingda (#4046) * done some translation! * done some translation * messsage * messsage Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> * Translation leftover pt2 (#4146) * covering trivial translations from among the leftovers * progress on paring down leftover translations * completed translations!!! * adjustments * missing dot * add note for proceeding to CRAN_Relase * %f needed for > integer max Co-authored-by: Chun-Hui Gao <gaospecial@gmail.com> Co-authored-by: Hongyuan Jia <hongyuan.jia@bears-berkeley.sg> Co-authored-by: biobai <biobai@zju.edu.cn> Co-authored-by: Koohoko <koohoko@gmail.com> Co-authored-by: soappp <soappp9527@gmail.com> Co-authored-by: KingdaShi <50854702+KingdaShi@users.noreply.github.com> Co-authored-by: Guangzheng Li <leolee0828@outlook.com> Co-authored-by: dracodoc <dracodoc@gmail.com> Co-authored-by: caiquanyou <48861819+caiquanyou@users.noreply.github.com> Co-authored-by: Yuanchen Xie <yuanchen.gm@gmail.com> Co-authored-by: Amy Tzu-Yu Chen <amy17519@gmail.com> Co-authored-by: ShawnChen1996 <shawnchen1996@outlook.com> Co-authored-by: Yilei <30611492+Zachary-Wu@users.noreply.github.com> Co-authored-by: Kun Ren <mail@renkun.me> Co-authored-by: fengqifang <nclxin@gmail.com> Co-authored-by: Shayebuhuii <32659317+sunshine1126@users.noreply.github.com> Co-authored-by: Zhi Yang <zhiyang@usc.edu> Co-authored-by: Xueliang24 <56901274+Xueliang24@users.noreply.github.com> Co-authored-by: JulianYlli12 <43525270+JulianYlli12@users.noreply.github.com> Co-authored-by: Xianying Tan <shrektan@126.com> Co-authored-by: yc0802 <55459478+yc0802@users.noreply.github.com>

Zachary-Wu added 6 commits October 19, 2019 18:13

messsage

21eff24

messsage

295f861

messsage

b624b99

messsage

da3bd2b

messsage

7e468b1

done some translation!

3297605

shawnchenx6 reviewed Oct 23, 2019

View reviewed changes

MichaelChirico added the translation issues/PRs related to message translation projects label Oct 29, 2019

shawnchenx6 reviewed Nov 2, 2019

View reviewed changes

Zachary-Wu and others added 5 commits December 12, 2019 10:53

done it.

4b6387e

Merge branch 'translation' into Translation-Yilei

99d8ab6

Merge remote-tracking branch 'yilei/Translation-yilei' into Translati…

4ff03d1

…on-Yilei

Merge branch 'translation' into Translation-Yilei

bcac946

Merge branch 'Translation-yilei' of https://github.com/Zachary-Wu/dat…

55ac904

…a.table into Translation-Yilei

MichaelChirico merged commit dca3e33 into Rdatatable:translation Dec 12, 2019

Conversation

Zachary-Wu commented Oct 23, 2019

Uh oh!

MichaelChirico commented Oct 23, 2019

Uh oh!

Zachary-Wu commented Oct 23, 2019 via email

Uh oh!

MichaelChirico commented Oct 23, 2019

Uh oh!

Zachary-Wu commented Oct 23, 2019 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnchenx6 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnchenx6 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelChirico commented Dec 4, 2019

Uh oh!

Zachary-Wu commented Dec 11, 2019

Uh oh!

MichaelChirico commented Dec 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants