Skip to content

Translation shawn#4050

Merged
MichaelChirico merged 8 commits intoRdatatable:translationfrom
shawnchenx6:translation-shawn
Dec 8, 2019
Merged

Translation shawn#4050
MichaelChirico merged 8 commits intoRdatatable:translationfrom
shawnchenx6:translation-shawn

Conversation

@shawnchenx6
Copy link
Copy Markdown
Contributor

@shawnchenx6 shawnchenx6 commented Nov 17, 2019

No description provided.

@shawnchenx6
Copy link
Copy Markdown
Contributor Author

shawnchenx6 commented Nov 17, 2019

There is a conflict but I don' t see why. @MichaelChirico

@MichaelChirico
Copy link
Copy Markdown
Member

MichaelChirico commented Nov 17, 2019

@ShawnChen1996 have resolved the conflict, please check:

be4ab0a

@MichaelChirico
Copy link
Copy Markdown
Member

MichaelChirico commented Nov 17, 2019

Thanks Xiao! Please have a look @Xueliang24

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Nov 17, 2019
@Xueliang24
Copy link
Copy Markdown
Contributor

Xueliang24 commented Nov 17, 2019 via email

@Xueliang24
Copy link
Copy Markdown
Contributor

Xueliang24 commented Nov 17, 2019 via email

Xueliang24
Xueliang24 reviewed Nov 18, 2019
View reviewed changes
Comment thread po/R-zh_CN.po Outdated
Xueliang24
Xueliang24 reviewed Nov 18, 2019
View reviewed changes
Comment thread po/R-zh_CN.po Outdated
Xueliang24
Xueliang24 reviewed Nov 18, 2019
View reviewed changes
Comment thread po/R-zh_CN.po
"you have o as well if not sorted."
msgstr ""
"请使用'if (length(o <- forderv(DT,by))) ...' , 以便在一步中拥有较好的效率，"
"同时如果你还未排序，你也获得了变量o"
Copy link
Copy Markdown
Contributor

@Xueliang24 Xueliang24 Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"同时如果你还未排序，你也获得了变量o"
"所以如果你还未排序，你也有变量0"

Copy link
Copy Markdown
Contributor Author

@shawnchenx6 shawnchenx6 Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "获得" is a better word here, cuz it explains if you have not sorted it before, you can obtain the variable o by this code. "有" sounds stiff here

Xueliang24
Xueliang24 reviewed Nov 18, 2019
View reviewed changes
Comment thread po/R-zh_CN.po Outdated
Xueliang24
Xueliang24 reviewed Nov 19, 2019
View reviewed changes
Comment thread po/zh_CN.po Outdated
Xueliang24
Xueliang24 suggested changes Nov 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Xueliang24 Xueliang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your translation is so human！May a little improvement.

@MichaelChirico
Copy link
Copy Markdown
Member

MichaelChirico commented Dec 4, 2019

Hey @ShawnChen1996 thanks again for your work! Please have a look at Xueliang's suggestions when you get a chance

@shawnchenx6
Copy link
Copy Markdown
Contributor Author

shawnchenx6 commented Dec 8, 2019

I have already revised the translation e26b10c according to his suggestions except for one place #4050 (comment). And I have marked all other suggestion as resolved.

@MichaelChirico MichaelChirico merged commit 5f3af30 into Rdatatable:translation Dec 8, 2019
@MichaelChirico
Copy link
Copy Markdown
Member

MichaelChirico commented Dec 8, 2019

OK thanks for confirming! Merging. Thanks @ShawnChen1996 and @Xueliang24!!

mattdowle pushed a commit that referenced this pull request Dec 31, 2019
@MichaelChirico @gaospecial
@biobai @Koohoko @soappp9527 @KingdaShi @Leo-Lee15 @dracodoc @caiquanyou @amy17519 @Zachary-Wu @renkun-ken @spxdummy @sunshine1126 @zhiiiyang @Xueliang24 @JulianYlli12 @shrektan @yc0802 @mattdowle
Add Chinese error message translations (#3935)
ff076a7 
* initial exploration of adding a chinese translation of messages

working version of chinese translation

* adding another .mo file that was untracked

* trying to get the .pot for src/ files

* adding warning()s from C

* C messages with DTPRINT or Rprintf

* adding STOP messages

* DTWARN messages

* Error in forder

* odds&ends more messages

* cannot use _() with \r

* update .pot for src files

* moving pot file to po/

* update header metadata for src .pot

* run update_pkg_po on the src to get mo files

* update_pkg_po after merge

* add template message in onAttach() & clear typos/PYDT issue along the way

* remove some strings

* improve arg checking&message in groupingsets; add some messages

* get tests working (fix some bad quotes, adjust to new messages)

* update po with latest message edits

* Finished the translation assigned to Chun-Hui Gao (#3983)

* Finished the translation of line 3058-3231 in po/zh_CN.po. Totally 34 messages.

* Finished the translation assigned to Chun-Hui Gao in R-zh_cn.po.

Lines 1500-1598 in original R-zh_CN.po. Totally 26 messages.

* Resolved reviewer's comments.

* Resolved reviewer's comments.

* (hopefully) apply encoding fix & check compilation

* improve internal error & regenerate messages

* Finish translation to zh_CN assigned to group 2 (Hongyuan Jia) (#3986)

* Finish translation.

* Resolve review comments.

* balance quotes

* extra nocov

* some coverage of fmelt

* complete coverage of fmelt

* fix test error

* update message per DeLuns feedback

* update message again; some minor tweaks to nearby code

* Translation to zh_CN assigned to group 3 (#3985)

* translate assigned to group 3

* translate assigned to group 3

* translate assigned to group 3

* remove merge conflict vestiges

* remove merge conflict vestiges

* plonk

* update translation

* minor update

* added new message caught by xianghui

* Translation haogao gu (#4002)

* R-zh_CN_2019-10-26

* 10-26

* restore previous

* updated with feedback

* regenerate with small fix

* regenerate .mo files

* Translation finished (soappp) (#4023)

* readme link examples, rm old link to a talk (#4001)

* Homepage additions (#4006)

* pkgdown, keep manual tab, link cranlike page, minor rename (#4008)

* fix Rd warnings (#4011)

* use Rdevel for revdeps due to bioc-devel (3.11) now needing R 4+

* (hopefully) apply encoding fix & check compilation

* improve internal error & regenerate messages

* Finish translation to zh_CN assigned to group 2 (Hongyuan Jia) (#3986)

* Finish translation.

* Resolve review comments.

* balance quotes

* extra nocov

* some coverage of fmelt

* complete coverage of fmelt

* fix test error

* update message per DeLuns feedback

* update message again; some minor tweaks to nearby code

* translatation completed

* fixed somme message 1

* fix format tags for two translations

* done some translation!

* Finish translation to zh_CN assigned to group 5 (Leo Lee) (#3995)

* chinese translation by Leo

* Update R-zh_CN.po

fix a typo

* Update zh_CN.po

* add missing quotes

* number out-of-order format strings

* apply numbering to formatters

* Update R-zh_CN.po & Change author

* Fix the problems of missing %d in zh_CN.po & Polish translation

* Translation dracodoc (#4034)

* 895 - 939

* 945 - 1007

* To the real 1007 line msg

* convert enconding from GBK to UTF-8

* Revert "convert enconding from GBK to UTF-8"

This reverts commit 6e65d0e.

* translate start and end of assigned msgs.

* till 1899

* two entries then found possible problem of missing messages

* 10 missing message not captured?

* till 1962

* finished assignment

* review and edit

* update meta info

* macro-within-macro removed

* syntax error -- split ternary operator

* roll back use of translation in ASSERT internal errors

* Update according to @shrektan's comments

* re-run update_pkg_po

* update binaries

* Translation caiquanyou (#4039)

* finish translation

* Update R-zh_CN.po

* Update zh_CN.po

* update mo files

* translation(partial) into zh_CN by Yuanchen Xie (#4010)

* translation(partial) into zh_CN by Yuanchen Xie

* Add new translation results, based on messages

* update mo file

* update transitions as renkun-ken's suggestions

* update binary mo

* update vs recent master

* Translation to zh_CN - Group 7 (#4019)

* translate R msgs

* src error messages

* missing quote

* missing quote

* remove extra quote

* fix-up of merge

* update po after merge

* update fuzzy translations

* update mistaken PRIu64->PRId64

* caught a few more failed merges

* line # update

* rerun update_pkg_po

* Translation shawn (#4050)

* done some translation!

* done some translation!

* done some translation

* revised the translation

* small tweak

* Translation yilei (#3989)

* messsage

* messsage

* messsage

* messsage

* messsage

* done some translation!

* done it.

* updating some small misses from last pull

* Translation to zh_CN assigned to group 12 (#3987)

* Update translations

* Minor refine

* Minor reformatting

* no longer using %llu, other small tidying

* Translation fengqifang (#3990)

* First version, finished all message

* 2nd one, multiple lines of msgstr

* 3rd, finished

* zh_CN.po 1st

* after zh_CN.po reviewed

* fix encoding issue

* manually editing per GH UI submission

* run update_pkg_po on new merge

* done some translation (#4069)

* done some translation

* do some revisions

* touch-up

* Translation to zh_CN assigned to group 4 (#3997)

* finish R-zh_CN.po

* finish zh_CN.po

* finalize two files

* change author

* make the package

* finalize the messages

* change the format of numbering

* install the pacakge

* delete excessive src folders

* manually revert coding issues

(open to a better solution... `iconv(bad_str, from = 'GBK'|'GB18030', to = 'UTF-8')` both returned something gibberish-y.

* update mo files

* update .mo

* add in suggestions from gaospecial

* update mo

* My part of translation has been completed. It's so happy! (#4051)

* messsage

* Update R-zh_CN.po

* Update R-zh_CN.po

* Update zh_CN.po

* some revisions due to foreign char, touch-up, remove fuzzy

* Translation yuliang li (#4055)

* completed yuliang's translation

* yuliang's work

* Update zh_CN.po

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* tweaks for syntax mistakes

* Translation to zh_CN - Group 17 (#4049)

* finish the Chinese message translation for group 17

* change as KingdaShi suggests

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* update mo, fix missing field

* Translation yc0802 (#4054)

* message

* message

* added hongyuans review

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* adding "leftover" translations (#4143)

* done some translation!-kingda (#4046)

* done some translation!

* done some translation

* messsage

* messsage

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* Translation leftover pt2 (#4146)

* covering trivial translations from among the leftovers

* progress on paring down leftover translations

* completed translations!!!

* adjustments

* missing dot

* add note for proceeding to CRAN_Relase

* %f needed for > integer max

Co-authored-by: Chun-Hui Gao <gaospecial@gmail.com>
Co-authored-by: Hongyuan Jia <hongyuan.jia@bears-berkeley.sg>
Co-authored-by: biobai <biobai@zju.edu.cn>
Co-authored-by: Koohoko <koohoko@gmail.com>
Co-authored-by: soappp <soappp9527@gmail.com>
Co-authored-by: KingdaShi <50854702+KingdaShi@users.noreply.github.com>
Co-authored-by: Guangzheng Li <leolee0828@outlook.com>
Co-authored-by: dracodoc <dracodoc@gmail.com>
Co-authored-by: caiquanyou <48861819+caiquanyou@users.noreply.github.com>
Co-authored-by: Yuanchen Xie <yuanchen.gm@gmail.com>
Co-authored-by: Amy Tzu-Yu Chen <amy17519@gmail.com>
Co-authored-by: ShawnChen1996 <shawnchen1996@outlook.com>
Co-authored-by: Yilei <30611492+Zachary-Wu@users.noreply.github.com>
Co-authored-by: Kun Ren <mail@renkun.me>
Co-authored-by: fengqifang <nclxin@gmail.com>
Co-authored-by: Shayebuhuii <32659317+sunshine1126@users.noreply.github.com>
Co-authored-by: Zhi Yang <zhiyang@usc.edu>
Co-authored-by: Xueliang24 <56901274+Xueliang24@users.noreply.github.com>
Co-authored-by: JulianYlli12 <43525270+JulianYlli12@users.noreply.github.com>
Co-authored-by: Xianying Tan <shrektan@126.com>
Co-authored-by: yc0802 <55459478+yc0802@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Xueliang24 Xueliang24 Xueliang24 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

translation issues/PRs related to message translation projects

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawnchenx6 @MichaelChirico @Xueliang24