Skip to content

Conversation

@GoogleFrog
Copy link
Contributor

I already did the merge hell from chobby -> ZK.

Note that I reverted the changes to LuaMenu/widgets/chobby/components/battle/battle_list_window.lua since they remove intended functionality.

GoogleFrog and others added 30 commits July 21, 2019 12:46
…ion. Made the download popup able to download a list of games.
This copies the .gitattributes file from the Zero-K repository, and adds
.css to the list of always-text files.
This ensures we have no CRLF checked into the index.

This process can be automated by the following:

git add --renormalize .
This process can be automated by the following:

while read f; do
  if diff /dev/null "$f" | tail -1 | grep '^\\ No newline' > /dev/null; then
    echo >> "$f";
  fi;
done < <(git ls-files '*.lua' '*.tdf' '*.h' '*.glsl' '*.fs' '*.json' '*.txt' '*.css')
This applies only to trailing whitespace after real content. Lines consisting
entirely of whitespace have been left untouched.

This process can be automated by the following:

while read f; do sed -i 's/\([^\t ]\)[\t ]*$/\1/' "$f"; done < <(git ls-files '*.lua' '*.tdf' '*.h' '*.glsl' '*.fs' '*.json' '*.txt' '*.css')
Clean up text file encodings, and some formatting
\n is standard, \r\n is convertible, \r on its own is just plain weird.
CRLF strikes at automated tooling again!

Fixing CRLF in the index doesn't necessarily fix them in the working
tree.

I deleted all files in the repository, then checked out fresh copies to
make sure my local working tree had no CRLF. I then invoked the same
whitespace-after-content stripping command again:

rm -r *
git reset --hard HEAD
while read f; do sed -i 's/\([^\t ]\)[\t ]*$/\1/' "$f"; done < <(git ls-files '*.lua' '*.tdf' '*.h' '*.glsl' '*.fs' '*.json' '*.txt' '*.css')
Clean up text file encodings, and some formatting p2
Replaced the briefing texts of planets 69 and 1 to 9.
text separated into text and extendedText. Previous text used as basis for extendeText.
…fing of planet 1

Continuing to replace the briefing text/adding extendedText. About the left half of the galaxy map is done with this one.
…s 1, 30.

Finished all briefings with the last Empire planets
New briefing text and extendedText for the campaign
Fix vanguard module description.
sprunk and others added 21 commits October 31, 2019 17:00
Offline users have a nil isAdmin, non-admins have a false isAdmin.

This caused comparisons to often enter the admin branch prematurely,
breaking alphabetical etc ordering.
This is generally more relevant while in the lobby, and helps make
clearer the:
> [liblobby] Warning: Duplicate user(...) added to channel (...)
problems, where it appears that an online and an offline user
share the same name. This issue is not fixed here.
 * Replaced most Minotaurs with Ogres.
 * Reduced Welder spam.
 * Fixed descriptions.
fix register not sending userid
Reverted compatibility-breaking battlelist changes.

# Conflicts:
#	.gitattributes
#	LuaMenu/configs/gameConfig/byar/aiBlacklist.lua
#	LuaMenu/configs/gameConfig/byar/defaultSettings/springsettings.cfg
#	LuaMenu/configs/gameConfig/byar/mapWhitelist.lua
#	LuaMenu/configs/gameConfig/byar/settingsMenu.lua
#	LuaMenu/configs/gameConfig/byar/skinning/skinConfig.lua
#	LuaMenu/configs/gameConfig/evorts/ModOptions.lua
#	LuaMenu/configs/gameConfig/evorts/aiBlacklist.lua
#	LuaMenu/configs/gameConfig/evorts/defaultSettings/springsettings.cfg
#	LuaMenu/configs/gameConfig/evorts/mainConfig.lua
#	LuaMenu/configs/gameConfig/evorts/mapWhitelist.lua
#	LuaMenu/configs/gameConfig/evorts/settingsMenu.lua
#	LuaMenu/configs/gameConfig/evorts/singleplayerMenu.lua
#	LuaMenu/configs/gameConfig/evorts/skinning/skinConfig.lua
#	LuaMenu/configs/gameConfig/evortsdev/mainConfig.lua
#	LuaMenu/configs/gameConfig/evortsdev/skirmishDefault.lua
#	LuaMenu/configs/gameConfig/tc/aiblacklist.lua
#	LuaMenu/configs/gameConfig/tc/benchmarkFile.lua
#	LuaMenu/configs/gameConfig/tc/defaultsettings/chobby_config.json
#	LuaMenu/configs/gameConfig/tc/defaultsettings/springsettings.cfg
#	LuaMenu/configs/gameConfig/tc/gameUnitInformation.lua
#	LuaMenu/configs/gameConfig/tc/helpSubmenuConfig.lua
#	LuaMenu/configs/gameConfig/tc/linkFunctions.lua
#	LuaMenu/configs/gameConfig/tc/mainconfig.lua
#	LuaMenu/configs/gameConfig/tc/mapwhitelist.lua
#	LuaMenu/configs/gameConfig/tc/modoptions.lua
#	LuaMenu/configs/gameConfig/tc/rankfunction.lua
#	LuaMenu/configs/gameConfig/tc/settingsmenu.lua
#	LuaMenu/configs/gameConfig/tc/singleplayerquickskirmish.lua
#	LuaMenu/configs/gameConfig/tc/skinning/skinconfig.lua
#	LuaMenu/configs/gameConfig/tc/startscripts/cpv_1.lua
#	LuaMenu/configs/gameConfig/tc/startscripts/koth_1.lua
#	LuaMenu/configs/gameConfig/zk/ModOptions.lua
#	LuaMenu/configs/gameConfig/zk/defaultSettings/benchmarks/config.lua
#	LuaMenu/configs/gameConfig/zk/defaultSettings/configversions.json
#	LuaMenu/configs/gameConfig/zk/mainConfig.lua
#	LuaMenu/configs/gameConfig/zk/settingsMenu.lua
#	LuaMenu/configs/gameConfig/zkdev/skirmishDefault.lua
#	LuaMenu/configs/liblobby_configuration.lua
#	LuaMenu/widgets/api_user_handler.lua
#	LuaMenu/widgets/dbg_img_preload.lua
#	LuaMenu/widgets/gui_battle_room_window.lua
#	LuaMenu/widgets/gui_campaign_handler.lua
#	LuaMenu/widgets/gui_login_window.lua
#	LuaMenu/widgets/gui_planetwars_list_window.lua
#	LuaMenu/widgets/gui_replay_handler.lua
#	LuaMenu/widgets/gui_steam_coop_handler.lua
#	LuaMenu/widgets/gui_user_status_panel.lua
#	campaign/dev/commConfig.lua
#	campaign/sample/commConfig.lua
#	campaign/sample/planetDocumentation.lua
#	campaign/sample/planets/planet1.lua
#	campaign/sample/planets/planet10.lua
#	campaign/sample/planets/planet11.lua
#	campaign/sample/planets/planet12.lua
#	campaign/sample/planets/planet13.lua
#	campaign/sample/planets/planet14.lua
#	campaign/sample/planets/planet15.lua
#	campaign/sample/planets/planet16.lua
#	campaign/sample/planets/planet17.lua
#	campaign/sample/planets/planet18.lua
#	campaign/sample/planets/planet19.lua
#	campaign/sample/planets/planet2.lua
#	campaign/sample/planets/planet20.lua
#	campaign/sample/planets/planet21.lua
#	campaign/sample/planets/planet22.lua
#	campaign/sample/planets/planet23.lua
#	campaign/sample/planets/planet24.lua
#	campaign/sample/planets/planet25.lua
#	campaign/sample/planets/planet3.lua
#	campaign/sample/planets/planet4.lua
#	campaign/sample/planets/planet5.lua
#	campaign/sample/planets/planet6.lua
#	campaign/sample/planets/planet7.lua
#	campaign/sample/planets/planet70.lua
#	campaign/sample/planets/planet71.lua
#	campaign/sample/planets/planet8.lua
#	campaign/sample/planets/planet9.lua
#	libs/chiliui/luamenu/chili/chili/controls/font.lua
#	libs/liblobby/lobby/interface_skirmish.lua
#	modinfo.lua
@GoogleFrog
Copy link
Contributor Author

Reverted font.

Current Spring-Chobby:
image

Current ZK-Chobby:
image

@gajop gajop changed the base branch from master to zk-merge February 9, 2020 02:14
@gajop
Copy link
Member

gajop commented Feb 9, 2020

I'm going to first merge this on a branch and then apply some changes before merging it to master

@gajop gajop merged commit a0da86e into Spring-Chobby:zk-merge Feb 9, 2020
@gajop gajop mentioned this pull request Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants