WIP: [R] Verify CRAN release 19.0.1.1 #46036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Rationale for this change [CRAN](wch/r-source@fb5500b) Fixes #45850 ### What changes are included in this PR? Attempt to delete static libraries we build or download during the R package build. ### Are these changes tested? CI should pass once again ### Are there any user-facing changes? No * GitHub Issue: #45850
### Rationale for this change Suggestion from @gaborcsardi to be more discreet about #45870. ### What changes are included in this PR? `@` ### Are these changes tested? CI should pass ### Are there any user-facing changes? 🤐
This gets rid of `OBJECT`, `DATAPTR` has been replaced with `INTEGER()`, `REAL()`, etc. though strings are more complicated. I will fully admit that this C++ is stretching my comfort zone, so might include obviously wrong things! CI is currently failing, but I'm not totally sure yet if that means the code changes here are wrong or if maybe these allow us to have slightly different assumptions about materialization (see #45951 (comment)) I've also requested reviews broadly for folks I know have been around this code before, I appreciate any effort that y'all can spare 🙏 * GitHub Issue: #45949 Lead-authored-by: Jonathan Keane <jkeane@gmail.com> Co-authored-by: Dewey Dunnington <dewey@dunnington.ca> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
…ndencies (#45997) ### Rationale for this change Enable building with CMake 4.0 and bundled dependencies that still set `cmake_minimum_required(VERSION 3.5)` or less. ### What changes are included in this PR? Set https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html ### Are these changes tested? CI ### Are there any user-facing changes? No * GitHub Issue: #45987 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
added
Component: R
Component: C++
awaiting review
Member
Author
|
@github-actions crossbow submit --group r |
Member
Author
|
GHA CI is auto-failing due to,
This looks like a false positive and maybe an issue with GitHub's detection script. I created a thread on Zulip. |
|
Revision: 709d70f Submitted crossbow builds: ursacomputing/crossbow @ actions-2a97c2525b
|
### Rationale for this change Older versions of the `actions/cache` GitHub action are being deprecated as explained in actions/cache#1510. Because of this, some CI jobs have started to fail: https://github.com/apache/arrow/actions/runs/13265539807/job/37034895918 ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * GitHub Issue: #45499 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Member
Author
|
I misunderstood in #46036 (comment) and I guess v4.0.0 was also deprecated, so I instead cherry-picked #45500. |
jonkeane
reviewed
Apr 7, 2025
Comment on lines
+22
to
+25
| ## Minor improvements and fixes | ||
|
|
||
| - Updated internal code to comply with new CRAN requirements on non-API calls ([#45949](https://github.com/apache/arrow/issues/45949)) | ||
| - Enable building the bundled third-party libraries under CMake 4.0 ([#45987](https://github.com/apache/arrow/issues/45987)) |
github-actions
bot
added
awaiting changes
jonkeane
reviewed
Apr 7, 2025
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to prepare for the CRAN submission for 19.0.1.1.
See packaging checklist: #45950