Skip to content

KAFKA-7864; validate partitions are 0-based#6246

Merged
junrao merged 5 commits intoapache:trunkfrom
ctchenn:KAFKA-7864
Feb 22, 2019
Merged

KAFKA-7864; validate partitions are 0-based#6246
junrao merged 5 commits intoapache:trunkfrom
ctchenn:KAFKA-7864

Conversation

@ctchenn
Copy link
Copy Markdown
Contributor

@ctchenn ctchenn commented Feb 8, 2019

in AdminZkClient.validateTopicCreate(), check the partition ids are consecutive and 0-based

Comment thread core/src/main/scala/kafka/zk/AdminZkClient.scala Outdated
@harshach harshach self-assigned this Feb 8, 2019
@harshach
Copy link
Copy Markdown

harshach commented Feb 8, 2019

+1

Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctchenn : Thanks for the patch. Just one comment below.

Comment thread core/src/main/scala/kafka/zk/AdminZkClient.scala Outdated
Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctchenn : Thanks for the updated patch. Just one minor comment below.

Comment thread core/src/main/scala/kafka/zk/AdminZkClient.scala Outdated
Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctchenn : Thanks for the latest PR. LGTM

@junrao junrao merged commit 217f45e into apache:trunk Feb 22, 2019
@ctchenn ctchenn deleted the KAFKA-7864 branch February 22, 2019 21:26
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* AK/trunk: (36 commits)
  KAFKA-7962: Avoid NPE for StickyAssignor (apache#6308)
  Address flakiness of CustomQuotaCallbackTest#testCustomQuotaCallback (apache#6330)
  KAFKA-7918: Inline generic parameters Pt. II: RocksDB Bytes Store and Memory LRU Caches (apache#6327)
  MINOR: fix parameter naming (apache#6316)
  KAFKA-7956 In ShutdownableThread, immediately complete the shutdown if the thread has not been started (apache#6218)
  MINOR: Refactor replica log dir fetching for improved logging (apache#6313)
  [TRIVIAL] Remove unused StreamsGraphNode#repartitionRequired (apache#6227)
  MINOR: Increase produce timeout to 120 seconds (apache#6326)
  KAFKA-7918: Inline generic parameters Pt. I: in-memory key-value store (apache#6293)
  MINOR: Fix line break issue in upgrade notes (apache#6320)
  KAFKA-7972: Use automatic RPC generation in SaslHandshake
  MINOR: Enable capture of full stack trace in StreamTask#process (apache#6310)
  KAFKA-7938: Fix test flakiness in DeleteConsumerGroupsTest (apache#6312)
  KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup (apache#6311)
  MINOR: Update docs to say 2.2 (apache#6315)
  KAFKA-7672 : force write checkpoint during StreamTask #suspend (apache#6115)
  KAFKA-7961; Ignore assignment for un-subscribed partitions (apache#6304)
  KAFKA-7672: Restoring tasks need to be closed upon task suspension (apache#6113)
  KAFKA-7864; validate partitions are 0-based (apache#6246)
  KAFKA-7492 : Updated javadocs for aggregate and reduce methods returning null behavior. (apache#6285)
  ...
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Reviewers: Sriharsha Chintalapani <sriharsha@apache.org>, Jun Rao <junrao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants