Skip to content

MINOR: Enable capture of full stack trace in StreamTask#process#6310

Merged
mjsax merged 1 commit intoapache:trunkfrom
bbejeck:MINOR_print_stack_full_stack_trace_string
Feb 23, 2019
Merged

MINOR: Enable capture of full stack trace in StreamTask#process#6310
mjsax merged 1 commit intoapache:trunkfrom
bbejeck:MINOR_print_stack_full_stack_trace_string

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Feb 22, 2019

Right now in StreamTask#process when we catch a KafkaException, only the message is printed in the log statement which makes debugging errors difficult. This PR will capture the full stack trace of the exception and add it to the log statement.

I ran the existing streams test suite.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Feb 22, 2019

\cc @ableegoldman and @vvcephei for reviews as well

bbejeck
bbejeck commented Feb 22, 2019
View reviewed changes
Comment thread streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java Outdated
Copy link
Copy Markdown
Member Author

@bbejeck bbejeck Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could inline this, but my personal preference is to have a separate method call for readability.

guozhangwang
guozhangwang approved these changes Feb 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. call for second review @mjsax

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 23, 2019

@bbejeck Can you rebase this to resolve the merge conflict?

@bbejeck bbejeck force-pushed the MINOR_print_stack_full_stack_trace_string branch from 9678e37 to 48ef2b7 Compare February 23, 2019 16:30
@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Feb 23, 2019

rebased from trunk

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 23, 2019

Unrelated test failures: https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/19752/

java.util.NoSuchElementException: None.get
	at scala.None$.get(Option.scala:347)
	at scala.None$.get(Option.scala:345)
	at kafka.admin.PreferredReplicaLeaderElectionCommandTest.getLeader(PreferredReplicaLeaderElectionCommandTest.scala:91)
	at kafka.admin.PreferredReplicaLeaderElectionCommandTest.testNoopElection(PreferredReplicaLeaderElectionCommandTest.scala:230)

and

java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.CoordinatorNotAvailableException: The coordinator is not available.
	at org.apache.kafka.common.internals.KafkaFutureImpl.wrapAndThrow(KafkaFutureImpl.java:45)
	at org.apache.kafka.common.internals.KafkaFutureImpl.access$000(KafkaFutureImpl.java:32)
	at org.apache.kafka.common.internals.KafkaFutureImpl$SingleWaiter.await(KafkaFutureImpl.java:89)
	at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:260)
	at kafka.admin.ConsumerGroupCommand$ConsumerGroupService.resetOffsets(ConsumerGroupCommand.scala:306)
	at kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup(ResetConsumerGroupOffsetTest.scala:89)

@mjsax mjsax merged commit 12e8b8c into apache:trunk Feb 23, 2019
mjsax pushed a commit that referenced this pull request Feb 23, 2019
@bbejeck @mjsax
MINOR: Enable capture of full stack trace in StreamTask#process (#6310)
a08a0ae 
Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 23, 2019

Merged to trunk and cherry-picked to 2.2

jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
@stanislavkozlovski
Merge remote-tracking branch 'AK/trunk' into cos-trunk
d516eac 
* AK/trunk: (36 commits)
  KAFKA-7962: Avoid NPE for StickyAssignor (apache#6308)
  Address flakiness of CustomQuotaCallbackTest#testCustomQuotaCallback (apache#6330)
  KAFKA-7918: Inline generic parameters Pt. II: RocksDB Bytes Store and Memory LRU Caches (apache#6327)
  MINOR: fix parameter naming (apache#6316)
  KAFKA-7956 In ShutdownableThread, immediately complete the shutdown if the thread has not been started (apache#6218)
  MINOR: Refactor replica log dir fetching for improved logging (apache#6313)
  [TRIVIAL] Remove unused StreamsGraphNode#repartitionRequired (apache#6227)
  MINOR: Increase produce timeout to 120 seconds (apache#6326)
  KAFKA-7918: Inline generic parameters Pt. I: in-memory key-value store (apache#6293)
  MINOR: Fix line break issue in upgrade notes (apache#6320)
  KAFKA-7972: Use automatic RPC generation in SaslHandshake
  MINOR: Enable capture of full stack trace in StreamTask#process (apache#6310)
  KAFKA-7938: Fix test flakiness in DeleteConsumerGroupsTest (apache#6312)
  KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup (apache#6311)
  MINOR: Update docs to say 2.2 (apache#6315)
  KAFKA-7672 : force write checkpoint during StreamTask #suspend (apache#6115)
  KAFKA-7961; Ignore assignment for un-subscribed partitions (apache#6304)
  KAFKA-7672: Restoring tasks need to be closed upon task suspension (apache#6113)
  KAFKA-7864; validate partitions are 0-based (apache#6246)
  KAFKA-7492 : Updated javadocs for aggregate and reduce methods returning null behavior. (apache#6285)
  ...
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@bbejeck @pengxiaolong
MINOR: Enable capture of full stack trace in StreamTask#process (apac…
4435ba8 
…he#6310)

Reviewers: Guozhang Wang <guozhang@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@bbejeck bbejeck deleted the MINOR_print_stack_full_stack_trace_string branch July 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guozhangwang guozhangwang guozhangwang approved these changes

@mjsax mjsax Awaiting requested review from mjsax

Assignees

No one assigned

Labels

streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbejeck @mjsax @guozhangwang