KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffs…#6311
KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffs…#6311vahidhashemian merged 1 commit intoapache:trunkfrom
Conversation
…etsNotExistingGroup
vahidhashemian
left a comment
vahidhashemian
left a comment
There was a problem hiding this comment.
LGTM. I'll wait for the build to pass before merging. Thanks!
|
Thanks! Don't forget to cherrypick to 2.2 while you are at it :) |
|
Sure. I haven't yet done cherry-picking when merging. That would be my learning exercise :) |
|
The failed unit test seems to be unrelated. |
|
Cherry-picked to 2.2 branch. |
|
Isn't this a bug in the command that it doesn't retry? Seems like this change is hiding a real bug. Also, we should aim to include information in the commit messages themselves, seems like they're empty aside from the title. |
|
Agreed. The retry logic existed in the old Also good point on commit title and message. If they should be there for each commit (which makes sense), I am wondering if there is a good way to enforce them as part of the test or when merging? |
|
Can we add a comment to that open PR stating that we should revert this change there? For the commit message, it's the responsibility of the committer to ensure the commit message is good. The same way you have to review the code. Personally, I often edit it myself before merging instead of going back to the PR author if the change is simple. For complex changes, I ask the author to update the PR description and I then copy and paste. |
|
Created KAFKA-7993 to better track it. |
* AK/trunk: (36 commits) KAFKA-7962: Avoid NPE for StickyAssignor (apache#6308) Address flakiness of CustomQuotaCallbackTest#testCustomQuotaCallback (apache#6330) KAFKA-7918: Inline generic parameters Pt. II: RocksDB Bytes Store and Memory LRU Caches (apache#6327) MINOR: fix parameter naming (apache#6316) KAFKA-7956 In ShutdownableThread, immediately complete the shutdown if the thread has not been started (apache#6218) MINOR: Refactor replica log dir fetching for improved logging (apache#6313) [TRIVIAL] Remove unused StreamsGraphNode#repartitionRequired (apache#6227) MINOR: Increase produce timeout to 120 seconds (apache#6326) KAFKA-7918: Inline generic parameters Pt. I: in-memory key-value store (apache#6293) MINOR: Fix line break issue in upgrade notes (apache#6320) KAFKA-7972: Use automatic RPC generation in SaslHandshake MINOR: Enable capture of full stack trace in StreamTask#process (apache#6310) KAFKA-7938: Fix test flakiness in DeleteConsumerGroupsTest (apache#6312) KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup (apache#6311) MINOR: Update docs to say 2.2 (apache#6315) KAFKA-7672 : force write checkpoint during StreamTask #suspend (apache#6115) KAFKA-7961; Ignore assignment for un-subscribed partitions (apache#6304) KAFKA-7672: Restoring tasks need to be closed upon task suspension (apache#6113) KAFKA-7864; validate partitions are 0-based (apache#6246) KAFKA-7492 : Updated javadocs for aggregate and reduce methods returning null behavior. (apache#6285) ...
…etsNotExistingGroup (apache#6311)
3 participants
Address the comments on PR-6307. Sorry for new PR, but one of the comments was to move the PR to another branch.
Since the test fails sometimes on lack of coordinator, I'm giving it a bit more attempts to find it.
I admit that I haven't been able to actually reproduce this failure, so I'm only hoping this fixes it. But it doesn't fail more often than it used to (on my machine)
Fixing on 2.2 because the intent is to fix enough flakes to allow for a clean release.