Skip to content

MINOR: Increase produce timeout to 120 seconds#6326

Merged
rhauch merged 2 commits intoapache:trunkfrom
wicknicks:increase-produce-timeout
Feb 26, 2019
Merged

MINOR: Increase produce timeout to 120 seconds#6326
rhauch merged 2 commits intoapache:trunkfrom
wicknicks:increase-produce-timeout

Conversation

@wicknicks
Copy link
Copy Markdown
Contributor

@wicknicks wicknicks commented Feb 25, 2019

This gives more room to pass this test on systems with low
resources running many parallel tests.

Signed-off-by: Arjun Satish arjun@confluent.io

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

This gives more room to pass this test on systems with low
resources running many parallel tests.

Signed-off-by: Arjun Satish <arjun@confluent.io>
@wicknicks wicknicks force-pushed the increase-produce-timeout branch from 4f52adb to 7c46528 Compare February 25, 2019 22:56
Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wicknicks! Two minor suggestions below.

Co-Authored-By: wicknicks <wicknicks@users.noreply.github.com>
@rhauch
Copy link
Copy Markdown
Contributor

rhauch commented Feb 26, 2019

The one JDK 8 test failure is unrelated.

Copy link
Copy Markdown
Contributor

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @wicknicks.

@rhauch rhauch merged commit 2627a1b into apache:trunk Feb 26, 2019
rhauch pushed a commit that referenced this pull request Feb 26, 2019
MINOR: Increase produce timeout for EmbeddedKafkaCluster to 120 seconds

Previous value was 500ms. This change gives more room to pass tests on systems with low resources running many parallel tests.

Reviewers: Randall Hauch <randall@confluent.io>
rhauch pushed a commit that referenced this pull request Feb 26, 2019
MINOR: Increase produce timeout for EmbeddedKafkaCluster to 120 seconds

Previous value was 500ms. This change gives more room to pass tests on systems with low resources running many parallel tests.

Reviewers: Randall Hauch <randall@confluent.io>
rhauch pushed a commit that referenced this pull request Feb 26, 2019
MINOR: Increase produce timeout for EmbeddedKafkaCluster to 120 seconds

Previous value was 500ms. This change gives more room to pass tests on systems with low resources running many parallel tests.

Reviewers: Randall Hauch <randall@confluent.io>
@rhauch
Copy link
Copy Markdown
Contributor

rhauch commented Feb 26, 2019

Merged back to the 2.0 branch.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Feb 26, 2019

@wicknicks @rhauch I think this PR was for KAFKA-7999? If yes, please link the PR and update the ticket. Thanks.

@wicknicks wicknicks deleted the increase-produce-timeout branch February 26, 2019 17:40
@wicknicks
Copy link
Copy Markdown
Contributor Author

@mjsax ticket was resolved.

jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* AK/trunk: (36 commits)
  KAFKA-7962: Avoid NPE for StickyAssignor (apache#6308)
  Address flakiness of CustomQuotaCallbackTest#testCustomQuotaCallback (apache#6330)
  KAFKA-7918: Inline generic parameters Pt. II: RocksDB Bytes Store and Memory LRU Caches (apache#6327)
  MINOR: fix parameter naming (apache#6316)
  KAFKA-7956 In ShutdownableThread, immediately complete the shutdown if the thread has not been started (apache#6218)
  MINOR: Refactor replica log dir fetching for improved logging (apache#6313)
  [TRIVIAL] Remove unused StreamsGraphNode#repartitionRequired (apache#6227)
  MINOR: Increase produce timeout to 120 seconds (apache#6326)
  KAFKA-7918: Inline generic parameters Pt. I: in-memory key-value store (apache#6293)
  MINOR: Fix line break issue in upgrade notes (apache#6320)
  KAFKA-7972: Use automatic RPC generation in SaslHandshake
  MINOR: Enable capture of full stack trace in StreamTask#process (apache#6310)
  KAFKA-7938: Fix test flakiness in DeleteConsumerGroupsTest (apache#6312)
  KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup (apache#6311)
  MINOR: Update docs to say 2.2 (apache#6315)
  KAFKA-7672 : force write checkpoint during StreamTask #suspend (apache#6115)
  KAFKA-7961; Ignore assignment for un-subscribed partitions (apache#6304)
  KAFKA-7672: Restoring tasks need to be closed upon task suspension (apache#6113)
  KAFKA-7864; validate partitions are 0-based (apache#6246)
  KAFKA-7492 : Updated javadocs for aggregate and reduce methods returning null behavior. (apache#6285)
  ...
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
MINOR: Increase produce timeout for EmbeddedKafkaCluster to 120 seconds

Previous value was 500ms. This change gives more room to pass tests on systems with low resources running many parallel tests.

Reviewers: Randall Hauch <randall@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants