KAFKA-7962: Avoid NPE for StickyAssignor#6308
Merged
vahidhashemian merged 4 commits intoapache:trunkfrom Feb 28, 2019
Merged
Conversation
Contributor
Author
|
@vahidhashemian Please review this patch. Thanks. |
Contributor
vahidhashemian
left a comment
vahidhashemian
left a comment
There was a problem hiding this comment.
Thanks for the PR @huxihx. Left a small comment.
Contributor
There was a problem hiding this comment.
Wouldn't it be simpler and more readable to encompass the for loop in an if block that verifies the topic exists in partitionsPerTopic?
Contributor
vahidhashemian
left a comment
vahidhashemian
left a comment
There was a problem hiding this comment.
Thanks for addressing my comment, and sorry for the delay. It would be great if we can have another unit test as commented inline.
Contributor
There was a problem hiding this comment.
Could you please also add a unit test that covers this scenario? If I'm not mistaken col will be empty when either the list of partitions or the list of consumers passes to the assigner is empty.
Contributor
There was a problem hiding this comment.
nit: You can use the topic(...) helper function instead of Arrays.asList(...). See examples in other unit tests.
…ments if topic is deleted https://issues.apache.org/jira/browse/KAFKA-7962 Consumer using StickyAssignor throws NullPointerException if a subscribed topic was removed.
Contributor
Author
|
retest this please |
vahidhashemian
approved these changes
Feb 28, 2019
Contributor
vahidhashemian
left a comment
vahidhashemian
left a comment
There was a problem hiding this comment.
Thank you very much for addressing my comments. I believe the failed unit test is unrelated to this PR. LGTM.
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* AK/trunk: (36 commits) KAFKA-7962: Avoid NPE for StickyAssignor (apache#6308) Address flakiness of CustomQuotaCallbackTest#testCustomQuotaCallback (apache#6330) KAFKA-7918: Inline generic parameters Pt. II: RocksDB Bytes Store and Memory LRU Caches (apache#6327) MINOR: fix parameter naming (apache#6316) KAFKA-7956 In ShutdownableThread, immediately complete the shutdown if the thread has not been started (apache#6218) MINOR: Refactor replica log dir fetching for improved logging (apache#6313) [TRIVIAL] Remove unused StreamsGraphNode#repartitionRequired (apache#6227) MINOR: Increase produce timeout to 120 seconds (apache#6326) KAFKA-7918: Inline generic parameters Pt. I: in-memory key-value store (apache#6293) MINOR: Fix line break issue in upgrade notes (apache#6320) KAFKA-7972: Use automatic RPC generation in SaslHandshake MINOR: Enable capture of full stack trace in StreamTask#process (apache#6310) KAFKA-7938: Fix test flakiness in DeleteConsumerGroupsTest (apache#6312) KAFKA-7937: Fix Flaky Test ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup (apache#6311) MINOR: Update docs to say 2.2 (apache#6315) KAFKA-7672 : force write checkpoint during StreamTask #suspend (apache#6115) KAFKA-7961; Ignore assignment for un-subscribed partitions (apache#6304) KAFKA-7672: Restoring tasks need to be closed upon task suspension (apache#6113) KAFKA-7864; validate partitions are 0-based (apache#6246) KAFKA-7492 : Updated javadocs for aggregate and reduce methods returning null behavior. (apache#6285) ...
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
* KAFKA-7962: StickyAssignor: throws NullPointerException during assignments if topic is deleted https://issues.apache.org/jira/browse/KAFKA-7962 Consumer using StickyAssignor throws NullPointerException if a subscribed topic was removed. * addressed vahidhashemian's comments * lower NPath Complexity * added a unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-7962
Consumer using StickyAssignor throws NullPointerException if a subscribed topic was removed.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)