Skip to content

chore: Removes ColorSchemeControl.less#14199

Merged
rusackas merged 1 commit into
apache:masterfrom
michael-s-molina:remove-less-color-scheme-control
May 21, 2021
Merged

chore: Removes ColorSchemeControl.less#14199
rusackas merged 1 commit into
apache:masterfrom
michael-s-molina:remove-less-color-scheme-control

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina commented Apr 16, 2021

SUMMARY

Removes ColorSchemeControl.less

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-04-16.at.1.31.44.PM.mov
Screen.Recording.2021-04-16.at.1.38.47.PM.mov

@rusackas @junlincc

TEST PLAN

1 - Go to Explore
2 - Go to Customize
3 - Check Color Scheme control

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2021

Codecov Report

Merging #14199 (783229f) into master (a3e3023) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 783229f differs from pull request most recent head 4bdf1b0. Consider uploading reports for the commit 4bdf1b0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14199   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files         945      945           
  Lines       47950    47973   +23     
  Branches     6069     6076    +7     
=======================================
+ Hits        37943    37963   +20     
- Misses       9872     9875    +3     
  Partials      135      135
Flag Coverage Δ
javascript 70.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/test_connection.py 98.11% <ø> (ø)
superset/db_engine_specs/mssql.py 95.45% <ø> (ø)
superset/errors.py 100.00% <ø> (ø)
...explore/components/controls/ColorSchemeControl.jsx 92.30% <100.00%> (-4.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e3023...4bdf1b0. Read the comment docs.

geido
geido reviewed Apr 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a concern for the css approach that requires discussion

Comment thread superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label May 5, 2021
@rusackas
Copy link
Copy Markdown
Member

rusackas commented May 6, 2021

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2021

@rusackas Ephemeral environment spinning up at http://52.24.206.241:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few random pixel values are in there that could be converted to gridUnit I'm sure, but I'll pick my battles and save that for another day ;)

@rusackas rusackas merged commit 04d94d2 into apache:master May 21, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2021

Ephemeral environment shutdown and build artifacts deleted.

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request May 25, 2021
Merge branch 'master' into feat/fileter_set
ad54807 
* master: (163 commits)
  fix(native-filters): Manage default value of filters by superset (apache#14785)
  fix: Additional ResultSet tests (apache#14741)
  chore: added BasicParametersMixin to Redshift (apache#14752)
  fix: make dataset list sort case insensitive (apache#14528)
  fix: use encodeURIComponent when getting table metadata (apache#14790)
  fix: ensure engine is outside parameters (apache#14787)
  database modal should close on connect with tab layout (apache#14771)
  feat(native-filters): add search all filter options (apache#14710)
  fix: extra query in Dashboard when native filter enabled (apache#14770)
  chore: Improves the native filters UI/UX - iteration 2 (apache#14753)
  fix(native filters): Fix explore state (apache#14779)
  fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737)
  feat: Create BigQuery Parameters for DatabaseModal (apache#14721)
  feat: enable user impersonation in GSheets (apache#14767)
  fix: add DB should not say it's Postgres (apache#14766)
  Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762)
  feat: save database with new dynamic form (apache#14583)
  fix: save non-parameter DBs (apache#14759)
  chore: Removes ColorSchemeControl.less (apache#14199)
  fix(explore): Icons width (apache#14717)
  ...
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@michael-s-molina
chore: Removes ColorSchemeControl.less (apache#14199)
27310af
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@michael-s-molina
chore: Removes ColorSchemeControl.less (apache#14199)
ed2b1bf
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
chore: Removes ColorSchemeControl.less (apache#14199)
9b11d4d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@michael-s-molina
chore: Removes ColorSchemeControl.less (apache#14199)
46cbc99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyndsiWilliams lyndsiWilliams lyndsiWilliams left review comments

@geido geido geido left review comments

@rusackas rusackas rusackas approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 size/M 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@michael-s-molina @rusackas @lyndsiWilliams @geido @mistercrunch @junlincc