fix: ensure engine is outside parameters

[betodealmeida]

SUMMARY

In the new database modal flow we have 2 different flows:

• In the old APIs (test_connection, add/edit DB) we expect engine inside parameters.
• In the new API (validate_parameters) it should be outside.

It's better to have a consistent way, and it's also better to have engine outside of parameters, so I fixed the old APIs to support both initially, to prevent breaking the frontend. Later we can remove support for passing engine inside parameters and only accept it outside.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Tested manually.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

I moved this closer to where is needed, to prevent us from running this if not necessary.

[codecov]

Codecov Report

Merging #14787 (8574282) into master (e9657af) will decrease coverage by 0.24%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master   #14787      +/-   ##
==========================================
- Coverage   77.54%   77.30%   -0.25%     
==========================================
  Files         962      962              
  Lines       49147    49148       +1     
  Branches     6182     6182              
==========================================
- Hits        38111    37993     -118     
- Misses      10832    10951     +119     
  Partials      204      204              

Flag	Coverage Δ
hive	?
mysql	81.62% <77.77%> (-0.01%)	⬇️
postgres	81.65% <77.77%> (-0.01%)	⬇️
presto	?
python	81.73% <77.77%> (-0.46%)	⬇️
sqlite	81.27% <77.77%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/databases/schemas.py	98.71% <77.77%> (-0.86%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	70.32% <0.00%> (-17.08%)	⬇️
superset/db_engine_specs/presto.py	83.36% <0.00%> (-6.95%)	⬇️
superset/views/database/mixins.py	81.03% <0.00%> (-1.73%)	⬇️
superset/connectors/sqla/models.py	88.08% <0.00%> (-1.67%)	⬇️
superset/db_engine_specs/base.py	87.90% <0.00%> (-0.41%)	⬇️
superset/models/core.py	89.70% <0.00%> (-0.27%)	⬇️
superset/utils/core.py	88.91% <0.00%> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9657af...8574282. Read the comment docs.