Skip to content

chore: Improves the native filters UI/UX - iteration 2#14753

Merged
villebro merged 1 commit into
apache:masterfrom
michael-s-molina:revamp-native-filters-2
May 24, 2021
Merged

chore: Improves the native filters UI/UX - iteration 2#14753
villebro merged 1 commit into
apache:masterfrom
michael-s-molina:revamp-native-filters-2

Conversation

@michael-s-molina
Copy link
Copy Markdown
Member

@michael-s-molina michael-s-molina commented May 21, 2021

SUMMARY

Improves the native filters UI/UX - iteration 2.

  • Adds the Basic and Advanced collapse panels
  • Moves the column field alongside the dataset field
  • Sets min-width to the modal to deal with resizing
  • Adjusts the borders, padding and margins to the new layout

This work is part of the Native dashboard filter project

The items below will be handled in the next iterations:

  • Split the controllers and organize them in the Basic and Advanced sections
  • Expand the Basic section by default
  • Add the ability to render a controller dynamically using checkboxes
  • Handle the correct tab selection when validating

The iterations below are optional but recommended:

  • Split the FiltersConfigForm into smaller components to make it easier to read
  • Unify the select components to use the AntD one. Currently, we have different selects with different themes and interactions.

@villebro @rusackas @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

118834020-4c534f00-b898-11eb-900f-aeb15c8dafba.mov
screen-recording-2021-05-21-at-115540-am_n8FbvGGi.mov

TESTING INSTRUCTIONS

1 - Enable native filters feature flag
2 - Enter in a dashboard
3 - Add a native filter
4 - Check the screen

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina force-pushed the revamp-native-filters-2 branch 2 times, most recently from cc55718 to e36449b Compare May 21, 2021 17:12
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2021

Codecov Report

Merging #14753 (8f58a43) into master (d71b8b3) will decrease coverage by 0.41%.
The diff coverage is 64.15%.

❗ Current head 8f58a43 differs from pull request most recent head e52c804. Consider uploading reports for the commit e52c804 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14753      +/-   ##
==========================================
- Coverage   77.62%   77.21%   -0.42%     
==========================================
  Files         962      960       -2     
  Lines       49017    48827     -190     
  Branches     6155     6122      -33     
==========================================
- Hits        38050    37702     -348     
- Misses      10763    10922     +159     
+ Partials      204      203       -1     
Flag Coverage Δ
hive ?
javascript 72.32% <64.15%> (-0.10%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 71.12% <62.74%> (+0.43%) ⬆️
...ts/nativeFilters/FiltersConfigModal/FilterTabs.tsx 84.21% <100.00%> (-2.16%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 94.87% <100.00%> (+0.06%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 27.77% <0.00%> (-61.12%) ⬇️
...tend/src/filters/components/Time/transformProps.ts 66.66% <0.00%> (-22.23%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 73.33% <0.00%> (-20.00%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/connectors/druid/views.py 69.79% <0.00%> (-10.08%) ⬇️
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 90.62% <0.00%> (-9.38%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71b8b3...e52c804. Read the comment docs.

@rusackas rusackas requested a review from villebro May 21, 2021 21:47
@rusackas
Copy link
Copy Markdown
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Copy Markdown
Contributor

@rusackas Ephemeral environment spinning up at http://54.188.53.80:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina force-pushed the revamp-native-filters-2 branch from e36449b to 157b1b5 Compare May 22, 2021 12:47
@github-actions
Copy link
Copy Markdown
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Tested locally and everything works as expected, looking forward to iteration 3!

@villebro villebro merged commit bee6f3b into apache:master May 24, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 24, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request May 25, 2021
* master: (163 commits)
  fix(native-filters): Manage default value of filters by superset (apache#14785)
  fix: Additional ResultSet tests (apache#14741)
  chore: added BasicParametersMixin to Redshift (apache#14752)
  fix: make dataset list sort case insensitive (apache#14528)
  fix: use encodeURIComponent when getting table metadata (apache#14790)
  fix: ensure engine is outside parameters (apache#14787)
  database modal should close on connect with tab layout (apache#14771)
  feat(native-filters): add search all filter options (apache#14710)
  fix: extra query in Dashboard when native filter enabled (apache#14770)
  chore: Improves the native filters UI/UX - iteration 2 (apache#14753)
  fix(native filters): Fix explore state (apache#14779)
  fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737)
  feat: Create BigQuery Parameters for DatabaseModal (apache#14721)
  feat: enable user impersonation in GSheets (apache#14767)
  fix: add DB should not say it's Postgres (apache#14766)
  Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762)
  feat: save database with new dynamic form (apache#14583)
  fix: save non-parameter DBs (apache#14759)
  chore: Removes ColorSchemeControl.less (apache#14199)
  fix(explore): Icons width (apache#14717)
  ...
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/L 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants