chore: Improves the native filters UI/UX - iteration 2#14753
Conversation
cc55718 to
e36449b
Compare
Codecov Report
@@ Coverage Diff @@
## master #14753 +/- ##
==========================================
- Coverage 77.62% 77.21% -0.42%
==========================================
Files 962 960 -2
Lines 49017 48827 -190
Branches 6155 6122 -33
==========================================
- Hits 38050 37702 -348
- Misses 10763 10922 +159
+ Partials 204 203 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true |
|
@rusackas Ephemeral environment spinning up at http://54.188.53.80:8080. Credentials are |
e36449b to
157b1b5
Compare
157b1b5 to
e52c804
Compare
|
Ephemeral environment shutdown and build artifacts deleted. |
villebro
left a comment
There was a problem hiding this comment.
LGTM - Tested locally and everything works as expected, looking forward to iteration 3!
* master: (163 commits) fix(native-filters): Manage default value of filters by superset (apache#14785) fix: Additional ResultSet tests (apache#14741) chore: added BasicParametersMixin to Redshift (apache#14752) fix: make dataset list sort case insensitive (apache#14528) fix: use encodeURIComponent when getting table metadata (apache#14790) fix: ensure engine is outside parameters (apache#14787) database modal should close on connect with tab layout (apache#14771) feat(native-filters): add search all filter options (apache#14710) fix: extra query in Dashboard when native filter enabled (apache#14770) chore: Improves the native filters UI/UX - iteration 2 (apache#14753) fix(native filters): Fix explore state (apache#14779) fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737) feat: Create BigQuery Parameters for DatabaseModal (apache#14721) feat: enable user impersonation in GSheets (apache#14767) fix: add DB should not say it's Postgres (apache#14766) Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762) feat: save database with new dynamic form (apache#14583) fix: save non-parameter DBs (apache#14759) chore: Removes ColorSchemeControl.less (apache#14199) fix(explore): Icons width (apache#14717) ...
SUMMARY
Improves the native filters UI/UX - iteration 2.
min-widthto the modal to deal with resizingThis work is part of the Native dashboard filter project
The items below will be handled in the next iterations:
The iterations below are optional but recommended:
FiltersConfigForminto smaller components to make it easier to read@villebro @rusackas @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
118834020-4c534f00-b898-11eb-900f-aeb15c8dafba.mov
screen-recording-2021-05-21-at-115540-am_n8FbvGGi.mov
TESTING INSTRUCTIONS
1 - Enable native filters feature flag
2 - Enter in a dashboard
3 - Add a native filter
4 - Check the screen
ADDITIONAL INFORMATION