fix(explore): DndColumnSelect not handling controls with "multi: false"#14737
Merged
Conversation
michael-s-molina
approved these changes
May 20, 2021
villebro
approved these changes
May 20, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM - one small improvement proposal
| canDrop={canDrop} | ||
| valuesRenderer={valuesRenderer} | ||
| accept={DndItemType.Column} | ||
| displayGhostButton={multi || optionSelector.values.length === 0} |
Member
There was a problem hiding this comment.
Bycatch: could we add singular/plural support while we're at it? ghostButtonText={tn('Drop column', 'Drop columns', multi ? 2 : 1)}
Member
Author
There was a problem hiding this comment.
Thanks! I also changed it in DndMetricSelect
Codecov Report
@@ Coverage Diff @@
## master #14737 +/- ##
==========================================
- Coverage 77.54% 77.50% -0.04%
==========================================
Files 959 960 +1
Lines 48696 48790 +94
Branches 5743 6126 +383
==========================================
+ Hits 37762 37817 +55
- Misses 10733 10770 +37
- Partials 201 203 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
force-pushed
the
fix/dnd-column-select
branch
from
1d64ec8 to
2ce2e71
Compare
Member
|
@michael-s-molina @villebro thanks for reviewing! did you test locally? for some reasons i still see the select fields when i pull the PR |
Member
Author
@junlincc Try on Country Map chart. I recorded those videos while implementing dnd controls for all charts (not available on master yet, PR coming in ~30 minutes 🙂) |
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
May 25, 2021
* master: (163 commits) fix(native-filters): Manage default value of filters by superset (apache#14785) fix: Additional ResultSet tests (apache#14741) chore: added BasicParametersMixin to Redshift (apache#14752) fix: make dataset list sort case insensitive (apache#14528) fix: use encodeURIComponent when getting table metadata (apache#14790) fix: ensure engine is outside parameters (apache#14787) database modal should close on connect with tab layout (apache#14771) feat(native-filters): add search all filter options (apache#14710) fix: extra query in Dashboard when native filter enabled (apache#14770) chore: Improves the native filters UI/UX - iteration 2 (apache#14753) fix(native filters): Fix explore state (apache#14779) fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737) feat: Create BigQuery Parameters for DatabaseModal (apache#14721) feat: enable user impersonation in GSheets (apache#14767) fix: add DB should not say it's Postgres (apache#14766) Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762) feat: save database with new dynamic form (apache#14583) fix: save non-parameter DBs (apache#14759) chore: Removes ColorSchemeControl.less (apache#14199) fix(explore): Icons width (apache#14717) ...
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…e" (apache#14737) * fix(explore): DndColumnSelect not handling controls with multi={false} * Implement translations for singular and plural cases * Fix test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…e" (apache#14737) * fix(explore): DndColumnSelect not handling controls with multi={false} * Implement translations for singular and plural cases * Fix test
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…e" (apache#14737) * fix(explore): DndColumnSelect not handling controls with multi={false} * Implement translations for singular and plural cases * Fix test
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…e" (apache#14737) * fix(explore): DndColumnSelect not handling controls with multi={false} * Implement translations for singular and plural cases * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
DndColumnSelectwas working correctly only for controls that accept multiple values. When used with controls that hadmulti: falseprop, it displayed a prompt to add more columns and behaved weirdly - sometimes it allowed adding more values, sometimes it replaced the first value with whatever user dropped last. This PR fixes those glitches and unifies the behaviour with withDndMetricSelect- after the first value is added, prompt disappears and adding new columns is disabled.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
118995851-c1518200-b987-11eb-99f0-b7adf922429c.mov
After:
118996113-f4941100-b987-11eb-8970-04bff622fe2c.mov
TEST PLAN
Open a chart that uses
DndColumnSelectfor single value controls (e.g. Country Map and "ISO 3166-2 CODES" control), verify that only 1 value can be added and there are no glitches when you try to add more values. Please don't mind type label overlapping with column name, the fix is ready in a different PR 🙂ADDITIONAL INFORMATION
CC: @villebro @junlincc