Skip to content

Amartinez/delete secret with registry#12433

Merged
nikitassharma merged 29 commits intocloudflare:mainfrom
martinezjandrew:amartinez/delete-secret-with-registry
Feb 9, 2026
Merged

Amartinez/delete secret with registry#12433
nikitassharma merged 29 commits intocloudflare:mainfrom
martinezjandrew:amartinez/delete-secret-with-registry

Conversation

@martinezjandrew
Copy link
Copy Markdown
Contributor

@martinezjandrew martinezjandrew commented Feb 5, 2026

Fixes #CC-6715.

When deleting a container registry, users will now be prompted if they'd like to delete the associated secret, if received from Cloudflare API. If agreed, the containers registries delete command will delete the secret as well.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not a documented feature
image
Open with Devin

martinezjandrew and others added 25 commits February 4, 2026 15:21
…12418)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…lare/src/frameworks (#12366)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>
…/src/frameworks (#12367)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>
@martinezjandrew martinezjandrew requested review from a team as code owners February 5, 2026 16:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: a68c974

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/wrangler/src/containers/registries.ts
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Feb 5, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12433

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12433

miniflare

npm i https://pkg.pr.new/miniflare@12433

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12433

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12433

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12433

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12433

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12433

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12433

wrangler

npm i https://pkg.pr.new/wrangler@12433

commit: a68c974

Copy link
Copy Markdown
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just needs a changeset :)

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 6, 2026
@nikitassharma nikitassharma merged commit 2acb277 into cloudflare:main Feb 9, 2026
33 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 9, 2026
@martinezjandrew martinezjandrew deleted the amartinez/delete-secret-with-registry branch February 9, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

10 participants