Skip to content

Remove some of the no-restricted-imports eslint disabling comments#13140

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-some-no-restrictred-imports-eslint-disable-comments
Mar 31, 2026
Merged

Remove some of the no-restricted-imports eslint disabling comments#13140
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-some-no-restrictred-imports-eslint-disable-comments

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Mar 31, 2026

We have a bunch of comments such as:

// eslint-disable-next-line no-restricted-imports

When AI creates new files it seems like it even adds this, I imagine to be consistent with the codebase

In this PR I'm just doing a bit of cleaning up and removing a bunch of these, mostly the simplest ones that require the less amount of changes


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: 02459f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13140

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13140

miniflare

npm i https://pkg.pr.new/miniflare@13140

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13140

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13140

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13140

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13140

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13140

wrangler

npm i https://pkg.pr.new/wrangler@13140

commit: 02459f7

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 31, 2026

The analysis is thorough and confirms that all changes are safe. Importantly, the agent also noted that wrangler's vitest config has globals: true, meaning expect would be available globally as a fallback regardless. The changes are purely mechanical: removing expect from vitest imports, removing eslint-disable-next-line no-restricted-imports comments, and adding ({ expect }) to test callback signatures.

LGTM

github run

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 31, 2026 10:54
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 31, 2026 10:54
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 31, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants