Remove all eslint comments disabling no-restricted-imports from miniflare

[dario-piotrowicz]

Removal of comments such as:

// eslint-disable-next-line no-restricted-imports

In the miniflare package

Continuation from #13140 and #13149

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)

---

[changeset-bot]

⚠️ No Changeset found

Latest commit: 796e373

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ask-bonk]

UnknownError: ProviderInitError

github run

[ask-bonk]

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13164

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13164

miniflare

npm i https://pkg.pr.new/miniflare@13164

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13164

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13164

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13164

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13164

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13164

wrangler

npm i https://pkg.pr.new/wrangler@13164

commit: 796e373

[ask-bonk]

UnknownError: ProviderInitError

github run

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/workers-kv
• ✅ @cloudflare/wrangler

Show detailed file reviewers

• packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]
• packages/miniflare/test/plugins/kv/sites.spec.ts: [@cloudflare/workers-kv]

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

[petebacondarwin]

A few type import modifiers missing but otherwise LGTM

[dario-piotrowicz]

Thanks for catching those @petebacondarwin! 🫶 (I relied on vscode's automatically adding the import there and missed these 😓)

I'm actually surprised that the missing modifier didn't trigger a lint error... I was pretty sure we had one set up for this 🤔

[dario-piotrowicz]

I'm actually surprised that the missing modifier didn't trigger a lint error... I was pretty sure we had one set up for this 🤔

oh...

workers-sdk/.oxlintrc.jsonc

Line 130 in fb67a18

"@typescript-eslint/consistent-type-imports": "off",

[dario-piotrowicz]

I'm actually surprised that the missing modifier didn't trigger a lint error... I was pretty sure we had one set up for this 🤔

oh...

workers-sdk/.oxlintrc.jsonc

Line 130 in fb67a18

"@typescript-eslint/consistent-type-imports": "off",

#13183 🙂