Remove all removable eslint disabling comments for no-restricted-imports in wrangler e2e

[dario-piotrowicz]

Removal of comments such as:

// eslint-disable-next-line no-restricted-imports

In the wrangler e2es

Continuation from #13140

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: refactoring

A picture of a cute animal (not mandatory, but encouraged)

---

[changeset-bot]

⚠️ No Changeset found

Latest commit: f89e60d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

This PR removes no-restricted-imports ESLint disable comments by threading expect from test context through helper functions instead of importing it at module level.

Two issues found and posted as review comments on PR #13149:

1. [Critical] validateAssetUploadLogs in normalize.ts had expect added as a new first parameter, but the 8 call sites in deployments.test.ts and 2 call sites in versions.test.ts were not updated. This will break those tests.

2. [Minor] The ESLint disable comment in vitest.setup.ts uses a single - instead of -- for the description separator. Posted a suggestion with the fix.

github run

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13149

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13149

miniflare

npm i https://pkg.pr.new/miniflare@13149

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13149

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13149

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13149

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13149

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13149

wrangler

npm i https://pkg.pr.new/wrangler@13149

commit: f89e60d

[workers-devprod]

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

Show detailed file reviewers

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.