Skip to content

remove most lint disabling comments for no-restricted-imports in wrangler/src/__tests__/helpers#13374

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-no-restricted-import-from-wrangler-test-helpers
Apr 15, 2026
Merged

remove most lint disabling comments for no-restricted-imports in wrangler/src/__tests__/helpers#13374
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-no-restricted-import-from-wrangler-test-helpers

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 9, 2026

Removal of most of the comments like:

// eslint-disable-next-line no-restricted-imports

from wrangler/src/__tests__/helpers

Continuation from #13140, #13149 #13164, #13247, #13245 and #13255


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 560e14b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 9, 2026
@dario-piotrowicz dario-piotrowicz force-pushed the dario/remove-no-restricted-import-from-wrangler-test-helpers branch 2 times, most recently from a3fef46 to 2ea4765 Compare April 9, 2026 16:38
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 9, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 9, 2026

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/remove-no-restricted-import-from-wrangler-test-helpers branch from 2ea4765 to 5d011e7 Compare April 9, 2026 16:42
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 9, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13374

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13374

miniflare

npm i https://pkg.pr.new/miniflare@13374

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13374

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13374

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13374

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13374

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13374

wrangler

npm i https://pkg.pr.new/wrangler@13374

commit: 560e14b

@dario-piotrowicz dario-piotrowicz force-pushed the dario/remove-no-restricted-import-from-wrangler-test-helpers branch 4 times, most recently from 7766d90 to 93c7b91 Compare April 10, 2026 07:53
@dario-piotrowicz dario-piotrowicz changed the title remove all lint disabling comments for no-restricted-imports in wrangler/src/__tests__/helpers remove most lint disabling comments for no-restricted-imports in wrangler/src/__tests__/helpers Apr 10, 2026
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 10, 2026 08:06
@workers-devprod workers-devprod requested review from a team and vicb and removed request for a team April 10, 2026 08:06
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/wrangler/src/tests/deploy/entry-points.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/legacy-assets.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/routes.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/deploy/workers-dev.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/assert-request.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-get-pages-upload-token.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-get-zone-from-host.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-kv.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-legacy-script.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-worker-settings.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-workers-subdomain.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/mock-zone-routes.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/helpers/msw/handlers/deployments.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/deploy.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/pages/project-upload.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/provision.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/versions/versions.upload.test.ts: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/remove-no-restricted-import-from-wrangler-test-helpers branch from 93c7b91 to 3064e0c Compare April 10, 2026 22:43
@petebacondarwin petebacondarwin force-pushed the dario/remove-no-restricted-import-from-wrangler-test-helpers branch from 3064e0c to 560e14b Compare April 15, 2026 08:06
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 15, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@petebacondarwin petebacondarwin removed the request for review from vicb April 15, 2026 08:12
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 15, 2026
@dario-piotrowicz
Copy link
Copy Markdown
Member Author

Thanks Pete! 🫶

@dario-piotrowicz dario-piotrowicz merged commit 1f82b1d into main Apr 15, 2026
62 of 63 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/remove-no-restricted-import-from-wrangler-test-helpers branch April 15, 2026 10:07
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants