Skip to content

Remove all eslint comment disabling no-restricted-imports from the vite-plugin playground#13247

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-no-restricted-imports-from-vite-plugin
Apr 2, 2026
Merged

Remove all eslint comment disabling no-restricted-imports from the vite-plugin playground#13247
dario-piotrowicz merged 1 commit intomainfrom
dario/remove-no-restricted-imports-from-vite-plugin

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 2, 2026

Removal of the comment:

// eslint-disable-next-line no-restricted-imports

from the vite-plugin playground

Continuation from #13140, #13149 and #13164


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

⚠️ No Changeset found

Latest commit: d14c55d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 2, 2026
@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team April 2, 2026 10:25
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 2, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 2, 2026

The changes are straightforward and correct. Let me verify my understanding:

  1. The eslint-disable-next-line no-restricted-imports comment is removed.
  2. expect is no longer imported at the top level from vitest — instead it's destructured from the test context (async ({ expect })) in each test callback. This is the idiomatic way to use expect in vitest-pool-workers.
  3. In afterAll, where there's no test context, expect is replaced with assert — which is a valid alternative that doesn't require the lint disable.
  4. The assert call includes a helpful error message formatting the remaining errors.
  5. A minor formatting change on the slash-create test expectation (line break for long value) is just auto-formatting.

Everything here is a clean mechanical refactor with no logic changes, no bugs, and no backward compatibility concerns.

LGTM

github run

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13247

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13247

miniflare

npm i https://pkg.pr.new/miniflare@13247

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13247

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13247

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13247

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13247

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13247

wrangler

npm i https://pkg.pr.new/wrangler@13247

commit: d14c55d

@dario-piotrowicz dario-piotrowicz force-pushed the dario/remove-no-restricted-imports-from-vite-plugin branch from f69d9dd to d14c55d Compare April 2, 2026 10:38
@ascorbic ascorbic enabled auto-merge April 2, 2026 14:34
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@ascorbic ascorbic added this pull request to the merge queue Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2026
@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 0bbf104 Apr 2, 2026
54 of 55 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/remove-no-restricted-imports-from-vite-plugin branch April 2, 2026 15:05
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants