Skip to content

Added Github-handle for Sandra Berjan in design-systems.md#6746

Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6700
Apr 29, 2024
Merged

Added Github-handle for Sandra Berjan in design-systems.md#6746
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6700

Conversation

@jenjenkayi
Copy link
Member

Fixes #6700

What changes did you make?

  • Added github-handle for Sandra Berjan in design-systems.md.

Why did you make the changes (we will use this info to test)?

  • Reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Adding github-handle to the file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jenjenkayi-add-github-handle-6700 gh-pages
git pull https://github.com/jenjenkayi/website.git add-github-handle-6700

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jenjenkayi/website/blob/add-github-handle-6700/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 24, 2024
Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenjenkayi,

  • The pull request is done with the correct branch
  • The issue is properly linked
  • Your summary of changes is clear
  • Your code change is clean and accurate, correctly using spaces instead of tabs to indent

Thanks for your contribution to this issue!

@t-will-gillis
Copy link
Member

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!
#6746, #6767, #6768, #6770, #6772

@angela-lee1 angela-lee1 self-requested a review April 29, 2024 13:09
@angela-lee1
Copy link
Member

Review ETA: eod 4/29
Availability: from 1:00pm EST 4/29

Copy link
Member

@angela-lee1 angela-lee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenjenkayi Awesome job!

  • you have linked the correct issue, your branch is correct
  • a clear description is provided for making the change
  • you gave the reason for not providing screenshots

Thank you!

@Thinking-Panda
Copy link
Member

@jenjenkayi Thank you for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Sandra Berjan in design-systems.md

5 participants