Skip to content

Added redirections to ignorepath in cspell.json#6767

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
patelbansi3009:add-redirections-to-ignorepaths-cspell-5846
Apr 30, 2024
Merged

Added redirections to ignorepath in cspell.json#6767
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
patelbansi3009:add-redirections-to-ignorepaths-cspell-5846

Conversation

@patelbansi3009
Copy link
Member

Fixes #5846

What changes did you make?

  • Added redirections/ to the end of the array ignorePaths in the cspell.json file

Why did you make the changes (we will use this info to test)?

  • To make sure the redirections/ folder is not spell-checked.

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

  • Adding a line of code. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b patelbansi3009-add-redirections-to-ignorepaths-cspell-5846 gh-pages
git pull https://github.com/patelbansi3009/website.git add-redirections-to-ignorepaths-cspell-5846

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/patelbansi3009/website/blob/add-redirections-to-ignorepaths-cspell-5846/CONTRIBUTING.md  

@t-will-gillis
Copy link
Member

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!
#6746, #6767, #6768, #6770, #6772

@luisitocanlas luisitocanlas self-requested a review April 29, 2024 21:19
@luisitocanlas
Copy link
Member

Review ETA: EOD 29 April 2024
Availability: 29 April 2024

Copy link
Member

@luisitocanlas luisitocanlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patelbansi3009,

  • Pull request is done with the correct branch.
  • The issue is linked properly.
  • Pull request changes and reasoning were provided.
  • Everything looks good!

Thank you for working on this issue!

@Thinking-Panda
Copy link
Member

Hi @Maarimar , @awlFCCamp Please add your availability and ETA for this PR. Thanks!

@angela-lee1
Copy link
Member

Review ETA: eod 4/29
Availability: 4/29, 4/30

Copy link
Member

@angela-lee1 angela-lee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patelbansi3009, great work!

  • You've linked the correct issue and your branch is correct.
  • You've provided a clear description for making the change.
  • You've also given the reason for not providing screenshots.
  • The correct changes were made.
    Thank you.

@t-will-gillis
Copy link
Member

Hey @patelbansi3009 Thanks for helping out with the PR reviews

@t-will-gillis t-will-gillis merged commit 2a1ab68 into hackforla:gh-pages Apr 30, 2024
@Maarimar
Copy link
Member

Agree with @awlFCCamp and @luisitocanlas, great work! @patelbansi3009 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "redirections/" to "ignorePaths" array in cspell.json

7 participants