Added GitHub handle option for Eva Kwock in design-systems.md#6768
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s |
ajb176
left a comment
There was a problem hiding this comment.
Hey @taylorbeee
In the first line of your PR, there are two spaces instead of one between 'fixes' and '#6706', and it seems like that confuses the github action that adds labels to pull requests. Make sure to keep an eye on the checks when making a PR, if some of them fail there might be an issue with the way the PR was formatted.
Everything else looks good:
- md file is edited correctly
- Branch is descriptive
- PR other than the typo in the first line is well-written
- There are no visual changes to the website
Just quickly fix that first line in the PR and I'll approve.
|
@ajb176 I fixed the typo in the PR. Good eye, and thanks for pointing that out! |
|
Review ETA: EST 11 PM 5/1/24 |
LRenDO
left a comment
There was a problem hiding this comment.
Hi @taylorbeee !
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site.
- Note was left that there were no visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
Again, nice work and thanks for taking the time to contribute to the website!
del9ra
left a comment
There was a problem hiding this comment.
Hey @taylorbeee,
- The PR is done with the correct branch
- The issue is properly linked
- Changes were summarized and implemented correctly
- No visual changes were made to the website
Great job! Thanks for your contribution!
Fixes #6706
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)