Skip to content

Added GitHub handle option for Eva Kwock in design-systems.md#6768

Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom
taylorbeee:add-github-handle-Eva-Kwock-6706
May 1, 2024
Merged

Added GitHub handle option for Eva Kwock in design-systems.md#6768
LRenDO merged 1 commit intohackforla:gh-pagesfrom
taylorbeee:add-github-handle-Eva-Kwock-6706

Conversation

@taylorbeee
Copy link
Member

@taylorbeee taylorbeee commented Apr 26, 2024

Fixes #6706

What changes did you make?

  • Added empty github-handle variable under Eva Kwock's name variable.

Why did you make the changes (we will use this info to test)?

  • Eventually the added github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Added an empty variable. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b taylorbeee-add-github-handle-Eva-Kwock-6706 gh-pages
git pull https://github.com/taylorbeee/website.git add-github-handle-Eva-Kwock-6706

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/taylorbeee/website/blob/add-github-handle-Eva-Kwock-6706/CONTRIBUTING.md  

@t-will-gillis
Copy link
Member

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!
#6746, #6767, #6768, #6770, #6772

Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @taylorbeee

In the first line of your PR, there are two spaces instead of one between 'fixes' and '#6706', and it seems like that confuses the github action that adds labels to pull requests. Make sure to keep an eye on the checks when making a PR, if some of them fail there might be an issue with the way the PR was formatted.

Everything else looks good:

  • md file is edited correctly
  • Branch is descriptive
  • PR other than the typo in the first line is well-written
  • There are no visual changes to the website

Just quickly fix that first line in the PR and I'll approve.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 30, 2024
@taylorbeee
Copy link
Member Author

@ajb176 I fixed the typo in the PR. Good eye, and thanks for pointing that out!

@Thinking-Panda Thinking-Panda requested a review from del9ra May 1, 2024 02:19
@del9ra
Copy link
Member

del9ra commented May 1, 2024

Review ETA: EST 11 PM 5/1/24
Availability: 5-8 PM Thursday

Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work.

@LRenDO LRenDO self-requested a review May 1, 2024 18:53
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taylorbeee !
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site.
  • Note was left that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit 65b8ee2 into hackforla:gh-pages May 1, 2024
jonnyoe pushed a commit to jonnyoe/website that referenced this pull request May 1, 2024
Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @taylorbeee,

  1. The PR is done with the correct branch
  2. The issue is properly linked
  3. Changes were summarized and implemented correctly
  4. No visual changes were made to the website
    Great job! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Eva Kwock in design-systems.md

5 participants