Skip to content

Add surveys/ in cspell.json 5847#6772

Merged
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
ShamaaTabassum:add-surveys/-in-cspell.json-5847
Apr 29, 2024
Merged

Add surveys/ in cspell.json 5847#6772
t-will-gillis merged 2 commits intohackforla:gh-pagesfrom
ShamaaTabassum:add-surveys/-in-cspell.json-5847

Conversation

@ShamaaTabassum
Copy link
Member

Fixes #5847

What changes did you make?

-Added "surveys/ " to "ignorePaths" array in cspell.json

Why did you make the changes (we will use this info to test)?

  • So that "surveys/ " file should be excluded from spell checking,

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ShamaaTabassum-add-surveys/-in-cspell.json-5847 gh-pages
git pull https://github.com/ShamaaTabassum/website.git add-surveys/-in-cspell.json-5847

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/ShamaaTabassum/website/blob/add-surveys/-in-cspell.json-5847/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Apr 27, 2024
@ShamaaTabassum ShamaaTabassum requested a review from Maarimar April 27, 2024 19:06
@t-will-gillis
Copy link
Member

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!
#6746, #6767, #6768, #6770, #6772

Copy link
Member

@Maarimar Maarimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! @ShamaaTabassum, thank you for contributing :)
You used the correct branch to commit your changes and added the path in the correct file and array specified on the issue. GTG.

@patelbansi3009 patelbansi3009 self-requested a review April 29, 2024 16:32
@patelbansi3009
Copy link
Member

Availability: Mon-Thu (11PM - 6PM) EST
ETA: EOD 04/29

@patelbansi3009
Copy link
Member

Great work @ShamaaTabassum!

  • Used the correct branch.
  • Accurately linked the issue.
  • Code changes are made as requested in the issue.
  • There are no visual changes on the website.

Keep up the good work!

Copy link
Member

@patelbansi3009 patelbansi3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Execution @ShamaaTabassum! Keep up the good work.

@t-will-gillis
Copy link
Member

Hey @ShamaaTabassum Looks great, congrats on completing your first pull request!

As a friendly note for the next time: on the description above, if you add a space between the dash and the text following, the Markdown will render correctly. For example:

-My text is here

  • My text is here

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "surveys/ " to "ignorePaths" array in cspell.json

4 participants