Skip to content

Updating github handle for Naomi Chao#6770

Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
nssensalo:update-handle-6763
Apr 29, 2024
Merged

Updating github handle for Naomi Chao#6770
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
nssensalo:update-handle-6763

Conversation

@nssensalo
Copy link
Member

Fixes #6763

What changes did you make?

-Replaced "- name: Naomi Chao" with "- name: Naomi Chao github-handle: "

Why did you make the changes (we will use this info to test)?

  • The plan is for a single github-handle variable to replace the github and picture variables.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

The Visual was unchanged. I deleted the site and jekyll files and restarted docker as suggested but I still didn't see my changes.

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nssensalo-update-handle-6763 gh-pages
git pull https://github.com/nssensalo/website.git update-handle-6763

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/nssensalo/website/blob/update-handle-6763/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 27, 2024
@moazDev1 moazDev1 self-requested a review April 28, 2024 05:47
@moazDev1
Copy link
Member

moazDev1 commented Apr 28, 2024

Availability: Sat - Mon (6PM - 10PM)
ETA: EOD 4/27

Copy link
Member

@moazDev1 moazDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @nssensalo on:

  1. Using the correct branch for your pull request.
  2. Accurately linking the issue.
  3. Making code changes as requested in the issue
  4. Ensuring no visual changes across multiple browsers (Safari, Firefox, Chrome) in both desktop and mobile views.
  5. Applicable and clean code changes.

Keep going!!

@t-will-gillis
Copy link
Member

Hey @jenjenkayi, @patelbansi3009, @taylorbeee, @nssensalo, @ShamaaTabassum as a reminder, while you are waiting for your PRs to be reviewed, please consider reviewing each other’s good first issue PRs and any other PRs you feel comfortable with. Instructions are here for How to Review Pull Requests . You should aim to review two PRs for every PR you submit, and each PR ideally should have two or more reviewers. Thanks!
#6746, #6767, #6768, #6770, #6772

@patelbansi3009
Copy link
Member

patelbansi3009 commented Apr 29, 2024

Availability: Mon-Thu (11PM - 6PM) EST
ETA: EOD 04/29

@patelbansi3009
Copy link
Member

Excellent Job @nssensalo!

  • Correct Branch was used for the issue.
  • Accurately linked the issue.
  • Code changes are made as requested in the issue.
  • There are no visual changes on the website, checked on all multiple viewports (such as mobile or tablet), through the browser's developer mode
  • Code changes look clean.

Thank You!

Copy link
Member

@patelbansi3009 patelbansi3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @nssensalo! Keep up the good work.

@Thinking-Panda
Copy link
Member

@nssensalo Thank you for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Naomi Chao in civic-tech-structure.md

5 participants