Cdac symbol reading 4 by max-charlamb · Pull Request #5 · max-charlamb/runtime

max-charlamb · 2025-07-07T22:13:25Z

No description provided.

When tests such as System.Security.Cryptography.X509Certificates.Tests.RevocationTests.DynamicRevocationTests.RevokeEndEntityWithInvalidRevocationSignature ran on EC-DSA with secp384r1, there is a roughly 50% chance that flipping all of the bits in signature[5] will produce a signature value that is not structurally valid DER by making the first 9 bits of an INTEGER all have the same value. OpenSSL bubbles up this error differently from "it is structurally valid, but the signature is wrong", which makes our tests fail. While there is some value in making these sorts of tamper look the same on Windows and Linux, the most important tamper is "the data was tampered with, invalidating the unchanged signature". That's the scenario these tests are trying to test (by making the signature wrong), so instead do the tamper at the second-to-last byte of the signature, which is always going to be in the "data" segment of a signature, never "structure" (for any known algorithm).

…otnet#118269) * Test extra platform failures * Revert changes

We have a special-code path that exists to optimize a singleline `.*?`, in which case we can just search for what comes after the loop in the pattern because the loop itself will lazily match everything. Unfortunately, we're passing the wrong node to the EmitIndexOf helper that emits that search. We should be passing the node which represents the subsequent literal, but we're accidentally passing the set loop itself. We're only here if that set loop matches everything, so we're emitting an IndexOfAnyInRange(0, \uFFFF) call. This is functionally ok, but perf tanks because we end up needing to do non-trivial work for every character that matches the loop.

* TailCallArgBuffer:State is 32-bit int. The code incorrectly used native int operation to set. It lead to TailCallArgBuffer::Size to be reset as well and needlessly re-allocating the tail call buffer. * Switch to preemptive mode around malloc/free in TailCallArgBuffer allocation Move the fast path of the TailCallArgBuffer allocation helper to C# to avoid perf overload of switching to preemptive mode. Also, aggressively inline it to allow zero initialization to be unrolled by the JIT. * Skip early GC reporting de-action if there is nothing to report Fixes dotnet#118166

…ructs (dotnet#118345)

…8281) Adds tests for bundles that contain non-ascii characters to validate all strings in a singlefile bundle are written as UTF-8.

* Increase fullAOT CI timeout to 480 minutes * remove some test suits not relevant for LLVM AOT

…kes (dotnet#118285) In ILC, when a DirectPInvokes item was prefixed with 'lib', it wouldn't recognize the library and wouldn't generate a direct pinvoke. There are a lot of places within the repo (and I assume other codebases) that use the 'lib' prefix in DirectPInvokes, so it seems to make more sense to handle that case rather than remove the prefix from all usages. This accounts for the scenario with `[DllImport("libMyLibrary")]` and `--directpinvoke MyLibrary`, but not the scenario with `[DllImport("MyLibrary")]` and `--directpinvoke:libMyLibrary`. Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…ave PGO data (dotnet#116104)

* Fix reading Zip64 end of central directory locator * Update src/libraries/System.IO.Compression/src/System/IO/Compression/ZipHelper.Async.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix build * Add test * Update src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchive.cs * Handle another offset out of bounds case. * Improve ZipArchiveFuzzer * Add another test case * Add a comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix * testing Larry's feedback * another attempt * more * Update src/mono/mono/mini/mini-wasm.c Co-authored-by: Larry Ewing <lewing@microsoft.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com>

…#118400) This test was allocating arrays that were nearly 2GB in size in order to attempt to test an edge case around seek overflowing. These large allocations are very unable in CI and started failing for Android + CoreCLR. The test is already disabled for Linux, for iOS, for tvOS, and partially for Windows. Rather than disable it yet again, let's just not test the very large allocation sizes. At this point the test has been disabled on so many platforms for being problematic we aren't getting much value from the large allocations.

…118273) This is preventing the AdvSimd tests from running in NativeAOT contexts. Fixes dotnet#118234

…8363) Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Fixes dotnet#118409

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dotnet#118040) The runtime supports assembly version downgrading (resolving a request for A, Version=3.0 with A, Version=1.0) but only through extension mechanisms: - AppDomain.AssemblyResolve event handler - AssemblyLoadContext.Resolving event handler - Custom AssemblyLoadContext.Load override However, there were no tests specifically validating this downgrading behavior. This change adds tests to validate that assembly resolution extension mechanisms can successfully downgrade assembly version requests, while normal runtime resolution cannot.

…ry (dotnet#118060)

… for WebAssembly apps (dotnet#118394) * Add StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute to WebAssembly props Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com>

* Refactor string allocation method to use native-sized integer; add support for CPBLK operation in interpreter; Special-case RuntimeHandle constructors * Add null reference checks before memcpy * Include namespace checks for RuntimeHandle types * Refactor EmitCall method to simplify type handling; replace memcpy with memcpyNoGCRefs for null reference safety * Remove unnecessary include of classnames.h

…aturateEven/Odd (dotnet#118338) The uqshrnb/t instructions perform a logical shift, when the intrinsic is an arithmetic shift. For reference: dotnet#94015

Adds support for analyzing implicit constructors to ILLink.RoslynAnalyzer. The implicit constructors aren't analyzed using the operation block APIs, so instead we add a special case for them.

Add release/10.0-rc1 -> release/10.0 automation

Recent changes to the JIT's inliner may lead to this method but not all of its callees being inlined, which is not good for performance. There is not much benefit to be had by inlining this method, so mark it as noinline. Fixes (part of) dotnet#118739.

* Re-enable DCJS tests for all platforms.

This seems to be at least one of the reasons why Hello World on Linux still needs support for boxed enums. `CreateSpan` is used with an enum type in Unix System.Console, which brings a boxed enum into whole program view and we can't undo the damage this causes to the whole program view during compilation anymore (even though we no longer need the `typeof` then because RyuJIT always expands `CreateSpan`).

* Remove chunk allocation in FunctionPointerOps * Remove LowLevelList * Remove Empty.cs * Replace simple cases with ArrayBuilder --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reenable disabled tests for System.Runtime.Caching.

…lName (dotnet#118852) AssemblyNameInfo.FullName includes full public key and other details that leads to very long error messages like: `Method will always throw because: Failed to load type 'NonExistent' from assembly 'System.Private.CoreLib, Version=10.0.0.0, Culture=neutral, PublicKey=00240000048000009400000006020000002400005253413100040000010001008d56c76f9e8649383049f383c44be0ec204181822a6c31cf5eb7ef486944d032188ea1d3920763712ccb12d75fb77e9811149e6148e5d32fbaab37611c1878ddc19e20ef135d0cb2cff2bfec3d115810c3d9069638fe4be215dbf795861920e5ab6f7db2e2ceef136ac23d5dd2bf031700aec232f6c6b1c785b4305c123b37ab' Use AssemblyNameInfo.Name instead where possible.

Avoid unnecessary code and allocations

…tnet#118563) * Implement UnhandledException hook for finalizers in Mono. * Cache the finalize method on wasm * Precompile invoke helper for GuardedFinalize * only check for GuardedFinalize in corlib * make GuardedFinalize virtual * use mono_runtime_try_invoke, since we can wih instance methods * comment out unused * Move GuardedFinalize to a helper class * make it static * some cleanup * remove no longer relevant comment

…t#118836)

* Move FlushProcessWriteBuffers to minipal Implements dotnet#117977 Also move the initialization of it and get of page size * Fix build * Fix linux build * Update definitions Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Feedback Do not care about cleanup * Feedback Do not move page size to minipal * Feedback Rename the files * Feedback Changes which were missed in earlier commits * Feedback Remove PalFlushProcessWriteBuffers wrapper * Feedback Remove parts around g_helperPage on mac * Feedback Rename to memory_barrier_process_wide * Fix mac build Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Fix build * Fix windows build * More specific include Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Fix windows build Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Feedback Remove windows wrapper too * Use more generic include again Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Apply suggestions from code review Refactor ifdefs Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Fix build * Complete the suggestion from feedback * Feedback Call `minipal_initialize_memory_barrier_process_wide` from unix `GCToOSInterface::Initialize`. Let it return true if it was previously successfully initialized. * Fix windows build * Apply suggestions from code review Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback Refactor minipal_memory_barrier_process_wide * Fix build * Apply suggestions from code review --------- Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Fixes Issue 80393

)

…118753)

* Update dependencies from https://github.com/dotnet/dotnet build 279727 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25414.103 -> 5.0.0-2.25417.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25414.103 -> 10.0.0-preview.25417.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25414.103 -> 10.0.100-rc.1.25417.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25414.103 -> 10.0.0-beta.25417.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25414.103 -> 0.11.5-alpha.25417.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25414.103 -> 2.9.3-beta.25417.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25414.103 -> 10.0.0-rc.1.25417.103) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.42003 -> 7.0.0-preview.1.41803) System.CommandLine (Version 2.0.0-rc.1.25414.103 -> 2.0.0-rc.1.25417.103) * Update dependencies from https://github.com/dotnet/dotnet build 279843 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25417.103 -> 5.0.0-2.25418.105) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25417.103 -> 10.0.0-preview.25418.105) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25417.103 -> 10.0.100-rc.1.25418.105) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25417.103 -> 10.0.0-beta.25418.105) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25417.103 -> 0.11.5-alpha.25418.105) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25417.103 -> 2.9.3-beta.25418.105) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25417.103 -> 10.0.0-rc.1.25418.105) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.0.0-preview.1.41803 -> 7.0.0-preview.1.41905) System.CommandLine (Version 2.0.0-rc.1.25417.103 -> 2.0.0-rc.1.25418.105) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…18864) * modify deps.json to be more in line with actual release deps.json file

…CLI (dotnet#118870) C++/CLI appears to leave the CORINFO_EH_CLAUSE ClassToken/FilterOffset union set to some nonzero value for fault/filter clauses. The JIT currently just passes this value along to the runtime. If a method with such a nonzero field is inlined into a dynamic method, this trips up a check in the runtime where a nonzero entry for such a field is interpreted as a class handle, even for fault/filter clauses where it should be ignored. Tolerate this by zeroing the field in the JIT and ignoring this field in the runtime/crossgen2 for finally/filter clauses. Note this could not have happened in pre .NET10 as methods with EH could not be inlined, so a dynamic method would never see such an EH clause, and in non-dynamic methods this field is ignored for faults and filters. Fixes dotnet#118837.

* use VirtualReadException instead of InvalidOperationException for read failures

i.e. Fold: (-(x)) == 0 -> x == 0 arm64 asmdiffs Diffs are based on <span style="color:#1460aa">436,095</span> contexts (<span style="color:#1460aa">26,618</span> MinOpts, <span style="color:#1460aa">409,477</span> FullOpts). <details> <summary>Overall (<span style="color:green">-40</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|183,146,276|<span style="color:green">-40</span>|<span style="color:green">-0.09%</span>| |benchmarks.run.linux.arm64.checked.mch|21,285,888|+0|0.00%| |smoke_tests.nativeaot.linux.arm64.checked.mch|3,003,400|+0|0.00%| </div></details> <details> <summary>FullOpts (<span style="color:green">-40</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|168,630,412|<span style="color:green">-40</span>|<span style="color:green">-0.09%</span>| |benchmarks.run.linux.arm64.checked.mch|20,953,436|+0|0.00%| |smoke_tests.nativeaot.linux.arm64.checked.mch|3,001,776|+0|0.00%| </div></details> <details> <summary>Example diffs</summary> <div style="margin-left:1em"> <details> <summary>libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-1.27%</span>) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -53,8 +53,7 @@ G_M13215_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0001 {x0}, byre G_M13215_IG03: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 {}, byref, isz asr w2, w2, dotnet#31 lsl w2, w2, #1 - add w0, w2, w0, ASR dotnet#31 - negs w0, w0 + adds w0, w2, w0, ASR dotnet#31 bne G_M13215_IG04 movz x0, #0xD1FFAB1E movk x0, #0xD1FFAB1E LSL dotnet#16 @@ -76,7 +75,7 @@ G_M13215_IG03: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 mov x19, x0 ; gcrRegs +[x19] b G_M13215_IG05 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M13215_IG04: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcrRegs -[x0 x19-x20] mov x20, xzr @@ -179,7 +178,7 @@ G_M13215_IG13: ; bbWeight=0, gcrefRegs=580000 {x19 x20 x22}, byrefRegs=00 b G_M13215_IG06 ;; size=12 bbWeight=0 PerfScore 0.00 -; Total bytes of code 316, prolog size 16, PerfScore 140.93, instruction count 79, allocated bytes for code 316 (MethodHash=c6bccc60) for method System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) +; Total bytes of code 312, prolog size 16, PerfScore 140.68, instruction count 78, allocated bytes for code 312 (MethodHash=c6bccc60) for method System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) ; ============================================================ Unwind Info: @@ -190,7 +189,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 79 (0x0004f) Actual length = 316 (0x00013c) + Function Length : 78 (0x0004e) Actual length = 312 (0x000138) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.27%</span>) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -531,10 +531,9 @@ G_M17523_IG25: ; bbWeight=1, gcrefRegs=400002 {x1 x22}, byrefRegs=0000 {} G_M17523_IG26: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 {}, byref, isz asr w0, w0, dotnet#31 lsl w0, w0, #1 - add w0, w0, w2, ASR dotnet#31 - negs w0, w0 + adds w0, w0, w2, ASR dotnet#31 beq G_M17523_IG29 - ;; size=20 bbWeight=0.50 PerfScore 2.25 + ;; size=16 bbWeight=0.50 PerfScore 2.00 G_M17523_IG27: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcrRegs -[x1 x19] mov w19, wzr @@ -733,7 +732,7 @@ G_M17523_IG43: ; bbWeight=0.00, gcrefRegs=0001 {x0}, byrefRegs=0000 {}, b brk #0 ;; size=32 bbWeight=0.00 PerfScore 0.00 -; Total bytes of code 1488, prolog size 36, PerfScore 200.96, instruction count 372, allocated bytes for code 1488 (MethodHash=abb9bb8c) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) +; Total bytes of code 1484, prolog size 36, PerfScore 200.71, instruction count 371, allocated bytes for code 1484 (MethodHash=abb9bb8c) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) ; ============================================================ Unwind Info: @@ -744,7 +743,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 372 (0x00174) Actual length = 1488 (0x0005d0) + Function Length : 371 (0x00173) Actual length = 1484 (0x0005cc) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.26%</span>) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -208,7 +208,7 @@ ; V197 cse1 [V197,T40] ( 2, 1 ) ref -> x0 "CSE #7: moderate" ; V198 cse2 [V198,T44] ( 2, 1 ) int -> x23 "CSE #4: moderate" ; V199 cse3 [V199,T45] ( 2, 1 ) long -> x1 "CSE #5: moderate" -; V200 cse4 [V200,T33] ( 3, 1.50) int -> x1 "CSE dotnet#17: moderate" +; V200 cse4 [V200,T33] ( 3, 1.50) int -> x1 "CSE dotnet#16: moderate" ; V201 rat0 [V201,T01] ( 3, 5.62) byref -> x1 "fgMakeTemp is creating a new local variable" ; V202 rat1 [V202,T07] ( 5, 3.75) ref -> x0 "replacement local" ; V203 rat2 [V203,T37] ( 3, 1.25) long -> x2 "CSE for expectedClsNode" @@ -623,8 +623,7 @@ G_M55449_IG30: ; bbWeight=1, gcrefRegs=4180002 {x1 x19 x20 x26}, byrefReg G_M55449_IG31: ; bbWeight=0.50, gcrefRegs=180000 {x19 x20}, byrefRegs=0000 {}, byref, isz asr w1, w21, dotnet#31 lsl w1, w1, #1 - add w1, w1, w22, ASR dotnet#31 - negs w1, w1 + adds w1, w1, w22, ASR dotnet#31 bne G_M55449_IG32 mov x1, x19 ; gcrRegs +[x1] @@ -642,7 +641,7 @@ G_M55449_IG31: ; bbWeight=0.50, gcrefRegs=180000 {x19 x20}, byrefRegs=000 ; gcrRegs -[x1 x20] mov w20, #1 b G_M55449_IG33 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M55449_IG32: ; bbWeight=0.50, gcrefRegs=80000 {x19}, byrefRegs=0000 {}, byref mov w20, wzr ;; size=4 bbWeight=0.50 PerfScore 0.25 @@ -776,7 +775,7 @@ G_M55449_IG46: ; bbWeight=0, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref brk #0 ;; size=40 bbWeight=0 PerfScore 0.00 -; Total bytes of code 1516, prolog size 48, PerfScore 174.78, instruction count 379, allocated bytes for code 1516 (MethodHash=a4562766) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) +; Total bytes of code 1512, prolog size 48, PerfScore 174.53, instruction count 378, allocated bytes for code 1512 (MethodHash=a4562766) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) ; ============================================================ Unwind Info: @@ -787,7 +786,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 379 (0x0017b) Actual length = 1516 (0x0005ec) + Function Length : 378 (0x0017a) Actual length = 1512 (0x0005e8) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary>+0 (0.00%) : 223365.dasm - System.Resources.Extensions.DeserializingResourceReader:CompareStringEqualsName(System.String):bool:this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -106,7 +106,7 @@ G_M52056_IG05: ; bbWeight=0.50, gcrefRegs=500000 {x20 x22}, byrefRegs=000 ldr x3, [x3] blr x3 ; gcrRegs -[x0-x1 x20 x22] - negs w0, w0 + cmp w0, #0 cset x0, eq ;; size=40 bbWeight=0.50 PerfScore 4.25 G_M52056_IG06: ; bbWeight=0.50, epilog, nogc, extend ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.02%</span>) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -3678,8 +3678,7 @@ G_M43941_IG97: ; bbWeight=1, gcVars=0000000000000000000000000000000000000 G_M43941_IG98: ; bbWeight=4, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, byrefRegs=0000 {}, byref, isz ldr w1, [x2, #0x08] ldr w0, [fp, #0xD1FFAB1E] // [V74 tmp49] - sub w1, w0, w1 - negs w1, w1 + subs w1, w0, w1 beq G_M43941_IG90 ldp w0, w1, [x22, #0x10] add w1, w1, #1 @@ -3688,7 +3687,7 @@ G_M43941_IG98: ; bbWeight=4, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, ldr w1, [x2, #0x08] cmp w1, w0 bls G_M43941_IG100 - ;; size=48 bbWeight=4 PerfScore 76.00 + ;; size=44 bbWeight=4 PerfScore 74.00 G_M43941_IG99: ; bbWeight=3.03, gcVars=00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002 {V06}, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, byrefRegs=0000 {}, gcvars, byref ; GC ptr vars -{V75} add w1, w0, #1 @@ -7803,7 +7802,7 @@ RWD00 dq 00740053002D0031h, 0067006E00690072h RWD16 dq 007200740053002Dh, 00310067006E0069h -; Total bytes of code 18184, prolog size 44, PerfScore 10435.99, instruction count 4546, allocated bytes for code 18184 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) +; Total bytes of code 18180, prolog size 44, PerfScore 10433.99, instruction count 4545, allocated bytes for code 18180 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) ; ============================================================ Unwind Info: @@ -7814,7 +7813,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 4130 (0x01022) Actual length = 16520 (0x004088) + Function Length : 4129 (0x01021) Actual length = 16516 (0x004084) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.16%</span>) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -595,8 +595,7 @@ G_M36412_IG24: ; bbWeight=1, gcrefRegs=B80000 {x19 x20 x21 x23}, byrefReg G_M36412_IG25: ; bbWeight=0.50, gcrefRegs=B80000 {x19 x20 x21 x23}, byrefRegs=0000 {}, byref, isz asr w1, w24, dotnet#31 lsl w1, w1, #1 - add w1, w1, w25, ASR dotnet#31 - negs w1, w1 + adds w1, w1, w25, ASR dotnet#31 bne G_M36412_IG26 mov x1, x20 ; gcrRegs +[x1] @@ -618,7 +617,7 @@ G_M36412_IG25: ; bbWeight=0.50, gcrefRegs=B80000 {x19 x20 x21 x23}, byref ; gcrRegs -[x1] +[x0] ; gcr arg pop 0 b G_M36412_IG27 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M36412_IG26: ; bbWeight=0.50, gcrefRegs=A80000 {x19 x21 x23}, byrefRegs=0000 {}, byref ; gcrRegs -[x0 x20] mov x20, xzr @@ -1232,7 +1231,7 @@ RWD16 dq <unknown method> dq G_M36412_IG51 -; Total bytes of code 2528, prolog size 48, PerfScore 347.37, instruction count 632, allocated bytes for code 2528 (MethodHash=f7d471c3) for method System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) +; Total bytes of code 2524, prolog size 48, PerfScore 347.12, instruction count 631, allocated bytes for code 2524 (MethodHash=f7d471c3) for method System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) ; ============================================================ Unwind Info: @@ -1243,7 +1242,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 591 (0x0024f) Actual length = 2364 (0x00093c) + Function Length : 590 (0x0024e) Actual length = 2360 (0x000938) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> </div></details> <details> <summary>benchmarks.run.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary>+0 (0.00%) : 3177.dasm - System.Resources.ResourceReader:CompareStringEqualsName(System.String):bool:this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -106,7 +106,7 @@ G_M1070_IG05: ; bbWeight=0.50, gcrefRegs=500000 {x20 x22}, byrefRegs=0000 ldr x3, [x3] blr x3 ; gcrRegs -[x0-x1 x20 x22] - negs w0, w0 + cmp w0, #0 cset x0, eq ;; size=40 bbWeight=0.50 PerfScore 4.25 G_M1070_IG06: ; bbWeight=0.50, epilog, nogc, extend ``` </div></details> </div></details> <details> <summary>smoke_tests.nativeaot.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary>+0 (0.00%) : 18583.dasm - Generics+TestAsyncGVMScenarios:RunAsync() (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18730.dasm - Generics+TestAsyncGVMScenarios:AsyncGvm1[System.__Canon]():this (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18865.dasm - Generics+TestAsyncGVMScenarios:AsyncGvm2[System.__Canon]():this (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18873.dasm - System.Threading.Tasks.Task:get_CompletedTask() (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> </div></details> </div></details> <details> <summary>Details</summary> <div style="margin-left:1em"> #### Size improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same size|Improvements (bytes)|Regressions (bytes)| |---|--:|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|11|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-40</span>|<span style="color:red">+0</span>| |benchmarks.run.linux.arm64.checked.mch|1|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |smoke_tests.nativeaot.linux.arm64.checked.mch|4|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">4</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| ||16|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">6</span>|<span style="color:green">-40</span>|<span style="color:red">+0</span>| --- #### PerfScore improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same PerfScore|Improvements (PerfScore)|Regressions (PerfScore)|PerfScore Overall in FullOpts| |---|--:|--:|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|11|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-0.10%</span>|0.00%|<span style="color:green">-0.0000%</span>| |benchmarks.run.linux.arm64.checked.mch|1|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|0.00%|0.00%|0.0000%| |smoke_tests.nativeaot.linux.arm64.checked.mch|4|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">4</span>|0.00%|0.00%|0.0000%| --- #### Context information |Collection|Diffed contexts|MinOpts|FullOpts|Missed, base|Missed, diff| |---|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|354,001|23,273|330,728|0 (0.00%)|0 (0.00%)| |benchmarks.run.linux.arm64.checked.mch|63,204|3,337|59,867|0 (0.00%)|0 (0.00%)| |smoke_tests.nativeaot.linux.arm64.checked.mch|18,890|8|18,882|0 (0.00%)|0 (0.00%)| ||436,095|26,618|409,477|0 (0.00%)|0 (0.00%)| --- #### jit-analyze output <details> <summary>libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch</summary> <div style="margin-left:1em"> ``` Summary of Code Size diffs: (Lower is better) Total bytes of base: 183146276 (overridden on cmd) Total bytes of diff: 183146236 (overridden on cmd) Total bytes of delta: -40 (-0.00 % of base) diff is an improvement. relative diff is an improvement. ``` <details> <summary>Detail diffs</summary> ``` Top file improvements (bytes): -4 : 162916.dasm (-0.242% of base) -4 : 141852.dasm (-0.162% of base) -4 : 141855.dasm (-0.158% of base) -4 : 141861.dasm (-0.201% of base) -4 : 162917.dasm (-0.269% of base) -4 : 142473.dasm (-1.266% of base) -4 : 142389.dasm (-0.182% of base) -4 : 162915.dasm (-0.264% of base) -4 : 162918.dasm (-0.185% of base) -4 : 106573.dasm (-0.022% of base) 10 total files with Code Size differences (10 improved, 0 regressed), 1 unchanged. Top method improvements (bytes): -4 (-0.022% of base) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) -4 (-1.266% of base) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) -4 (-0.182% of base) : 142389.dasm - System.IO.Pipelines.Tests.PipelineReaderWriterFacts:ResetAfterCompleteReaderAndWriterWithoutAdvancingClearsEverything():this (FullOpts) -4 (-0.162% of base) : 141852.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryAtMaxPoolSizeAllocatesFromPool():this (FullOpts) -4 (-0.158% of base) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) -4 (-0.201% of base) : 141861.dasm - System.IO.Pipelines.Tests.PipePoolTests:WritesToArrayPoolByDefault():this (FullOpts) -4 (-0.242% of base) : 162916.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_MultiBlock():this (FullOpts) -4 (-0.185% of base) : 162918.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_SingleBlock():this (FullOpts) -4 (-0.264% of base) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) -4 (-0.269% of base) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) Top method improvements (percentages): -4 (-1.266% of base) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) -4 (-0.269% of base) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) -4 (-0.264% of base) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) -4 (-0.242% of base) : 162916.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_MultiBlock():this (FullOpts) -4 (-0.201% of base) : 141861.dasm - System.IO.Pipelines.Tests.PipePoolTests:WritesToArrayPoolByDefault():this (FullOpts) -4 (-0.185% of base) : 162918.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_SingleBlock():this (FullOpts) -4 (-0.182% of base) : 142389.dasm - System.IO.Pipelines.Tests.PipelineReaderWriterFacts:ResetAfterCompleteReaderAndWriterWithoutAdvancingClearsEverything():this (FullOpts) -4 (-0.162% of base) : 141852.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryAtMaxPoolSizeAllocatesFromPool():this (FullOpts) -4 (-0.158% of base) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) -4 (-0.022% of base) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) 10 total methods with Code Size differences (10 improved, 0 regressed). ``` </details> -------------------------------------------------------------------------------- </div></details> <details> <summary>benchmarks.run.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> ``` Summary of Code Size diffs: (Lower is better) Total bytes of base: 21285888 (overridden on cmd) Total bytes of diff: 21285888 (overridden on cmd) Total bytes of delta: 0 (0.00 % of base) ``` <details> <summary>Detail diffs</summary> ``` 0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged. 0 total methods with Code Size differences (0 improved, 0 regressed). ``` </details> -------------------------------------------------------------------------------- </div></details> </div></details> x64 asmdiffs Diffs are based on <span style="color:#1460aa">2,787,549</span> contexts (<span style="color:#1460aa">1,078,277</span> MinOpts, <span style="color:#1460aa">1,709,272</span> FullOpts). <details> <summary>Overall (<span style="color:green">-116</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|305,501,642|<span style="color:green">-110</span>|<span style="color:green">-14.87%</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|157,729,192|<span style="color:green">-2</span>|<span style="color:green">-0.01%</span>| |libraries_tests.run.linux.x64.Release.mch|392,784,680|<span style="color:green">-4</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>MinOpts (<span style="color:green">-14</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|197,469,852|<span style="color:green">-10</span>|<span style="color:green">-1.28%</span>| |libraries_tests.run.linux.x64.Release.mch|215,792,030|<span style="color:green">-4</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>FullOpts (<span style="color:green">-102</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|108,031,790|<span style="color:green">-100</span>|<span style="color:green">-16.74%</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|146,383,976|<span style="color:green">-2</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>Example diffs</summary> <div style="margin-left:1em"> <details> <summary>coreclr_tests.run.linux.x64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-8</span> (<span style="color:green">-29.63%</span>) : 199901.dasm - TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -18,23 +18,19 @@ G_M18888_IG01: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, ;; size=0 bbWeight=1 PerfScore 0.00 G_M18888_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref sar edi, 1 - mov eax, edi - neg eax setne al movzx rax, al - add esi, esi - mov ecx, esi - neg ecx + shl esi, 1 setne cl movzx rcx, cl or eax, ecx - ;; size=26 bbWeight=1 PerfScore 4.50 + ;; size=18 bbWeight=1 PerfScore 3.75 G_M18888_IG03: ; bbWeight=1, epilog, nogc, extend ret ;; size=1 bbWeight=1 PerfScore 1.00 ; END METHOD TestNeg.Program:NegsBinOpSingleLine(int,int):bool -; Total bytes of code 27, prolog size 0, PerfScore 5.50, instruction count 12, allocated bytes for code 27 (MethodHash=d08ab637) for method TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts) +; Total bytes of code 19, prolog size 0, PerfScore 4.75, instruction count 8, allocated bytes for code 19 (MethodHash=d08ab637) for method TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-7</span> (<span style="color:green">-29.17%</span>) : 199894.dasm - TestNeg.Program:NegsLSR(uint):int (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -16,20 +16,17 @@ G_M6300_IG01: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, nogc <-- Prolog IG ;; size=0 bbWeight=0.50 PerfScore 0.00 G_M6300_IG02: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref + mov eax, -1 + mov ecx, 1 shr edi, 3 - mov eax, edi - mov ecx, -1 - mov edx, 1 - neg rax - mov eax, edx - cmove eax, ecx - ;; size=23 bbWeight=0.50 PerfScore 1.00 + cmovne eax, ecx + ;; size=16 bbWeight=0.50 PerfScore 0.62 G_M6300_IG03: ; bbWeight=0.50, epilog, nogc, extend ret ;; size=1 bbWeight=0.50 PerfScore 0.50 ; END METHOD TestNeg.Program:NegsLSR(uint):int -; Total bytes of code 24, prolog size 0, PerfScore 1.50, instruction count 8, allocated bytes for code 24 (MethodHash=2a8ee763) for method TestNeg.Program:NegsLSR(uint):int (FullOpts) +; Total bytes of code 17, prolog size 0, PerfScore 1.12, instruction count 5, allocated bytes for code 17 (MethodHash=2a8ee763) for method TestNeg.Program:NegsLSR(uint):int (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-7</span> (<span style="color:green">-29.17%</span>) : 199896.dasm - TestNeg.Program:NegsLargeShift(uint):int (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -16,20 +16,17 @@ G_M11276_IG01: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, nogc <-- Prolog IG ;; size=0 bbWeight=0.50 PerfScore 0.00 G_M11276_IG02: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref + mov eax, -1 + mov ecx, 1 shl edi, 4 - mov eax, edi - mov ecx, -1 - mov edx, 1 - neg rax - mov eax, edx - cmove eax, ecx - ;; size=23 bbWeight=0.50 PerfScore 1.00 + cmovne eax, ecx + ;; size=16 bbWeight=0.50 PerfScore 0.62 G_M11276_IG03: ; bbWeight=0.50, epilog, nogc, extend ret ;; size=1 bbWeight=0.50 PerfScore 0.50 ; END METHOD TestNeg.Program:NegsLargeShift(uint):int -; Total bytes of code 24, prolog size 0, PerfScore 1.50, instruction count 8, allocated bytes for code 24 (MethodHash=43eed3f3) for method TestNeg.Program:NegsLargeShift(uint):int (FullOpts) +; Total bytes of code 17, prolog size 0, PerfScore 1.12, instruction count 5, allocated bytes for code 17 (MethodHash=43eed3f3) for method TestNeg.Program:NegsLargeShift(uint):int (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-5</span> (<span style="color:green">-1.71%</span>) : 531325.dasm - ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0)</summary> <div style="margin-left:1em"> ```diff @@ -74,16 +74,14 @@ G_M28265_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, mov qword ptr [rbp-0x40], rdx mov rax, qword ptr [rbp-0x40] mov qword ptr [rbp-0x48], rax - mov eax, dword ptr [rbp-0x28] - neg rax - test rax, rax + cmp dword ptr [rbp-0x28], 0 jne SHORT G_M28265_IG03 mov eax, dword ptr [rbp-0x18] cmp eax, 255 ja SHORT G_M28265_IG06 mov eax, eax mov byte ptr [rbp-0x04], al - ;; size=182 bbWeight=1 PerfScore 117.08 + ;; size=177 bbWeight=1 PerfScore 117.58 G_M28265_IG03: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, isz mov eax, dword ptr [rbp-0x10] cmp rax, qword ptr [rbp-0x48] @@ -116,7 +114,7 @@ RWD16 dq 8000000000000000h ; -0 RWD24 dd 4F0BD98Fh ; 2.34629e+09 -; Total bytes of code 293, prolog size 31, PerfScore 147.42, instruction count 75, allocated bytes for code 293 (MethodHash=d26f9196) for method ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0) +; Total bytes of code 288, prolog size 31, PerfScore 147.92, instruction count 73, allocated bytes for code 288 (MethodHash=d26f9196) for method ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-2</span> (<span style="color:green">-4.17%</span>) : 181410.dasm - ldc_neg_i4._neg:i4_3(int,int):int (MinOpts)</summary> <div style="margin-left:1em"> ```diff @@ -30,18 +30,17 @@ G_M1458_IG03: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byre ;; size=5 bbWeight=0.50 PerfScore 0.50 G_M1458_IG04: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref xor eax, eax - neg eax test eax, eax sete al movzx rax, al - ;; size=12 bbWeight=1 PerfScore 2.00 + ;; size=10 bbWeight=1 PerfScore 1.75 G_M1458_IG05: ; bbWeight=1, epilog, nogc, extend add rsp, 16 pop rbp ret ;; size=6 bbWeight=1 PerfScore 1.75 -; Total bytes of code 48, prolog size 16, PerfScore 12.00, instruction count 16, allocated bytes for code 48 (MethodHash=0125fa4d) for method ldc_neg_i4._neg:i4_3(int,int):int (MinOpts) +; Total bytes of code 46, prolog size 16, PerfScore 11.75, instruction count 15, allocated bytes for code 46 (MethodHash=0125fa4d) for method ldc_neg_i4._neg:i4_3(int,int):int (MinOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-3</span> (<span style="color:green">-5.77%</span>) : 181421.dasm - ldc_neg_i8._neg:i8_3(long,long):int (MinOpts)</summary> <div style="margin-left:1em"> ```diff @@ -30,18 +30,17 @@ G_M18290_IG03: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byr ;; size=5 bbWeight=0.50 PerfScore 0.50 G_M18290_IG04: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref xor eax, eax - neg rax test rax, rax sete al movzx rax, al - ;; size=14 bbWeight=1 PerfScore 2.00 + ;; size=11 bbWeight=1 PerfScore 1.75 G_M18290_IG05: ; bbWeight=1, epilog, nogc, extend add rsp, 16 pop rbp ret ;; size=6 bbWeight=1 PerfScore 1.75 -; Total bytes of code 52, prolog size 18, PerfScore 12.00, instruction count 16, allocated bytes for code 52 (MethodHash=ff46b88d) for method ldc_neg_i8._neg:i8_3(long,long):int (MinOpts) +; Total bytes of code 49, prolog size 18, PerfScore 11.75, instruction count 15, allocated bytes for code 49 (MethodHash=ff46b88d) for method ldc_neg_i8._neg:i8_3(long,long):int (MinOpts) ; ============================================================ Unwind Info: ``` </div></details> </div></details> <details> <summary>libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-2</span> (<span style="color:green">-0.01%</span>) : 124444.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -3246,7 +3246,6 @@ G_M43941_IG102: ; bbWeight=1, gcVars=000000000000000000000000000000000000 G_M43941_IG103: ; bbWeight=4, gcrefRegs=F009 {rax rbx r12 r13 r14 r15}, byrefRegs=0000 {}, byref, isz mov esi, dword ptr [rbp-0x30] sub esi, dword ptr [rax+0x08] - neg esi je G_M43941_IG96 inc dword ptr [r13+0x14] mov rdi, gword ptr [r13+0x08] @@ -3254,7 +3253,7 @@ G_M43941_IG103: ; bbWeight=4, gcrefRegs=F009 {rax rbx r12 r13 r14 r15}, b mov esi, dword ptr [r13+0x10] cmp dword ptr [rdi+0x08], esi jbe SHORT G_M43941_IG106 - ;; size=31 bbWeight=4 PerfScore 65.00 + ;; size=29 bbWeight=4 PerfScore 64.00 G_M43941_IG104: ; bbWeight=3.05, gcVars=00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002 {V06}, gcrefRegs=F088 {rbx rdi r12 r13 r14 r15}, byrefRegs=0000 {}, gcvars, byref ; gcrRegs -[rax] ; GC ptr vars -{V75} @@ -6658,7 +6657,7 @@ RWD40 dq 4034000000000000h ; 20 RWD48 dq 4039000000000000h ; 25 -; Total bytes of code 14316, prolog size 28, PerfScore 7866.28, instruction count 3034, allocated bytes for code 14316 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) +; Total bytes of code 14314, prolog size 28, PerfScore 7865.28, instruction count 3033, allocated bytes for code 14314 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> </div></details> <details> <summary>libraries_tests.run.linux.x64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.03%</span>) : 314396.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0)</summary> <div style="margin-left:1em"> ```diff @@ -2199,13 +2199,11 @@ G_M43941_IG57: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcr arg pop 0 mov ecx, dword ptr [rbp-0x240] sub ecx, dword ptr [rax] - mov eax, ecx - ; byrRegs -[rax] - neg eax - test eax, eax + test ecx, ecx je G_M43941_IG56 mov rdi, 0xD1FFAB1E call CORINFO_HELP_COUNTPROFILE32 + ; byrRegs -[rax] ; gcr arg pop 0 mov rdi, gword ptr [rbp-0x50] ; gcrRegs +[rdi] @@ -2215,7 +2213,7 @@ G_M43941_IG57: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref call [<unknown method>] ; gcrRegs -[rsi rdi] ; gcr arg pop 0 - ;; size=309 bbWeight=1 PerfScore 58.00 + ;; size=305 bbWeight=1 PerfScore 57.50 G_M43941_IG58: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, isz mov eax, dword ptr [rbp-0x5E0] dec eax @@ -5412,7 +5410,7 @@ RWD08 dq 4034000000000000h ; 20 RWD16 dq 4039000000000000h ; 25 -; Total bytes of code 15982, prolog size 67, PerfScore 3425.70, instruction count 2755, allocated bytes for code 15982 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0) +; Total bytes of code 15978, prolog size 67, PerfScore 3425.20, instruction count 2753, allocated bytes for code 15978 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0) ; ============================================================ Unwind Info: ``` </div></details> </div></details> </div></details> <details> <summary>Details</summary> <div style="margin-left:1em"> #### Size improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same size|Improvements (bytes)|Regressions (bytes)| |---|--:|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |benchmarks.run_pgo.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |coreclr_tests.run.linux.x64.checked.mch|23|<span style="color:green">23</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-110</span>|<span style="color:red">+0</span>| |libraries.crossgen2.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |libraries.pmi.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-2</span>|<span style="color:red">+0</span>| |libraries_tests.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-4</span>|<span style="color:red">+0</span>| |realworld.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |smoke_tests.nativeaot.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| ||25|<span style="color:green">25</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-116</span>|<span style="color:red">+0</span>| --- #### PerfScore improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same PerfScore|Improvements (PerfScore)|Regressions (PerfScore)|PerfScore Overall in FullOpts| |---|--:|--:|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |benchmarks.run_pgo.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |coreclr_tests.run.linux.x64.checked.mch|23|<span style="color:green">22</span>|<span style="color:red">1</span>|<span style="color:blue">0</span>|<span style="color:green">-15.50%</span>|<span style="color:red">+0.34%</span>|<span style="color:green">-0.0017%</span>| |libraries.crossgen2.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |libraries.pmi.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0.01%</span>|0.00%|<span style="color:green">-0.0000%</span>| |libraries_tests.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0.01%</span>|0.00%|0.0000%| |realworld.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |smoke_tests.nativeaot.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| --- #### Context information |Collection|Diffed contexts|MinOpts|FullOpts|Missed, base|Missed, diff| |---|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|75,913|2,972|72,941|0 (0.00%)|0 (0.00%)| |benchmarks.run_pgo.linux.x64.checked.mch|122,785|86,206|36,579|0 (0.00%)|0 (0.00%)| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|76,998|2,939|74,059|0 (0.00%)|0 (0.00%)| |coreclr_tests.run.linux.x64.checked.mch|577,098|358,595|218,503|0 (0.00%)|0 (0.00%)| |libraries.crossgen2.linux.x64.checked.mch|269,385|20|269,365|0 (0.00%)|0 (0.00%)| |libraries.pmi.linux.x64.checked.mch|354,706|8|354,698|0 (0.00%)|0 (0.00%)| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|387,764|23,607|364,157|0 (0.00%)|0 (0.00%)| |libraries_tests.run.linux.x64.Release.mch|862,114|603,896|258,218|0 (0.00%)|0 (0.00%)| |realworld.run.linux.x64.checked.mch|29,264|21|29,243|0 (0.00%)|0 (0.00%)| |smoke_tests.nativeaot.linux.x64.checked.mch|31,522|13|31,509|0 (0.00%)|0 (0.00%)| ||2,787,549|1,078,277|1,709,272|0 (0.00%)|0 (0.00%)| --- #### jit-analyze output </div></details>

max-charlamb force-pushed the cdac-symbol-reading-4 branch from 2ed4725 to e4ce021 Compare July 7, 2025 22:16

kotlarmilos and others added 29 commits August 5, 2025 09:43

Update ActiveIssue references for Android in MutexTests (dotnet#118343)

2471117

[Apple mobile] Disable iOS.Simulator.LibraryMode.Test on simulator (d…

ab58a81

…otnet#118269) * Test extra platform failures * Revert changes

Disable timing out test on OSX (dotnet#118392)

dc32986

JIT: Remove redundant normalizing casts when passing and returning st…

824fdb1

…ructs (dotnet#118345)

Add tests for singlefile bundles with non-ascii characters (dotnet#11…

34574d7

…8281) Adds tests for bundles that contain non-ascii characters to validate all strings in a singlefile bundle are written as UTF-8.

[mono][infra] Increase fullAOT LLVM CI timeout (dotnet#118378)

63783f5

* Increase fullAOT CI timeout to 480 minutes * remove some test suits not relevant for LLVM AOT

JIT: Always compute loop iteration estimate in loop inversion if we h…

67541ba

…ave PGO data (dotnet#116104)

JIT: Fix ARM64 emitter tests (dotnet#117768)

d84ca95

[wasm][AOT] fix codegen for small structs on stack (dotnet#118355)

0ce54a5

* fix * testing Larry's feedback * another attempt * more * Update src/mono/mono/mini/mini-wasm.c Co-authored-by: Larry Ewing <lewing@microsoft.com> --------- Co-authored-by: Larry Ewing <lewing@microsoft.com>

Remove some uses of dynamic from HardwareIntrinsic test code (dotnet#…

dfb2850

…118273) This is preventing the AdvSimd tests from running in NativeAOT contexts. Fixes dotnet#118234

Replace native sized -> native-sized (dotnet#118402)

1b45b1b

Replace NET8_0_OR_GREATER with NET across all source files (dotnet#11…

565b6d3

…8363) Co-authored-by: agocke <515774+agocke@users.noreply.github.com>

Fix xUnit1041 in pri1 runtime tests (dotnet#118412)

e399fff

Fixes dotnet#118409

Managed Composite ML-DSA + ECDSA for netfx (dotnet#118356)

b8ed7bb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Introduce MetadataEEType node halfway between Constructed and Necessa…

5faa346

…ry (dotnet#118060)

Increase default stack guard on x86 Windows (dotnet#118277)

dc341ae

Fix constrained call corner cases (dotnet#111178)

2432268

Fix socket test (dotnet#118403)

cda16fd

JIT: Fix RISC-V emitter build (dotnet#118407)

d000ce2

SVE: Remove unsigned implementation of ShiftRightArithmeticNarrowingS…

0f7b74b

…aturateEven/Odd (dotnet#118338) The uqshrnb/t instructions perform a logical shift, when the intrinsic is an arithmetic shift. For reference: dotnet#94015

sbomer and others added 27 commits August 18, 2025 16:33

Add trim analysis for implicit constructors (dotnet#118755)

39aec19

Adds support for analyzing implicit constructors to ILLink.RoslynAnalyzer. The implicit constructors aren't analyzed using the operation block APIs, so instead we add a special case for them.

Update github-merge-flow.jsonc (dotnet#118859)

e3127ed

Add release/10.0-rc1 -> release/10.0 automation

Remove incorrect assert clause (dotnet#118828)

d521402

Re-enable DCJS tests for all platforms. (dotnet#118628)

dde503e

* Re-enable DCJS tests for all platforms.

[NativeAOT] Cleanup LowLevelList<T> (dotnet#118649)

090dd07

* Remove chunk allocation in FunctionPointerOps * Remove LowLevelList * Remove Empty.cs * Replace simple cases with ArrayBuilder --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Re-enable tests for Sys.RT.Caching (dotnet#118551)

c547a55

Reenable disabled tests for System.Runtime.Caching.

[NativeAOT] Streamline GetAssemblyCount (dotnet#118863)

ed96395

Avoid unnecessary code and allocations

Remove redundant nullable warning suppression (dotnet#118347)

c1bf33e

Update Android test to use ActiveIssue for OOM error reporting (dotne…

fad7576

…t#118836)

Check HFA alignment for valuetype fields (dotnet#106099)

5a7ac76

Fixes Issue 80393

Fix bad deallocate for zero-length allocations in alloc.h (dotnet#118866

19b9833

)

[clr-interp] Add support for mkrefany, refanyval, refanytype (dotnet#…

f48be8d

…118753)

library testhost modify deps.json to match actual release (dotnet#1…

026b064

…18864) * modify deps.json to be more in line with actual release deps.json file

Merge branch 'main' into cdac-symbol-reading-4

cba0020

update to support reading uninstrumented bounds

b960ed6

Update build to use C++17 compiler standard level (dotnet#118858)

bce39cc

[cDAC] Use specific exception for virtual read failures (dotnet#118895)

34d517f

* use VirtualReadException instead of InvalidOperationException for read failures

Merge remote-tracking branch 'origin/main' into cdac-symbol-reading-4

865a728

remove no longer needed specific catch

6d2c0a6

remove duplicate

3ed766d

max-charlamb closed this Aug 20, 2025

max-charlamb deleted the cdac-symbol-reading-4 branch August 20, 2025 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cdac symbol reading 4#5

Cdac symbol reading 4#5
max-charlamb wants to merge 717 commits intocdac-symbol-reading-3from
cdac-symbol-reading-4

max-charlamb commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

max-charlamb commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants