Cdac symbol reading 3 by max-charlamb · Pull Request #4 · max-charlamb/runtime

max-charlamb · 2025-05-05T15:22:09Z

No description provided.

…e generator (dotnet#117629) Lazy loops can be made automatically atomic in some situations by the optimizer, in which case their handling significantly simplifies, because a lazy atomic loop just becomes a repeater for the min iteration count. Most viable lazy loops are caught by the optimizer, but some aren't yet are determined to be treatable as atomic at emit time. EmitLazy was handling such cases incorrectly, resulting in a missing branch target and compilation failing. This fixes that two fold: 1. The optimizer is improved, so the discovered tests cases that were triggering this case no longer do. 2. The distinction is eliminated from EmitLazy, as the case is rare and it would take a lot more code to optimize for that case.

…es (dotnet#117894) Respect the `DOTNET_` prefix for `COREHOST_` environment variables as a move toward greater consistency for .NET environment variables

…#118005) We're currently sending tests to both AzureLinux.3.Amd64.Open and Ubuntu.2204.Amd64.Open. Just AzureLinux.3.Amd64.Open should be enough for host tests. I've seen some long wait times and timeouts for host tests sent to Ubuntu.2204.Amd64.Open recently. The libraries tests already run on Ubuntu - they use the live host, so that should have enough basic coverage.

@ChrisAhna

this fixes a problem with card mark stealing where we missed clamping the card clearing by the card stealing unit in `card_transition`. for this bug to appear the following conditions need to be met - + an object A straddles the 2mb card stealing unit and originally for that object a card below the 2mb boundary and a card that corresponds to at least 256 bytes above the 2mb boundary are set. and there are no reference fields inbetween. + one thread T0 is working on the 1st 2mb and discovers A and the first set card bit. this card doesn't need to be set, so `poo` is set the address that's described by the 2nd card since there're no reference fields inbetween. so `card_transition` is called which will call `clear_cards` on [1st card, (2nd card. and it stops at this line - ` card_table [end_word] &= highbits (~0, bits);` where it sees `end_card` with the 2nd card still set, but before it writes it back to `card_table[end_word]` + meanwhile, another thread T1 needs to be working on the memory starting from this 2mb boundary. it discovers the 2nd card doesn't need to be set, and none of the cards that correspond to the card bundle bit needs to be set so it clears the cards and the card bundle bit. + now T0 writes back to `card_table[end_word]` with the 2nd card bit set. it's not a problem when a card that shouldn't be set is set, given that its corresponding card bundle bit is also set. but it's definitely a problem if a card is set but its card bundle bit isn't, because next time when we have a cross gen reference, what's supposed to happen in the write barrier is either the card isn't already set and the WB will set the card and its corresponding card bundle bit, or the card is set and the WB wouldn't do anything. but now we have a situation where the card is set but the card bundle bit isn't, it just means the next GC that should be looking at this card wouldn't, if there were no other cards covered by that card bundle bit got newly set by the WB. the cleanest fix is to make sure we don't step outside of the 2mb boundary when we call `clear_cards` in `card_transition`. this issue was very hard to observe and debug - full credit goes to @ChrisAhna who also verified the fix.

…117982)

) * [wasm][coreclr] Get further in the runtime initialization Add corewasmhost binary to test runtime initialization Fix linking of the host binary with coreclr and interpreter Allow calling interpreter with arguments and handle return value Use fake precode stubs to pass the precode type and method desc Make alternate signal stack calls no-op on wasm Implement CallDescrWorkerInternal on wasm Fix PE image loading without RTR on wasm Do not use unsupported syscalls * Fix condition Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Fix build The jit helpers are used later unconditionally * Update after merge * Feedback * Update after merge * Fix release build offsets * Build Debug runtime configuration on CI, so that interpreter is enabled * Fix build * Enable interpreter in all configuration on wasm Fix build * Build in Release again as we are missing debug packages * Move inline keyword Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback * Feedback * Fix release build * Feedback Do not special case missing mono_wasm_browser_entropy and just add it to helpers with an assert * Feedback * Feedback Use MethodDesc's GetInterpreterCode() instead of GetNativeCode() * Feedback Do not use FEATURE_JIT for callstub exclusion, until we support it on wasm, use TARGET_WASM instead. Also update build after merge * Feedback Use PORTABILITY_ASSERT * Feedback, add FEATURE_PEIMAGE_FLAT_LAYOUT * Revert mapping changes for PE loaded layout We use the flat layout now * Feedback, change call order of execute interp method * Feedback, change condition to avoid dynamic loads in corhost * Increase stub size to fit interpreter stub data This way we get further in the initialization log: stdout: Interpreter compile method System.AppContext:Setup(ptr,ptr,int) log: stdout: Interpreter compile method System.Diagnostics.Debug:Assert(bool,System.String) log: stdout: Interpreter compile method System.Collections.Generic.Dictionary`2[System.__Canon,System.__Canon]:.ctor(int,System.Collections.Generic.IEqualityComparer`1[System.__Canon]) log: stdout: Interpreter compile method System.Diagnostics.Debug:Assert(bool,System.String,System.String) log: stdout: Interpreter compile method System.Collections.Generic.Dictionary`2[System.__Canon,System.__Canon]:.ctor(int) * Update precode sizes, feedback and size check * Feedback, TODO, transition block * Feedback * Use coreclr_static library for wasm And do not build coreclr * Feedback Disable larger part of GCToOSInterface::Initialize than before * Feedback Make InitializeFlushProcessWriteBuffers no-op on wasm * Write barriers helper updated Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Write barriers helper updated Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback Return false from ExecutableAllocator::IsDoubleMappingEnabled instead of making the double mapping init no-op on wasm * Make InitJITWriteBarrierHelpers no-op on wasm Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback Fix few asserts * Feedback Define PEIMAGE_FLAT_LAYOUT_ONLY in inc\switches.h * Feedback Replace __wasm__ where appropriate * Feedback Do not use __builtin_return_address on wasm * Feedback Add InvokeCalliStub to helpers * Feedback Update comments and remove unwanted fields * Feedback Add comment to the wasm specific call description data fields * Feedback Add portability assert in DispatchCallSimple to light up if we get called through this path * Fix build * Fix non-wasm build * Feedback Use FEATURE_JIT instead of not WASM check * Feedback Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback * Feedback Disable stack limit assert only in Debug configuration * Feedback Return flat layout from GetLoadedLayout when PEIMAGE_FLAT_LAYOUT_ONLY switch is enabled * Feedback Add more explanation in the comment and use the CodeSize in the assert * Add comment Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Feedback Move _ReturnAddress macro ro pal.h * Fix build * Feedback Make FlushProcessWriteBuffers no-op on wasm * Feedback Fix path * Fix whitespace Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Prefer TARGET_WASM Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Update src/coreclr/pal/src/init/pal.cpp Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Prefer TARGET_WASM Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Prefer TARGET_WASM * Few more places to use more general TARGET_WASM * Prefer TARGET_WASM Co-authored-by: Jan Kotas <jkotas@microsoft.com> --------- Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Collection expressions for known values * Simplify new() * Expand set of known header names and values * Also add text/plain without a space

…ynchronous runtime async calls (dotnet#117725) This implements the remaining handling: saving and restoring `Thread.CurrentThread._synchronizationContext` around runtime async calls that finish synchronously. Lots of trickiness in representing this in the JIT. We introduce a new "suspended indicator" local that is defined by async calls and that the front end uses when it expands IR that restores the field. Plenty of optimization opportunities remaining, including a simple jump threading optimization we should be able to do to make the suspension indicator variable disappear in common cases (all cases except when resuming with an exception).

…ging (dotnet#117978)

…StringLower on the Convert class (dotnet#117965) * Expose UTF-8 support from FromHexString, TryToHexString, and TryToHexStringLower on the Convert class * Fix copy/paste error * Fix an assert * Ensure TryDecodeFrom_Vector128 for UTF8 increments offset correctly

* Delete "Submitting Changes" section

) * Make IsAlive test reliable and re-enable it for crossgen2 Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Adding GetClrNotification cDAC API

Today we only support conversion of loops to atomic loops for single-character loops (e.g. a* or [abc]*). This PR augments the logic to support arbitrary loops, enabling many more loops to become atomic.

…#117995) Remove JIT/directed/lifetime/lifetime2 test because it is unreliable by construction

This could be used for dotnet#117712 and is a useful piece of metadata. I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.

* Allow floats to be recorded into the stresslog on 64-bit platforms (as 64-bit floating point values) * change gc start message and some factoring * quick fix to allowing gcstart to be a prefix * StressLogAnalyzer - handle 16 format arguments and avoid buffer overruns * comment * get_str_gc_type and remove non-BGC special cases * fix * TRACE_GC off * enable by default * not always * LL_INFO1000 for 'Segment mem' message * fewer messages * fewer messages * remove sizeof * Handle %3s * comment * comment * See if stresslog.h STRESS_LOG_VA is unnecessary * _DEBUG * Revert "See if stresslog.h STRESS_LOG_VA is unnecessary" This reverts commit 50eb8bd. * redo ifdef * move a few more dprintfs to 2 * comments * Fixed missed comments --------- Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com> Co-authored-by: Mukund Raghav Sharma <musharm@microsoft.com>

* Fix static virtual methods for delegate creation - Notably for creation of delegates to SVM methods which do not require generic dictionary lookups - Also a drive by fix of the vtable handling for NativeImageLayout which was causing crashes of the DAC when used in debug builds Fixes dotnet#109200

* Update dependencies from https://github.com/dotnet/dotnet build 275814 Updated Dependencies: System.CommandLine (Version 2.0.0-beta7.25367.101 -> 2.0.0-beta7.25368.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25367.101 -> 0.11.5-alpha.25368.102) Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.7.25367.101 -> 10.0.100-preview.7.25368.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25367.101 -> 10.0.0-beta.25368.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25367.101 -> 2.9.3-beta.25368.102) Microsoft.NETCore.App.Ref, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.7.25367.101 -> 10.0.0-preview.7.25368.102) Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-2.25367.101 -> 5.0.0-2.25368.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25367.101 -> 10.0.0-preview.25368.102) * Update dependencies from https://github.com/dotnet/dotnet build 275898 Updated Dependencies: System.CommandLine (Version 2.0.0-beta7.25368.102 -> 2.0.0-beta7.25368.105) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25368.102 -> 0.11.5-alpha.25368.105) Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.7.25368.102 -> 10.0.100-preview.7.25368.105) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25368.102 -> 10.0.0-beta.25368.105) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25368.102 -> 2.9.3-beta.25368.105) Microsoft.NETCore.App.Ref, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.7.25368.102 -> 10.0.0-preview.7.25368.105) Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-2.25368.102 -> 5.0.0-2.25368.105) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25368.102 -> 10.0.0-preview.25368.105) * Update dependencies from https://github.com/dotnet/dotnet build 276277 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25368.105 -> 5.0.0-2.25372.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25368.105 -> 10.0.0-preview.25372.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25368.105 -> 10.0.100-preview.7.25372.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25368.105 -> 10.0.0-beta.25372.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25368.105 -> 0.11.5-alpha.25372.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25368.105 -> 2.9.3-beta.25372.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25368.105 -> 10.0.0-preview.7.25372.103) System.CommandLine (Version 2.0.0-beta7.25368.105 -> 2.0.0-beta7.25372.103) * Update dependencies from https://github.com/dotnet/dotnet build 276450 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25372.103 -> 5.0.0-2.25373.104) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25372.103 -> 10.0.0-preview.25373.104) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25372.103 -> 10.0.100-preview.7.25373.104) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25372.103 -> 10.0.0-beta.25373.104) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25372.103 -> 0.11.5-alpha.25373.104) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25372.103 -> 2.9.3-beta.25373.104) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25372.103 -> 10.0.0-preview.7.25373.104) System.CommandLine (Version 2.0.0-beta7.25372.103 -> 2.0.0-beta7.25373.104) * Update dependencies from https://github.com/dotnet/dotnet build 276628 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25373.104 -> 5.0.0-2.25374.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25373.104 -> 10.0.0-preview.25374.102) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25373.104 -> 10.0.100-preview.7.25374.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25373.104 -> 10.0.0-beta.25374.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25373.104 -> 0.11.5-alpha.25374.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25373.104 -> 2.9.3-beta.25374.102) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25373.104 -> 10.0.0-preview.7.25374.102) System.CommandLine (Version 2.0.0-beta7.25373.104 -> 2.0.0-beta7.25374.102) * Update dependencies from https://github.com/dotnet/dotnet build 276797 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25374.102 -> 5.0.0-2.25375.106) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25374.102 -> 10.0.0-preview.25375.106) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25374.102 -> 10.0.100-preview.7.25375.106) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25374.102 -> 10.0.0-beta.25375.106) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25374.102 -> 0.11.5-alpha.25375.106) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25374.102 -> 2.9.3-beta.25375.106) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25374.102 -> 10.0.0-preview.7.25375.106) System.CommandLine (Version 2.0.0-beta7.25374.102 -> 2.0.0-rc.1.25375.106) * Update dependencies from https://github.com/dotnet/dotnet build 276828 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25375.106 -> 5.0.0-2.25375.119) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.106 -> 10.0.0-preview.25375.119) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25375.106 -> 10.0.100-preview.7.25375.119) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25375.106 -> 10.0.0-beta.25375.119) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25375.106 -> 0.11.5-alpha.25375.119) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25375.106 -> 2.9.3-beta.25375.119) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25375.106 -> 10.0.0-preview.7.25375.119) System.CommandLine (Version 2.0.0-rc.1.25375.106 -> 2.0.0-rc.1.25375.119) * Update dependencies from https://github.com/dotnet/dotnet build 276981 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25375.119 -> 5.0.0-2.25377.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.119 -> 10.0.0-preview.25377.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25375.119 -> 10.0.100-preview.7.25377.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25375.119 -> 10.0.0-beta.25377.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25375.119 -> 0.11.5-alpha.25377.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25375.119 -> 2.9.3-beta.25377.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25375.119 -> 10.0.0-preview.7.25377.103) System.CommandLine (Version 2.0.0-rc.1.25375.119 -> 2.0.0-rc.1.25377.103) * generate the Version.Details.props file * Backflow from https://github.com/dotnet/dotnet / 8b29a16 build 277635 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 277635 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25377.103 -> 5.0.0-2.25401.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25377.103 -> 10.0.0-preview.25401.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25377.103 -> 10.0.100-rc.1.25401.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25377.103 -> 10.0.0-beta.25401.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25377.103 -> 0.11.5-alpha.25401.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25377.103 -> 2.9.3-beta.25401.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25377.103 -> 10.0.0-rc.1.25401.103) System.CommandLine (Version 2.0.0-rc.1.25377.103 -> 2.0.0-rc.1.25401.103) * Disable HotReload in WBT until we have latest blazor bits * Explicitly set RuntimeIdentifier (singular) to force NativeAOT runtime pack download * Resolve the Version.props and Version.Details.props conflicts * Update expected syntax to match changed whitespace. * Disable some tests due to [ActiveIssue("dotnet#118475")] * Also mark reverse-complement-6 for [ActiveIssue("dotnet#118475")] * Backflow from https://github.com/dotnet/dotnet / 30bc8f9 build 278224 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 278224 Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25401.103 -> 5.0.0-2.25406.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25401.103 -> 10.0.0-preview.25406.102) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25401.103 -> 10.0.100-rc.1.25406.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25401.103 -> 10.0.0-beta.25406.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25401.103 -> 0.11.5-alpha.25406.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25401.103 -> 2.9.3-beta.25406.102) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25401.103 -> 10.0.0-rc.1.25406.102) Nuget.Frameworks, Nuget.Packaging, Nuget.ProjectModel, Nuget.Versioning (Version 6.2.4 -> 7.0.0-preview.1.102) System.CommandLine (Version 2.0.0-rc.1.25401.103 -> 2.0.0-rc.1.25406.102) * Resolve existing merge conflicts --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Djuradj Kurepa <dkurepa@microsoft.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com> Co-authored-by: Marek Fišera <mara@neptuo.com> Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>

* Fix few startup path issues with interpreter This change fixes the following issues: * Reverse pinvoke to method marked by UnmanagedCallersOnly attribute. The InterpExecMethod is entered in GC preemptive mode in that case, but it is expected to run in GC cooperative mode. * Pinvoke to method marked by SuppressGCTransition attribute . The pinvoke is entered in GC preemtive mode, but it needs to be called in GC cooperative mode. * Calling a delegate or a similar case when IL stub is used. The interpreter code is set only on the IL stub MethodDesc, but it needs to be set on both the IL stub and the original MethodDesc. * Check for the SuppressGCTransition in interpreter at compile time * PR feedback * Update src/coreclr/vm/prestub.cpp Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Update src/coreclr/vm/interpexec.cpp Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Undo INTOP_CALL_PINVOKE opcode size bump No longer needed after the previous commit * Fix build break --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Update JIT interface to help reduce shared stubs In order to reduce the need for shared stubs, we need some additional information for vararg signatures. * Remove canGetVarArgsHandle * Remove canGetCookieForPInvokeCalliSig

…8406) * [Interpreter] Intrinic handling for Delegate Invoke methods - Add a new opcode - Add a new invocation method. Note that this needs to have the same copy the CallStubHeader logic as calli, as the target is not consistent from use to use Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…18419)

…otnet#118370) Add diagnostic output when failing to read a R2R header or getting a bad image exception in parts of R2RDump initialization

dotnet#118497) - Fix virtual function resolution might not handle dispatch to a shared generic method if the exact type of the method is visible at compile time - Fix ldelema for an array of reference types doesn't handle shared generics properly - Fix issue where the readonly prefix for ldelema is ignored

* Update to zlib-ng 2.2.5 * Update zlib-ng hash + tag with release

This sequence should be handled as no-op

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

It was treating its inputs as 4 byte integers instead of 8 byte integers

…118445) * Fix rebuilding mono aot cross compiler when building locally This is a side-effect of the changes made in dotnet#109612. When we do rerun the offsets generation script locally it causes the file to be touched even if it's identical, which in turn causes the whole aot cross compiler binary to be rebuilt. To fix this only write to the output offsets file when it actually changed. * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tnet#118368) After we form the block op field indirs, run postorder local assertion prop on them, so that they see the same amount of assertion prop as other indirs. Fixes (parts of) dotnet#115789.

* Fix unhandled exception reporting corner cases There are several issues with processing exceptions that are not handled by managed code on Windows: * Sometimes the AppDomain.UnhandledException event is sent multiple times * Exception flowing to foreign native code is reported as unhandled even when it is actually caught by the native code * In rare cases, the unhandled exception stack trace is doubled This change fixes them by not reporting the unhandled exception in the SfiNext on Windows. It just raises the underlying SEH exception there with the thread marked so that the personality routines for the managed frames won't run the managed exception handling code. If the exception is truly unhandled, the `InternalUnhandledExceptionFilter_Worker` will be called by the unhandled exception filter installed for the process and report the exception as unhandled. If that exception ends up being caught by a foreign native code, then nothing will be reported. Close dotnet#115215 * Ensure AppDomain.CurrentDomain.UnhandledException occurs before finally

…18524)

…capabilities (dotnet#118512) * Initial plan * Update System.Numerics.Tensors PACKAGE.md to reflect current library capabilities Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> * Update src/libraries/System.Numerics.Tensors/src/PACKAGE.md Co-authored-by: Tanner Gooding <tagoo@outlook.com> * Fix trailing spaces in PACKAGE.md markdown linting issue Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Tanner Gooding <tagoo@outlook.com>

* Make cDAC pointer data initialize at compile-time * update StressLog to remove non-compile-time global

i.e. Fold: (-(x)) == 0 -> x == 0 arm64 asmdiffs Diffs are based on <span style="color:#1460aa">436,095</span> contexts (<span style="color:#1460aa">26,618</span> MinOpts, <span style="color:#1460aa">409,477</span> FullOpts). <details> <summary>Overall (<span style="color:green">-40</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|183,146,276|<span style="color:green">-40</span>|<span style="color:green">-0.09%</span>| |benchmarks.run.linux.arm64.checked.mch|21,285,888|+0|0.00%| |smoke_tests.nativeaot.linux.arm64.checked.mch|3,003,400|+0|0.00%| </div></details> <details> <summary>FullOpts (<span style="color:green">-40</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|168,630,412|<span style="color:green">-40</span>|<span style="color:green">-0.09%</span>| |benchmarks.run.linux.arm64.checked.mch|20,953,436|+0|0.00%| |smoke_tests.nativeaot.linux.arm64.checked.mch|3,001,776|+0|0.00%| </div></details> <details> <summary>Example diffs</summary> <div style="margin-left:1em"> <details> <summary>libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-1.27%</span>) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -53,8 +53,7 @@ G_M13215_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0001 {x0}, byre G_M13215_IG03: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 {}, byref, isz asr w2, w2, dotnet#31 lsl w2, w2, #1 - add w0, w2, w0, ASR dotnet#31 - negs w0, w0 + adds w0, w2, w0, ASR dotnet#31 bne G_M13215_IG04 movz x0, #0xD1FFAB1E movk x0, #0xD1FFAB1E LSL dotnet#16 @@ -76,7 +75,7 @@ G_M13215_IG03: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 mov x19, x0 ; gcrRegs +[x19] b G_M13215_IG05 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M13215_IG04: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcrRegs -[x0 x19-x20] mov x20, xzr @@ -179,7 +178,7 @@ G_M13215_IG13: ; bbWeight=0, gcrefRegs=580000 {x19 x20 x22}, byrefRegs=00 b G_M13215_IG06 ;; size=12 bbWeight=0 PerfScore 0.00 -; Total bytes of code 316, prolog size 16, PerfScore 140.93, instruction count 79, allocated bytes for code 316 (MethodHash=c6bccc60) for method System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) +; Total bytes of code 312, prolog size 16, PerfScore 140.68, instruction count 78, allocated bytes for code 312 (MethodHash=c6bccc60) for method System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) ; ============================================================ Unwind Info: @@ -190,7 +189,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 79 (0x0004f) Actual length = 316 (0x00013c) + Function Length : 78 (0x0004e) Actual length = 312 (0x000138) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.27%</span>) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -531,10 +531,9 @@ G_M17523_IG25: ; bbWeight=1, gcrefRegs=400002 {x1 x22}, byrefRegs=0000 {} G_M17523_IG26: ; bbWeight=0.50, gcrefRegs=80002 {x1 x19}, byrefRegs=0000 {}, byref, isz asr w0, w0, dotnet#31 lsl w0, w0, #1 - add w0, w0, w2, ASR dotnet#31 - negs w0, w0 + adds w0, w0, w2, ASR dotnet#31 beq G_M17523_IG29 - ;; size=20 bbWeight=0.50 PerfScore 2.25 + ;; size=16 bbWeight=0.50 PerfScore 2.00 G_M17523_IG27: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcrRegs -[x1 x19] mov w19, wzr @@ -733,7 +732,7 @@ G_M17523_IG43: ; bbWeight=0.00, gcrefRegs=0001 {x0}, byrefRegs=0000 {}, b brk #0 ;; size=32 bbWeight=0.00 PerfScore 0.00 -; Total bytes of code 1488, prolog size 36, PerfScore 200.96, instruction count 372, allocated bytes for code 1488 (MethodHash=abb9bb8c) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) +; Total bytes of code 1484, prolog size 36, PerfScore 200.71, instruction count 371, allocated bytes for code 1484 (MethodHash=abb9bb8c) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) ; ============================================================ Unwind Info: @@ -744,7 +743,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 372 (0x00174) Actual length = 1488 (0x0005d0) + Function Length : 371 (0x00173) Actual length = 1484 (0x0005cc) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.26%</span>) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -208,7 +208,7 @@ ; V197 cse1 [V197,T40] ( 2, 1 ) ref -> x0 "CSE #7: moderate" ; V198 cse2 [V198,T44] ( 2, 1 ) int -> x23 "CSE #4: moderate" ; V199 cse3 [V199,T45] ( 2, 1 ) long -> x1 "CSE #5: moderate" -; V200 cse4 [V200,T33] ( 3, 1.50) int -> x1 "CSE dotnet#17: moderate" +; V200 cse4 [V200,T33] ( 3, 1.50) int -> x1 "CSE dotnet#16: moderate" ; V201 rat0 [V201,T01] ( 3, 5.62) byref -> x1 "fgMakeTemp is creating a new local variable" ; V202 rat1 [V202,T07] ( 5, 3.75) ref -> x0 "replacement local" ; V203 rat2 [V203,T37] ( 3, 1.25) long -> x2 "CSE for expectedClsNode" @@ -623,8 +623,7 @@ G_M55449_IG30: ; bbWeight=1, gcrefRegs=4180002 {x1 x19 x20 x26}, byrefReg G_M55449_IG31: ; bbWeight=0.50, gcrefRegs=180000 {x19 x20}, byrefRegs=0000 {}, byref, isz asr w1, w21, dotnet#31 lsl w1, w1, #1 - add w1, w1, w22, ASR dotnet#31 - negs w1, w1 + adds w1, w1, w22, ASR dotnet#31 bne G_M55449_IG32 mov x1, x19 ; gcrRegs +[x1] @@ -642,7 +641,7 @@ G_M55449_IG31: ; bbWeight=0.50, gcrefRegs=180000 {x19 x20}, byrefRegs=000 ; gcrRegs -[x1 x20] mov w20, #1 b G_M55449_IG33 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M55449_IG32: ; bbWeight=0.50, gcrefRegs=80000 {x19}, byrefRegs=0000 {}, byref mov w20, wzr ;; size=4 bbWeight=0.50 PerfScore 0.25 @@ -776,7 +775,7 @@ G_M55449_IG46: ; bbWeight=0, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref brk #0 ;; size=40 bbWeight=0 PerfScore 0.00 -; Total bytes of code 1516, prolog size 48, PerfScore 174.78, instruction count 379, allocated bytes for code 1516 (MethodHash=a4562766) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) +; Total bytes of code 1512, prolog size 48, PerfScore 174.53, instruction count 378, allocated bytes for code 1512 (MethodHash=a4562766) for method System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) ; ============================================================ Unwind Info: @@ -787,7 +786,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 379 (0x0017b) Actual length = 1516 (0x0005ec) + Function Length : 378 (0x0017a) Actual length = 1512 (0x0005e8) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary>+0 (0.00%) : 223365.dasm - System.Resources.Extensions.DeserializingResourceReader:CompareStringEqualsName(System.String):bool:this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -106,7 +106,7 @@ G_M52056_IG05: ; bbWeight=0.50, gcrefRegs=500000 {x20 x22}, byrefRegs=000 ldr x3, [x3] blr x3 ; gcrRegs -[x0-x1 x20 x22] - negs w0, w0 + cmp w0, #0 cset x0, eq ;; size=40 bbWeight=0.50 PerfScore 4.25 G_M52056_IG06: ; bbWeight=0.50, epilog, nogc, extend ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.02%</span>) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -3678,8 +3678,7 @@ G_M43941_IG97: ; bbWeight=1, gcVars=0000000000000000000000000000000000000 G_M43941_IG98: ; bbWeight=4, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, byrefRegs=0000 {}, byref, isz ldr w1, [x2, #0x08] ldr w0, [fp, #0xD1FFAB1E] // [V74 tmp49] - sub w1, w0, w1 - negs w1, w1 + subs w1, w0, w1 beq G_M43941_IG90 ldp w0, w1, [x22, #0x10] add w1, w1, #1 @@ -3688,7 +3687,7 @@ G_M43941_IG98: ; bbWeight=4, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, ldr w1, [x2, #0x08] cmp w1, w0 bls G_M43941_IG100 - ;; size=48 bbWeight=4 PerfScore 76.00 + ;; size=44 bbWeight=4 PerfScore 74.00 G_M43941_IG99: ; bbWeight=3.03, gcVars=00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002 {V06}, gcrefRegs=4780004 {x2 x19 x20 x21 x22 x26}, byrefRegs=0000 {}, gcvars, byref ; GC ptr vars -{V75} add w1, w0, #1 @@ -7803,7 +7802,7 @@ RWD00 dq 00740053002D0031h, 0067006E00690072h RWD16 dq 007200740053002Dh, 00310067006E0069h -; Total bytes of code 18184, prolog size 44, PerfScore 10435.99, instruction count 4546, allocated bytes for code 18184 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) +; Total bytes of code 18180, prolog size 44, PerfScore 10433.99, instruction count 4545, allocated bytes for code 18180 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) ; ============================================================ Unwind Info: @@ -7814,7 +7813,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 4130 (0x01022) Actual length = 16520 (0x004088) + Function Length : 4129 (0x01021) Actual length = 16516 (0x004084) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.16%</span>) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -595,8 +595,7 @@ G_M36412_IG24: ; bbWeight=1, gcrefRegs=B80000 {x19 x20 x21 x23}, byrefReg G_M36412_IG25: ; bbWeight=0.50, gcrefRegs=B80000 {x19 x20 x21 x23}, byrefRegs=0000 {}, byref, isz asr w1, w24, dotnet#31 lsl w1, w1, #1 - add w1, w1, w25, ASR dotnet#31 - negs w1, w1 + adds w1, w1, w25, ASR dotnet#31 bne G_M36412_IG26 mov x1, x20 ; gcrRegs +[x1] @@ -618,7 +617,7 @@ G_M36412_IG25: ; bbWeight=0.50, gcrefRegs=B80000 {x19 x20 x21 x23}, byref ; gcrRegs -[x1] +[x0] ; gcr arg pop 0 b G_M36412_IG27 - ;; size=68 bbWeight=0.50 PerfScore 6.00 + ;; size=64 bbWeight=0.50 PerfScore 5.75 G_M36412_IG26: ; bbWeight=0.50, gcrefRegs=A80000 {x19 x21 x23}, byrefRegs=0000 {}, byref ; gcrRegs -[x0 x20] mov x20, xzr @@ -1232,7 +1231,7 @@ RWD16 dq <unknown method> dq G_M36412_IG51 -; Total bytes of code 2528, prolog size 48, PerfScore 347.37, instruction count 632, allocated bytes for code 2528 (MethodHash=f7d471c3) for method System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) +; Total bytes of code 2524, prolog size 48, PerfScore 347.12, instruction count 631, allocated bytes for code 2524 (MethodHash=f7d471c3) for method System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) ; ============================================================ Unwind Info: @@ -1243,7 +1242,7 @@ Unwind Info: E bit : 0 X bit : 0 Vers : 0 - Function Length : 591 (0x0024f) Actual length = 2364 (0x00093c) + Function Length : 590 (0x0024e) Actual length = 2360 (0x000938) ---- Epilog scopes ---- ---- Scope 0 Epilog Start Offset : 3523193630 (0xd1ffab1e) Actual offset = 3523193630 (0xd1ffab1e) Offset from main function begin = 3523193630 (0xd1ffab1e) ``` </div></details> </div></details> <details> <summary>benchmarks.run.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary>+0 (0.00%) : 3177.dasm - System.Resources.ResourceReader:CompareStringEqualsName(System.String):bool:this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -106,7 +106,7 @@ G_M1070_IG05: ; bbWeight=0.50, gcrefRegs=500000 {x20 x22}, byrefRegs=0000 ldr x3, [x3] blr x3 ; gcrRegs -[x0-x1 x20 x22] - negs w0, w0 + cmp w0, #0 cset x0, eq ;; size=40 bbWeight=0.50 PerfScore 4.25 G_M1070_IG06: ; bbWeight=0.50, epilog, nogc, extend ``` </div></details> </div></details> <details> <summary>smoke_tests.nativeaot.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary>+0 (0.00%) : 18583.dasm - Generics+TestAsyncGVMScenarios:RunAsync() (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18730.dasm - Generics+TestAsyncGVMScenarios:AsyncGvm1[System.__Canon]():this (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18865.dasm - Generics+TestAsyncGVMScenarios:AsyncGvm2[System.__Canon]():this (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> <details> <summary>+0 (0.00%) : 18873.dasm - System.Threading.Tasks.Task:get_CompletedTask() (FullOpts)</summary> <div style="margin-left:1em"> No diffs found? </div></details> </div></details> </div></details> <details> <summary>Details</summary> <div style="margin-left:1em"> #### Size improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same size|Improvements (bytes)|Regressions (bytes)| |---|--:|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|11|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-40</span>|<span style="color:red">+0</span>| |benchmarks.run.linux.arm64.checked.mch|1|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |smoke_tests.nativeaot.linux.arm64.checked.mch|4|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">4</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| ||16|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">6</span>|<span style="color:green">-40</span>|<span style="color:red">+0</span>| --- #### PerfScore improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same PerfScore|Improvements (PerfScore)|Regressions (PerfScore)|PerfScore Overall in FullOpts| |---|--:|--:|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|11|<span style="color:green">10</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|<span style="color:green">-0.10%</span>|0.00%|<span style="color:green">-0.0000%</span>| |benchmarks.run.linux.arm64.checked.mch|1|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">1</span>|0.00%|0.00%|0.0000%| |smoke_tests.nativeaot.linux.arm64.checked.mch|4|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">4</span>|0.00%|0.00%|0.0000%| --- #### Context information |Collection|Diffed contexts|MinOpts|FullOpts|Missed, base|Missed, diff| |---|--:|--:|--:|--:|--:| |libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch|354,001|23,273|330,728|0 (0.00%)|0 (0.00%)| |benchmarks.run.linux.arm64.checked.mch|63,204|3,337|59,867|0 (0.00%)|0 (0.00%)| |smoke_tests.nativeaot.linux.arm64.checked.mch|18,890|8|18,882|0 (0.00%)|0 (0.00%)| ||436,095|26,618|409,477|0 (0.00%)|0 (0.00%)| --- #### jit-analyze output <details> <summary>libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch</summary> <div style="margin-left:1em"> ``` Summary of Code Size diffs: (Lower is better) Total bytes of base: 183146276 (overridden on cmd) Total bytes of diff: 183146236 (overridden on cmd) Total bytes of delta: -40 (-0.00 % of base) diff is an improvement. relative diff is an improvement. ``` <details> <summary>Detail diffs</summary> ``` Top file improvements (bytes): -4 : 162916.dasm (-0.242% of base) -4 : 141852.dasm (-0.162% of base) -4 : 141855.dasm (-0.158% of base) -4 : 141861.dasm (-0.201% of base) -4 : 162917.dasm (-0.269% of base) -4 : 142473.dasm (-1.266% of base) -4 : 142389.dasm (-0.182% of base) -4 : 162915.dasm (-0.264% of base) -4 : 162918.dasm (-0.185% of base) -4 : 106573.dasm (-0.022% of base) 10 total files with Code Size differences (10 improved, 0 regressed), 1 unchanged. Top method improvements (bytes): -4 (-0.022% of base) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) -4 (-1.266% of base) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) -4 (-0.182% of base) : 142389.dasm - System.IO.Pipelines.Tests.PipelineReaderWriterFacts:ResetAfterCompleteReaderAndWriterWithoutAdvancingClearsEverything():this (FullOpts) -4 (-0.162% of base) : 141852.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryAtMaxPoolSizeAllocatesFromPool():this (FullOpts) -4 (-0.158% of base) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) -4 (-0.201% of base) : 141861.dasm - System.IO.Pipelines.Tests.PipePoolTests:WritesToArrayPoolByDefault():this (FullOpts) -4 (-0.242% of base) : 162916.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_MultiBlock():this (FullOpts) -4 (-0.185% of base) : 162918.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_SingleBlock():this (FullOpts) -4 (-0.264% of base) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) -4 (-0.269% of base) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) Top method improvements (percentages): -4 (-1.266% of base) : 142473.dasm - System.IO.Pipelines.Tests.BufferSegmentPoolTest:GetSegments(System.IO.Pipelines.ReadResult):System.Collections.Generic.List`1[System.Buffers.ReadOnlySequenceSegment`1[byte]] (FullOpts) -4 (-0.269% of base) : 162917.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory():this (FullOpts) -4 (-0.264% of base) : 162915.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_Memory_String():this (FullOpts) -4 (-0.242% of base) : 162916.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_MultiBlock():this (FullOpts) -4 (-0.201% of base) : 141861.dasm - System.IO.Pipelines.Tests.PipePoolTests:WritesToArrayPoolByDefault():this (FullOpts) -4 (-0.185% of base) : 162918.dasm - System.Memory.Tests.ReadOnlySequenceTryGetTests:Ctor_IMemoryList_SingleBlock():this (FullOpts) -4 (-0.182% of base) : 142389.dasm - System.IO.Pipelines.Tests.PipelineReaderWriterFacts:ResetAfterCompleteReaderAndWriterWithoutAdvancingClearsEverything():this (FullOpts) -4 (-0.162% of base) : 141852.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryAtMaxPoolSizeAllocatesFromPool():this (FullOpts) -4 (-0.158% of base) : 141855.dasm - System.IO.Pipelines.Tests.PipePoolTests:GetMemoryOverMaxPoolSizeAllocatesArray():this (FullOpts) -4 (-0.022% of base) : 106573.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) 10 total methods with Code Size differences (10 improved, 0 regressed). ``` </details> -------------------------------------------------------------------------------- </div></details> <details> <summary>benchmarks.run.linux.arm64.checked.mch</summary> <div style="margin-left:1em"> ``` Summary of Code Size diffs: (Lower is better) Total bytes of base: 21285888 (overridden on cmd) Total bytes of diff: 21285888 (overridden on cmd) Total bytes of delta: 0 (0.00 % of base) ``` <details> <summary>Detail diffs</summary> ``` 0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged. 0 total methods with Code Size differences (0 improved, 0 regressed). ``` </details> -------------------------------------------------------------------------------- </div></details> </div></details> x64 asmdiffs Diffs are based on <span style="color:#1460aa">2,787,549</span> contexts (<span style="color:#1460aa">1,078,277</span> MinOpts, <span style="color:#1460aa">1,709,272</span> FullOpts). <details> <summary>Overall (<span style="color:green">-116</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|305,501,642|<span style="color:green">-110</span>|<span style="color:green">-14.87%</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|157,729,192|<span style="color:green">-2</span>|<span style="color:green">-0.01%</span>| |libraries_tests.run.linux.x64.Release.mch|392,784,680|<span style="color:green">-4</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>MinOpts (<span style="color:green">-14</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|197,469,852|<span style="color:green">-10</span>|<span style="color:green">-1.28%</span>| |libraries_tests.run.linux.x64.Release.mch|215,792,030|<span style="color:green">-4</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>FullOpts (<span style="color:green">-102</span> bytes)</summary> <div style="margin-left:1em"> |Collection|Base size (bytes)|Diff size (bytes)|PerfScore in Diffs |---|--:|--:|--:| |coreclr_tests.run.linux.x64.checked.mch|108,031,790|<span style="color:green">-100</span>|<span style="color:green">-16.74%</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|146,383,976|<span style="color:green">-2</span>|<span style="color:green">-0.01%</span>| </div></details> <details> <summary>Example diffs</summary> <div style="margin-left:1em"> <details> <summary>coreclr_tests.run.linux.x64.checked.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-8</span> (<span style="color:green">-29.63%</span>) : 199901.dasm - TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -18,23 +18,19 @@ G_M18888_IG01: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, ;; size=0 bbWeight=1 PerfScore 0.00 G_M18888_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref sar edi, 1 - mov eax, edi - neg eax setne al movzx rax, al - add esi, esi - mov ecx, esi - neg ecx + shl esi, 1 setne cl movzx rcx, cl or eax, ecx - ;; size=26 bbWeight=1 PerfScore 4.50 + ;; size=18 bbWeight=1 PerfScore 3.75 G_M18888_IG03: ; bbWeight=1, epilog, nogc, extend ret ;; size=1 bbWeight=1 PerfScore 1.00 ; END METHOD TestNeg.Program:NegsBinOpSingleLine(int,int):bool -; Total bytes of code 27, prolog size 0, PerfScore 5.50, instruction count 12, allocated bytes for code 27 (MethodHash=d08ab637) for method TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts) +; Total bytes of code 19, prolog size 0, PerfScore 4.75, instruction count 8, allocated bytes for code 19 (MethodHash=d08ab637) for method TestNeg.Program:NegsBinOpSingleLine(int,int):bool (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-7</span> (<span style="color:green">-29.17%</span>) : 199894.dasm - TestNeg.Program:NegsLSR(uint):int (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -16,20 +16,17 @@ G_M6300_IG01: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, nogc <-- Prolog IG ;; size=0 bbWeight=0.50 PerfScore 0.00 G_M6300_IG02: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref + mov eax, -1 + mov ecx, 1 shr edi, 3 - mov eax, edi - mov ecx, -1 - mov edx, 1 - neg rax - mov eax, edx - cmove eax, ecx - ;; size=23 bbWeight=0.50 PerfScore 1.00 + cmovne eax, ecx + ;; size=16 bbWeight=0.50 PerfScore 0.62 G_M6300_IG03: ; bbWeight=0.50, epilog, nogc, extend ret ;; size=1 bbWeight=0.50 PerfScore 0.50 ; END METHOD TestNeg.Program:NegsLSR(uint):int -; Total bytes of code 24, prolog size 0, PerfScore 1.50, instruction count 8, allocated bytes for code 24 (MethodHash=2a8ee763) for method TestNeg.Program:NegsLSR(uint):int (FullOpts) +; Total bytes of code 17, prolog size 0, PerfScore 1.12, instruction count 5, allocated bytes for code 17 (MethodHash=2a8ee763) for method TestNeg.Program:NegsLSR(uint):int (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-7</span> (<span style="color:green">-29.17%</span>) : 199896.dasm - TestNeg.Program:NegsLargeShift(uint):int (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -16,20 +16,17 @@ G_M11276_IG01: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, nogc <-- Prolog IG ;; size=0 bbWeight=0.50 PerfScore 0.00 G_M11276_IG02: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref + mov eax, -1 + mov ecx, 1 shl edi, 4 - mov eax, edi - mov ecx, -1 - mov edx, 1 - neg rax - mov eax, edx - cmove eax, ecx - ;; size=23 bbWeight=0.50 PerfScore 1.00 + cmovne eax, ecx + ;; size=16 bbWeight=0.50 PerfScore 0.62 G_M11276_IG03: ; bbWeight=0.50, epilog, nogc, extend ret ;; size=1 bbWeight=0.50 PerfScore 0.50 ; END METHOD TestNeg.Program:NegsLargeShift(uint):int -; Total bytes of code 24, prolog size 0, PerfScore 1.50, instruction count 8, allocated bytes for code 24 (MethodHash=43eed3f3) for method TestNeg.Program:NegsLargeShift(uint):int (FullOpts) +; Total bytes of code 17, prolog size 0, PerfScore 1.12, instruction count 5, allocated bytes for code 17 (MethodHash=43eed3f3) for method TestNeg.Program:NegsLargeShift(uint):int (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-5</span> (<span style="color:green">-1.71%</span>) : 531325.dasm - ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0)</summary> <div style="margin-left:1em"> ```diff @@ -74,16 +74,14 @@ G_M28265_IG02: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, mov qword ptr [rbp-0x40], rdx mov rax, qword ptr [rbp-0x40] mov qword ptr [rbp-0x48], rax - mov eax, dword ptr [rbp-0x28] - neg rax - test rax, rax + cmp dword ptr [rbp-0x28], 0 jne SHORT G_M28265_IG03 mov eax, dword ptr [rbp-0x18] cmp eax, 255 ja SHORT G_M28265_IG06 mov eax, eax mov byte ptr [rbp-0x04], al - ;; size=182 bbWeight=1 PerfScore 117.08 + ;; size=177 bbWeight=1 PerfScore 117.58 G_M28265_IG03: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, isz mov eax, dword ptr [rbp-0x10] cmp rax, qword ptr [rbp-0x48] @@ -116,7 +114,7 @@ RWD16 dq 8000000000000000h ; -0 RWD24 dd 4F0BD98Fh ; 2.34629e+09 -; Total bytes of code 293, prolog size 31, PerfScore 147.42, instruction count 75, allocated bytes for code 293 (MethodHash=d26f9196) for method ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0) +; Total bytes of code 288, prolog size 31, PerfScore 147.92, instruction count 73, allocated bytes for code 288 (MethodHash=d26f9196) for method ILGEN_CLASS:ILGEN_METHOD(bool,char,short,int):char (Tier0) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-2</span> (<span style="color:green">-4.17%</span>) : 181410.dasm - ldc_neg_i4._neg:i4_3(int,int):int (MinOpts)</summary> <div style="margin-left:1em"> ```diff @@ -30,18 +30,17 @@ G_M1458_IG03: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byre ;; size=5 bbWeight=0.50 PerfScore 0.50 G_M1458_IG04: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref xor eax, eax - neg eax test eax, eax sete al movzx rax, al - ;; size=12 bbWeight=1 PerfScore 2.00 + ;; size=10 bbWeight=1 PerfScore 1.75 G_M1458_IG05: ; bbWeight=1, epilog, nogc, extend add rsp, 16 pop rbp ret ;; size=6 bbWeight=1 PerfScore 1.75 -; Total bytes of code 48, prolog size 16, PerfScore 12.00, instruction count 16, allocated bytes for code 48 (MethodHash=0125fa4d) for method ldc_neg_i4._neg:i4_3(int,int):int (MinOpts) +; Total bytes of code 46, prolog size 16, PerfScore 11.75, instruction count 15, allocated bytes for code 46 (MethodHash=0125fa4d) for method ldc_neg_i4._neg:i4_3(int,int):int (MinOpts) ; ============================================================ Unwind Info: ``` </div></details> <details> <summary><span style="color:green">-3</span> (<span style="color:green">-5.77%</span>) : 181421.dasm - ldc_neg_i8._neg:i8_3(long,long):int (MinOpts)</summary> <div style="margin-left:1em"> ```diff @@ -30,18 +30,17 @@ G_M18290_IG03: ; bbWeight=0.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, byr ;; size=5 bbWeight=0.50 PerfScore 0.50 G_M18290_IG04: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref xor eax, eax - neg rax test rax, rax sete al movzx rax, al - ;; size=14 bbWeight=1 PerfScore 2.00 + ;; size=11 bbWeight=1 PerfScore 1.75 G_M18290_IG05: ; bbWeight=1, epilog, nogc, extend add rsp, 16 pop rbp ret ;; size=6 bbWeight=1 PerfScore 1.75 -; Total bytes of code 52, prolog size 18, PerfScore 12.00, instruction count 16, allocated bytes for code 52 (MethodHash=ff46b88d) for method ldc_neg_i8._neg:i8_3(long,long):int (MinOpts) +; Total bytes of code 49, prolog size 18, PerfScore 11.75, instruction count 15, allocated bytes for code 49 (MethodHash=ff46b88d) for method ldc_neg_i8._neg:i8_3(long,long):int (MinOpts) ; ============================================================ Unwind Info: ``` </div></details> </div></details> <details> <summary>libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-2</span> (<span style="color:green">-0.01%</span>) : 124444.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts)</summary> <div style="margin-left:1em"> ```diff @@ -3246,7 +3246,6 @@ G_M43941_IG102: ; bbWeight=1, gcVars=000000000000000000000000000000000000 G_M43941_IG103: ; bbWeight=4, gcrefRegs=F009 {rax rbx r12 r13 r14 r15}, byrefRegs=0000 {}, byref, isz mov esi, dword ptr [rbp-0x30] sub esi, dword ptr [rax+0x08] - neg esi je G_M43941_IG96 inc dword ptr [r13+0x14] mov rdi, gword ptr [r13+0x08] @@ -3254,7 +3253,7 @@ G_M43941_IG103: ; bbWeight=4, gcrefRegs=F009 {rax rbx r12 r13 r14 r15}, b mov esi, dword ptr [r13+0x10] cmp dword ptr [rdi+0x08], esi jbe SHORT G_M43941_IG106 - ;; size=31 bbWeight=4 PerfScore 65.00 + ;; size=29 bbWeight=4 PerfScore 64.00 G_M43941_IG104: ; bbWeight=3.05, gcVars=00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002 {V06}, gcrefRegs=F088 {rbx rdi r12 r13 r14 r15}, byrefRegs=0000 {}, gcvars, byref ; gcrRegs -[rax] ; GC ptr vars -{V75} @@ -6658,7 +6657,7 @@ RWD40 dq 4034000000000000h ; 20 RWD48 dq 4039000000000000h ; 25 -; Total bytes of code 14316, prolog size 28, PerfScore 7866.28, instruction count 3034, allocated bytes for code 14316 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) +; Total bytes of code 14314, prolog size 28, PerfScore 7865.28, instruction count 3033, allocated bytes for code 14314 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (FullOpts) ; ============================================================ Unwind Info: ``` </div></details> </div></details> <details> <summary>libraries_tests.run.linux.x64.Release.mch</summary> <div style="margin-left:1em"> <details> <summary><span style="color:green">-4</span> (<span style="color:green">-0.03%</span>) : 314396.dasm - System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0)</summary> <div style="margin-left:1em"> ```diff @@ -2199,13 +2199,11 @@ G_M43941_IG57: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref ; gcr arg pop 0 mov ecx, dword ptr [rbp-0x240] sub ecx, dword ptr [rax] - mov eax, ecx - ; byrRegs -[rax] - neg eax - test eax, eax + test ecx, ecx je G_M43941_IG56 mov rdi, 0xD1FFAB1E call CORINFO_HELP_COUNTPROFILE32 + ; byrRegs -[rax] ; gcr arg pop 0 mov rdi, gword ptr [rbp-0x50] ; gcrRegs +[rdi] @@ -2215,7 +2213,7 @@ G_M43941_IG57: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref call [<unknown method>] ; gcrRegs -[rsi rdi] ; gcr arg pop 0 - ;; size=309 bbWeight=1 PerfScore 58.00 + ;; size=305 bbWeight=1 PerfScore 57.50 G_M43941_IG58: ; bbWeight=1, gcrefRegs=0000 {}, byrefRegs=0000 {}, byref, isz mov eax, dword ptr [rbp-0x5E0] dec eax @@ -5412,7 +5410,7 @@ RWD08 dq 4034000000000000h ; 20 RWD16 dq 4039000000000000h ; 25 -; Total bytes of code 15982, prolog size 67, PerfScore 3425.70, instruction count 2755, allocated bytes for code 15982 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0) +; Total bytes of code 15978, prolog size 67, PerfScore 3425.20, instruction count 2753, allocated bytes for code 15978 (MethodHash=c958545a) for method System.Data.Tests.DataTableTest2:Select_ByFilter():this (Instrumented Tier0) ; ============================================================ Unwind Info: ``` </div></details> </div></details> </div></details> <details> <summary>Details</summary> <div style="margin-left:1em"> #### Size improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same size|Improvements (bytes)|Regressions (bytes)| |---|--:|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |benchmarks.run_pgo.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |coreclr_tests.run.linux.x64.checked.mch|23|<span style="color:green">23</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-110</span>|<span style="color:red">+0</span>| |libraries.crossgen2.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |libraries.pmi.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-2</span>|<span style="color:red">+0</span>| |libraries_tests.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-4</span>|<span style="color:red">+0</span>| |realworld.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| |smoke_tests.nativeaot.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0</span>|<span style="color:red">+0</span>| ||25|<span style="color:green">25</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-116</span>|<span style="color:red">+0</span>| --- #### PerfScore improvements/regressions per collection |Collection|Contexts with diffs|Improvements|Regressions|Same PerfScore|Improvements (PerfScore)|Regressions (PerfScore)|PerfScore Overall in FullOpts| |---|--:|--:|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |benchmarks.run_pgo.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |coreclr_tests.run.linux.x64.checked.mch|23|<span style="color:green">22</span>|<span style="color:red">1</span>|<span style="color:blue">0</span>|<span style="color:green">-15.50%</span>|<span style="color:red">+0.34%</span>|<span style="color:green">-0.0017%</span>| |libraries.crossgen2.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |libraries.pmi.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0.01%</span>|0.00%|<span style="color:green">-0.0000%</span>| |libraries_tests.run.linux.x64.Release.mch|1|<span style="color:green">1</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|<span style="color:green">-0.01%</span>|0.00%|0.0000%| |realworld.run.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| |smoke_tests.nativeaot.linux.x64.checked.mch|0|<span style="color:green">0</span>|<span style="color:red">0</span>|<span style="color:blue">0</span>|0.00%|0.00%|0.0000%| --- #### Context information |Collection|Diffed contexts|MinOpts|FullOpts|Missed, base|Missed, diff| |---|--:|--:|--:|--:|--:| |benchmarks.run.linux.x64.checked.mch|75,913|2,972|72,941|0 (0.00%)|0 (0.00%)| |benchmarks.run_pgo.linux.x64.checked.mch|122,785|86,206|36,579|0 (0.00%)|0 (0.00%)| |benchmarks.run_pgo_optrepeat.linux.x64.checked.mch|76,998|2,939|74,059|0 (0.00%)|0 (0.00%)| |coreclr_tests.run.linux.x64.checked.mch|577,098|358,595|218,503|0 (0.00%)|0 (0.00%)| |libraries.crossgen2.linux.x64.checked.mch|269,385|20|269,365|0 (0.00%)|0 (0.00%)| |libraries.pmi.linux.x64.checked.mch|354,706|8|354,698|0 (0.00%)|0 (0.00%)| |libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch|387,764|23,607|364,157|0 (0.00%)|0 (0.00%)| |libraries_tests.run.linux.x64.Release.mch|862,114|603,896|258,218|0 (0.00%)|0 (0.00%)| |realworld.run.linux.x64.checked.mch|29,264|21|29,243|0 (0.00%)|0 (0.00%)| |smoke_tests.nativeaot.linux.x64.checked.mch|31,522|13|31,509|0 (0.00%)|0 (0.00%)| ||2,787,549|1,078,277|1,709,272|0 (0.00%)|0 (0.00%)| --- #### jit-analyze output </div></details>

These are pretty boring, but adding them adds more testing opportunities for #4 since these all have a blob that #4 should be able to parse/rewrite.

@tlakollo

Introduces common helpers to rewrite and analyze signatures. Local variable signatures are analyzed & rewritten in the first commit. The second commit shows how are we going to hook up the other kinds of signatures into the common code since all signatures somehow deal with encoding types and we don't want to duplicate that code. I hooked it up into MethodDefinition and MemberReference. The third commit enables @tlakollo's disabled test since we now support it. Fixes #4.

max-charlamb force-pushed the cdac-symbol-reading-3 branch 3 times, most recently from 04ea4de to dc87671 Compare May 6, 2025 15:27

max-charlamb force-pushed the cdac-symbol-reading-3 branch from dafb77a to 33631e7 Compare May 15, 2025 23:38

vcsjones and others added 26 commits July 23, 2025 21:42

Remove ExperimentalAttribute from ML-KEM where applicable

1766659

Check DOTNET_HOST_* for host (COREHOST_*) tracing environment variabl…

7195086

…es (dotnet#117894) Respect the `DOTNET_` prefix for `COREHOST_` environment variables as a move toward greater consistency for .NET environment variables

Lock over the same object to serialize access to the buffers (dotnet#…

5c4ebcc

…117982)

Expand set of known header names and values (dotnet#117989)

831523d

* Collection expressions for known values * Simplify new() * Expand set of known header names and values * Also add text/plain without a space

[browser] Check also corePdb to see if we have any pdb to start debug…

d7f58ab

…ging (dotnet#117978)

Update mentionees for apple mobile (dotnet#118016)

92f6dec

Platform dependency doc changes (dotnet#118024)

3cd8c22

* Delete "Submitting Changes" section

arm64: Add remaining Sve2 Saturating functions (dotnet#117934)

22a2c4d

Make IsAlive test reliable and re-enable it for crossgen2 (dotnet#117987

45f7fc4

) * Make IsAlive test reliable and re-enable it for crossgen2 Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

[PERF] Add release/10.0 to trigger branches in perf.yml (dotnet#117994)

e69e2b3

Adding GetClrNotification cDAC API (dotnet#117737)

078f8ca

* Adding GetClrNotification cDAC API

Support auto-atomicity on {lazy} loops (dotnet#117943)

c0f4c7d

Today we only support conversion of loops to atomic loops for single-character loops (e.g. a* or [abc]*). This PR augments the logic to support arbitrary loops, enabling many more loops to become atomic.

[APX] Enable APX-EVEX.ZU for SETcc instructions (dotnet#117258)

dd7a848

Unquote primitive string values in JsonNode.ToString() (dotnet#117993)

9e82819

Remove lifetime2 test and remove its crossgen2 test exclusion (dotnet…

2a7789d

…#117995) Remove JIT/directed/lifetime/lifetime2 test because it is unreliable by construction

Emit IsAotCompatible attribute metadata (dotnet#118008)

9da102b

This could be used for dotnet#117712 and is a useful piece of metadata. I was going back and forth between placing this here or somewhere in the dotnet/sdk repo but since this is related to the analyzer, it feels okay here too.

skip validation in internal method desc fetching

2c76e74

Merge remote-tracking branch 'origin/main' into cdac-symbol-reading-3

bbb75c5

Move RuntimeAsync ifdef to env variable (dotnet#118011)

1e860a4

davidwrighton and others added 25 commits August 7, 2025 10:09

Make host tests clear out host tracing variables by default (dotnet#1…

66519b1

…18419)

Update RapidJSON (dotnet#118432)

ca9b916

Diagnostic changes to R2R for issues dotnet#106675 and dotnet#108255 (d…

dc00334

…otnet#118370) Add diagnostic output when failing to read a R2R header or getting a bad image exception in parts of R2RDump initialization

Update to zlib-ng 2.2.5 (dotnet#118457)

c2e7c99

* Update to zlib-ng 2.2.5 * Update zlib-ng hash + tag with release

Eliminate NextCallReturnAddress call followed by CEE_POP (dotnet#118500)

96b3285

This sequence should be handled as no-op

[clr-interp] Handle some forms of unboxing stub (dotnet#118501)

d61ca90

When encountering an UnboxingStub to execute, invoke it as a compiled method instead of as a interpreted one

Remove mentions of long removed function. (dotnet#118509)

a53ffc1

[clr-interp] Fix INTOP_CGT_UN_I8 (dotnet#118511)

4bbd32d

It was treating its inputs as 4 byte integers instead of 8 byte integers

JIT: postorder local assertion prop for fieldwise block op indirs (do…

bbe64d0

…tnet#118368) After we form the block op field indirs, run postorder local assertion prop on them, so that they see the same amount of assertion prop as other indirs. Fixes (parts of) dotnet#115789.

SPMI: Assert map exists in repGetCookieForPInvokeCalliSig (dotnet#1…

19e2ae0

…18524)

[cDAC] Change pointer data to be compile-time constant (dotnet#118543)

e22ee70

* Make cDAC pointer data initialize at compile-time * update StressLog to remove non-compile-time global

Merge branch 'main' into cdac-symbol-reading-3

3d2665f

fix issue with properly reporting method instances

0a558fa

fix

ec33a87

fix DAC returning incorrect status code and match behavior in cDAC

e5b1ba8

resolve errors around unused variables

2a7cbc3

max-charlamb closed this Aug 20, 2025

max-charlamb deleted the cdac-symbol-reading-3 branch August 20, 2025 13:42

max-charlamb pushed a commit that referenced this pull request Apr 14, 2026

Add TypeSpecification and MethodSpecification (dotnet#21)

6742b60

These are pretty boring, but adding them adds more testing opportunities for #4 since these all have a blob that #4 should be able to parse/rewrite.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cdac symbol reading 3#4

Cdac symbol reading 3#4
max-charlamb wants to merge 1427 commits intocdac-symbol-reading-2from
cdac-symbol-reading-3

max-charlamb commented May 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

max-charlamb commented May 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants