-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[WIP] Update ieeg data example for ECoG #7768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@larsoner I am trying to update the download path accordingly like you suggested, but I get this error: Any suggestions? |
|
This example might give us a reason to look into sphinx-gallery/sphinx-gallery#150 |
|
Renders okay, so data downloading etc. works. No animation for now but it at least captures the figure: You should be good to keep developing now @adam2392 |
|
I'm not going to do the animation actually. Don't feel very comfortable w/ my abilities there... But happy to take a look in the future of how this is possible. The current state attempts to show users how to create some "snapshots" of the data and overlays them onto the FreeSurfer brain. Some notes: For visualization purposes, I've found that MNE-python has a hard time for iEEG. However, the plot_ecog.py example has always been helpful to me because you can show ecog grids relatively simply, compared to say SEEG, or ECoG strips scattered over both hemispheres. I'm looking into blender to assist w/ my visualization needs on SEEG and more advanced cases where interactive (rotation, zoom, transparency, etc.) are necessary. If there is anything "Pythonable", then would like to make an issue to see if mne-python would like to use it. |
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe @drammock want to have a look before merging?
|
@adam2392 do you want to restore the animation I had put in? It looked pretty cool and sphinx-gallery/sphinx-gallery#687 is very close to being in (I think) so it should be possible to actually have the animation show up in the docs |
Can you provide links to expand on what this 3D |
|
#7162 links to a ton if PRs / issues / plans |
|
Probably need to set the number of frames and/or the interval |
|
I went to using the Hilbert transform to compute the power in the band, feel free to switch back to CWT if need be, but I doubt it matters much (maybe |
Sweet! Had dinner and came back to this sweet thumbnail. That's a neat sphinx trick... For purposes of an example, I think Hilbert is fine. |
|
@drammock merge if happy. LGTM |
drammock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions to smooth things, but otherwise +1 for merge.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
|
I'll cancel the Travis and Azure tests, we only need Circle CI for the last round of changes. |
Azure style we'll still want, too |
|
thanks @adam2392 ! |
* upstream/master: (74 commits) FIX: Correct a bug in find_bads_eog (mne-tools#7797) [MRG] split_naming='bids' changes from _part-%d to _split-%d (mne-tools#7794) MRG, MAINT, DOC: Remove spyder (mne-tools#7796) MAINT: fixes for linkcheck (mne-tools#7762) [WIP] Update ieeg data example for ECoG (mne-tools#7768) fix examples/tutorials [circle full] (mne-tools#7786) MAINT: Clean up VTK and add to pre on Azure (mne-tools#7780) ENH: Add matplotlib animation support [skip travis] (mne-tools#7783) MRG, API: change out_type default in permutation_cluster_(1samp_)test (mne-tools#7781) DOC: docstring fixes (mne-tools#7777) MRG, ENH: Add tol_kind option (mne-tools#7736) MRG, DOC: Notes about info (mne-tools#7772) ENH: Speed up NIRx read without preload (mne-tools#7759) Minor plot_raw aes improvement (mne-tools#7770) MRG, FIX: Fixes for BEM contours (mne-tools#7763) MRG, STY: Fix E741 (mne-tools#7767) MRG, ENH - Plot optodes in plot_alignment for fNIRS channels (mne-tools#7747) FIX: Update NIH support [skip travis] (mne-tools#7766) MAINT: Bump tol for gamma map test (mne-tools#7764) MRG, FIX: Fix MRI orientations (mne-tools#7725) ...

Reference issue
Addresses: mne-tools/mne-misc-data#3
What does this implement/fix?
Updates plot_ecog example to use EDF data from mne-misc-data.
The ECoG data that currently is used for mne-python demos only contains an ECoG montage, but no "demoable" raw EDF files. As such, most demos showing off ECoG/SEEG functionality sort of just hack together random data points generated (e.g.
np.random.random(50, 100)for a 50 x 100 channel recording), whereas it would be nice to have a fleshed out demo w/ a real EDF file to show end-to-end MNE functionality.Additional information
This also raised issues in mne-bids, where we wanted to make an ieeg example, but had to hack together a soln. since no EDF versions of iEEG data was available in mne.
mne-tools/mne-bids#404