MRG, DOC: Notes about info #7772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about |
Member
Author
|
No, it shouldn't be -- it creates an inconsistency with other entries in info. You should use inst.rename_channels |
drammock
approved these changes
May 12, 2020
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
LGTM other than 1 suggestion (seems better to me, but feel free to ignore if you disagree).
Member
Author
It just occurred to me that we should probably document at least some common methods like these in the |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Member
|
Member
|
thx @larsoner |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
May 19, 2020
* upstream/master: (74 commits) FIX: Correct a bug in find_bads_eog (mne-tools#7797) [MRG] split_naming='bids' changes from _part-%d to _split-%d (mne-tools#7794) MRG, MAINT, DOC: Remove spyder (mne-tools#7796) MAINT: fixes for linkcheck (mne-tools#7762) [WIP] Update ieeg data example for ECoG (mne-tools#7768) fix examples/tutorials [circle full] (mne-tools#7786) MAINT: Clean up VTK and add to pre on Azure (mne-tools#7780) ENH: Add matplotlib animation support [skip travis] (mne-tools#7783) MRG, API: change out_type default in permutation_cluster_(1samp_)test (mne-tools#7781) DOC: docstring fixes (mne-tools#7777) MRG, ENH: Add tol_kind option (mne-tools#7736) MRG, DOC: Notes about info (mne-tools#7772) ENH: Speed up NIRx read without preload (mne-tools#7759) Minor plot_raw aes improvement (mne-tools#7770) MRG, FIX: Fixes for BEM contours (mne-tools#7763) MRG, STY: Fix E741 (mne-tools#7767) MRG, ENH - Plot optodes in plot_alignment for fNIRS channels (mne-tools#7747) FIX: Update NIH support [skip travis] (mne-tools#7766) MAINT: Bump tol for gamma map test (mne-tools#7764) MRG, FIX: Fix MRI orientations (mne-tools#7725) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer that people (including devs) shouldn't generally add new stuff to
info.