Skip to content

Conversation

@drammock
Copy link
Member

closes #8009

currently WIP because the fix doesn't actually work in my local testing; waiting to hear back from Spyder devs.

@drammock drammock mentioned this pull request Jul 22, 2020
@drammock drammock marked this pull request as ready for review October 14, 2020 16:30
@drammock drammock changed the title WIP: bump spyder version MRG: bump spyder version Oct 14, 2020
@drammock
Copy link
Member Author

@ccordoba12 says he can successfully set a py3.8 interpreter within an instance of spyder running in a py3.7 environment, on a bare-metal mac (although I've not been able to replicate this when running OSX catalina in a VM); see spyder-ide/spyder#13252 for discussion. Do any of our devs have a mac running catalina where they could double-check / confirm that this works? The procedure is:

conda create -n test-spyder python=3.7 spyder
conda create -n test-py38 python=3.8 spyder-kernels
conda activate test-spyder
spyder &

...and then go into spyder preferences and try to set Tools > Preferences > Python Interpreter > Use the following interpreter to the value of conda activate test-py38 && python -c "import sys; print(sys.executable)". Then close the running ipython console (should be py3.7) and see if the automatically spawned replacement console is py3.8.

Once we get confirmation, this PR is ready for review/merge. All CIs are happy except codecov (why, codecov? this PR only touches docs and the environment file)

@larsoner
Copy link
Member

@drammock I'm on Catalina and ran those commands (after conda update -n base conda just to be safe) and when I do Python->Preferences, then Python Interpreter, then paste in the value of conda activate test-py38 && python -c "import sys; print(sys.executable)" I get the error:

Invalid file path:
conda activate test-py38 && python -c "import sys; print(sys.executable)"

@larsoner
Copy link
Member

FWIW it looks like it's Spyder 4.1.5 according to the "About Spyder"

@drammock
Copy link
Member Author

@larsoner my instructions were not clear. in a terminal, run conda activate test-py38 && python -c "import sys; print(sys.executable)" and paste the path that it returns into the "use the following interpreter" box.

@larsoner
Copy link
Member

For me that's /Users/larsoner/opt/miniconda3/envs/test-py38/bin/python and it appears not to work:

Screen Shot 2020-10-14 at 4 50 39 PM

@drammock
Copy link
Member Author

@larsoner can you confirm that you do indeed have spyder-kernels installed in that env and it's a high enough version?
conda activate test-py38 && conda list spyder-kernels

@larsoner
Copy link
Member

$ conda activate test-py38 && conda list spyder-kernels
# packages in environment at /Users/larsoner/opt/miniconda3/envs/test-py38:
#
# Name                    Version                   Build  Channel
spyder-kernels            1.9.4                    py38_0  

@larsoner
Copy link
Member

larsoner commented Dec 1, 2020

@drammock thoughts on this for 0.22, or just bump to 0.23?

@larsoner larsoner added this to the 0.22 milestone Dec 1, 2020
@drammock
Copy link
Member Author

drammock commented Dec 1, 2020

spyder devs have failed to replicate. Personally I don't have the patience to debug this any further; working inside the OSX VM is really slow for me (I have all the wrong muscle memories, and some keyboard shortcuts get stolen by the host OS). Unless an actual mac user is willing to take over here and in spyder-ide/spyder#13252, I think we have 2 choices:

  1. close this and pretend nothing is wrong.
  2. assume that yours and my experiences are some kind of fluke or user error, and go ahead and rebase+merge this PR.

@larsoner
Copy link
Member

larsoner commented Dec 2, 2020

I dug into it and replied to the upstream issue -- they require spyder_kernels < 1.10 but 1.10 is the only version available for 3.8. Let's see what they say

@larsoner larsoner modified the milestones: 0.22, 0.23 Dec 9, 2020
@drammock
Copy link
Member Author

this one should (finally) be good to go

@larsoner
Copy link
Member

Thanks @drammock @ccordoba12 !

@larsoner larsoner merged commit 8b3ca8a into mne-tools:master Jan 12, 2021
larsoner pushed a commit that referenced this pull request Jan 12, 2021
* bump versions

* fix: spyder-kernels version
@drammock drammock deleted the bump-spyder branch January 12, 2021 21:53
cbrnr pushed a commit to cbrnr/mne-python that referenced this pull request Jan 15, 2021
* bump versions

* fix: spyder-kernels version
larsoner added a commit to vpeterson/mne-python that referenced this pull request Feb 25, 2021
* upstream/master: (66 commits)
  MRG, ENH: Add infant template downloader (mne-tools#8738)
  ENH: add reader for NeuroElectrics .nedf files (mne-tools#8734)
  DOC: improve glossary entry about fiducials (mne-tools#8763)
  MRG, ENH: Add Report.add_custom_css (mne-tools#8762)
  BUG, DOC: read_raw_egi didn't support pathlib.Path; update read_raw() docstring (mne-tools#8759)
  Add "dbs" as new channel type (mne-tools#8739)
  MRG, VIZ: Fix title position in plot_sensors (mne-tools#8752)
  MRG: Support for non-FIFF files in Report.parse_folder (mne-tools#8744)
  MRG, VIZ, FIX: sEEG picking in _prepare_topomap_plot() (mne-tools#8736)
  DOC: don't use single letter variable name in _compute_forward (mne-tools#8727)
  WIP: Fix search [skip github] [skip azp] (mne-tools#8742)
  WIP: Compare Beer-lambert to HOMER (mne-tools#8711)
  MRG: bump spyder version (mne-tools#8020)
  FIX anon with IO round trip (mne-tools#8731)
  fix set_bipolar_reference for Epochs (mne-tools#8728)
  WIP: Add width argument, reduce default (mne-tools#8725)
  ENH: Add toggle-all button to Report (mne-tools#8723)
  fix int/float conversion in nicolet header (mne-tools#8712)
  MRG, BUG: Fix Report.add_bem_to_section n_jobs != 1 (mne-tools#8713)
  MRG, DOC: Make "rank" options in docs more accessible (mne-tools#8707)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT, DOC: bump spyder-kernels

3 participants