Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Jan 8, 2021

  1. Add width argument to add_bems_to_section, change from old default (7 inches in whatever your DPI was) to 512, thus reducing file sizes without losing any meaningful quality (2x the typical MRI resolution should be enough to see the BEM contours clearly). On my system this cuts down on the resulting report file size by a factor of 2.
  2. Change CSS to have the images span 100% of the usable space (browser-upscaling)
  3. Have BEM generation use Agg backend
  4. DRY Agg-figure code
  5. Fix bugs with replace being omitted in some Report functions
  6. Make footer just show the date of creation, and make it sticky (informative, no need to advertise MNE nowadays I think)
  7. Make header padding responsive to sizing changes. You can see the differences especially with an example like the following on master and this PR:
    import mne
    report = mne.Report()
    for html in range(10):
        html = str(html) * 20
        report.add_htmls_to_section(html, captions=html, section=html)
    report.save('report.html', overwrite=True)
    
    Changing the window size and toggling the visibility of the buttons no longer covers the page contents.

FYI I am using Report to look at a few dozen bad FreeSurfer BEMs and iteratively replace them as I fix them (in principle, have fixed 0 so far), hence why I'm finding and fixing all these bugs and making things more usable.

@agramfort
Copy link
Member

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge provided CIs are happy

@larsoner larsoner changed the title MRG, ENH: Add width argument, reduce default WIP: Add width argument, reduce default Jan 9, 2021
@agramfort agramfort merged commit 8808612 into mne-tools:master Jan 9, 2021
cbrnr pushed a commit to cbrnr/mne-python that referenced this pull request Jan 15, 2021
* ENH: Add width argument, reduce default

* DOC: Touch tutorial

* FIX: Unused
larsoner added a commit to vpeterson/mne-python that referenced this pull request Feb 25, 2021
* upstream/master: (66 commits)
  MRG, ENH: Add infant template downloader (mne-tools#8738)
  ENH: add reader for NeuroElectrics .nedf files (mne-tools#8734)
  DOC: improve glossary entry about fiducials (mne-tools#8763)
  MRG, ENH: Add Report.add_custom_css (mne-tools#8762)
  BUG, DOC: read_raw_egi didn't support pathlib.Path; update read_raw() docstring (mne-tools#8759)
  Add "dbs" as new channel type (mne-tools#8739)
  MRG, VIZ: Fix title position in plot_sensors (mne-tools#8752)
  MRG: Support for non-FIFF files in Report.parse_folder (mne-tools#8744)
  MRG, VIZ, FIX: sEEG picking in _prepare_topomap_plot() (mne-tools#8736)
  DOC: don't use single letter variable name in _compute_forward (mne-tools#8727)
  WIP: Fix search [skip github] [skip azp] (mne-tools#8742)
  WIP: Compare Beer-lambert to HOMER (mne-tools#8711)
  MRG: bump spyder version (mne-tools#8020)
  FIX anon with IO round trip (mne-tools#8731)
  fix set_bipolar_reference for Epochs (mne-tools#8728)
  WIP: Add width argument, reduce default (mne-tools#8725)
  ENH: Add toggle-all button to Report (mne-tools#8723)
  fix int/float conversion in nicolet header (mne-tools#8712)
  MRG, BUG: Fix Report.add_bem_to_section n_jobs != 1 (mne-tools#8713)
  MRG, DOC: Make "rank" options in docs more accessible (mne-tools#8707)
  ...
@larsoner larsoner deleted the rep branch February 1, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants