MRG: Support for non-FIFF files in Report.parse_folder #8744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
changed the title
larsoner
reviewed
Jan 14, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Just minor comments, otherwise LGTM!
mne/tests/test_report.py
Outdated
| [op.basename(x) for x in report.fnames]) | ||
| assert (''.join(report.html).find(op.basename(fname)) != -1) | ||
|
|
||
| assert_equal(len(report.fnames), len(fnames_out)) |
Member
There was a problem hiding this comment.
We prefer plain assert to assert_equal nowadays usually -- assert_equal is less informative than plain assert len(report.fnames) == len(fnames_out). Feel free to remove all uses in this file if you want, but at least let's not add more of them
Member
Author
There was a problem hiding this comment.
I've replaced all calls to assert_equal with plain assert now
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Member
Author
|
@larsoner I have addressed your comments. |
larsoner
approved these changes
Jan 14, 2021
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
LGTM feel free to merge when CIs come back happy, thanks @hoechenberger !
Member
|
maybe some CIs need to be restarted. Than let's merge |
Member
Author
|
One CI run failing again, this is caused by an upstream problem: |
Work around jupyter/nbformat#206
cbrnr
pushed a commit
to cbrnr/mne-python
that referenced
this pull request
Jan 15, 2021
larsoner
added a commit
to vpeterson/mne-python
that referenced
this pull request
Feb 25, 2021
* upstream/master: (66 commits) MRG, ENH: Add infant template downloader (mne-tools#8738) ENH: add reader for NeuroElectrics .nedf files (mne-tools#8734) DOC: improve glossary entry about fiducials (mne-tools#8763) MRG, ENH: Add Report.add_custom_css (mne-tools#8762) BUG, DOC: read_raw_egi didn't support pathlib.Path; update read_raw() docstring (mne-tools#8759) Add "dbs" as new channel type (mne-tools#8739) MRG, VIZ: Fix title position in plot_sensors (mne-tools#8752) MRG: Support for non-FIFF files in Report.parse_folder (mne-tools#8744) MRG, VIZ, FIX: sEEG picking in _prepare_topomap_plot() (mne-tools#8736) DOC: don't use single letter variable name in _compute_forward (mne-tools#8727) WIP: Fix search [skip github] [skip azp] (mne-tools#8742) WIP: Compare Beer-lambert to HOMER (mne-tools#8711) MRG: bump spyder version (mne-tools#8020) FIX anon with IO round trip (mne-tools#8731) fix set_bipolar_reference for Epochs (mne-tools#8728) WIP: Add width argument, reduce default (mne-tools#8725) ENH: Add toggle-all button to Report (mne-tools#8723) fix int/float conversion in nicolet header (mne-tools#8712) MRG, BUG: Fix Report.add_bem_to_section n_jobs != 1 (mne-tools#8713) MRG, DOC: Make "rank" options in docs more accessible (mne-tools#8707) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support all non-FIFF files we can read when parsing a folder using
Report.parse_folder(). Requested via https://mne.discourse.group/t/naming-convention-in-mne-vs-mne-bids-welcome-to-the-thunderdome/2467