fix set_bipolar_reference for Epochs #8728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
please have a look @jasmainak |
jasmainak
approved these changes
Jan 10, 2021
Member
jasmainak
left a comment
jasmainak
left a comment
There was a problem hiding this comment.
Other than minor nitpicks, +1 for merge
doc/changes/latest.inc
Outdated
|
|
||
| - Fix bug with :func:`mne.io.read_raw_nicolet` where header type values such as num_sample and duration_in_sec where not parsed properly (:gh:`8712` by `Alex Gramfort`_) | ||
|
|
||
| - Fix bug with :func:`mne.set_bipolar_reference` when passing Epochs (:gh:`8728` by `Alex Gramfort`_) |
Member
There was a problem hiding this comment.
maybe a bit more explicit about what the bug was?
| inst.info._update_redundant() | ||
|
|
||
| if getattr(inst, 'picks', None) is not None: | ||
| del inst.picks # picks cannot be tracked anymore |
Member
There was a problem hiding this comment.
this is new for me, not sure what this does
Member
Author
There was a problem hiding this comment.
the .picks attribute when you passed picks to the Epochs constructor.
agramfort
force-pushed
the
fix_bipol_epochs
branch
from
a0d5389 to
259566c
Compare
Member
|
Thanks a ton @agramfort ! |
cbrnr
pushed a commit
to cbrnr/mne-python
that referenced
this pull request
Jan 15, 2021
* fix set_bipolar_reference for Epochs * update what's new * update test
larsoner
added a commit
to vpeterson/mne-python
that referenced
this pull request
Feb 25, 2021
* upstream/master: (66 commits) MRG, ENH: Add infant template downloader (mne-tools#8738) ENH: add reader for NeuroElectrics .nedf files (mne-tools#8734) DOC: improve glossary entry about fiducials (mne-tools#8763) MRG, ENH: Add Report.add_custom_css (mne-tools#8762) BUG, DOC: read_raw_egi didn't support pathlib.Path; update read_raw() docstring (mne-tools#8759) Add "dbs" as new channel type (mne-tools#8739) MRG, VIZ: Fix title position in plot_sensors (mne-tools#8752) MRG: Support for non-FIFF files in Report.parse_folder (mne-tools#8744) MRG, VIZ, FIX: sEEG picking in _prepare_topomap_plot() (mne-tools#8736) DOC: don't use single letter variable name in _compute_forward (mne-tools#8727) WIP: Fix search [skip github] [skip azp] (mne-tools#8742) WIP: Compare Beer-lambert to HOMER (mne-tools#8711) MRG: bump spyder version (mne-tools#8020) FIX anon with IO round trip (mne-tools#8731) fix set_bipolar_reference for Epochs (mne-tools#8728) WIP: Add width argument, reduce default (mne-tools#8725) ENH: Add toggle-all button to Report (mne-tools#8723) fix int/float conversion in nicolet header (mne-tools#8712) MRG, BUG: Fix Report.add_bem_to_section n_jobs != 1 (mne-tools#8713) MRG, DOC: Make "rank" options in docs more accessible (mne-tools#8707) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8726