Bug 1996031: Merge upstream tag 'v1.22.0' by pierreprinetti · Pull Request #70 · openshift/cloud-provider-openstack

pierreprinetti · 2021-08-20T11:20:50Z

No description provided.

…ubernetes#1605) * added cephfs-csi mount opts to volume context This commit adds two new options specific to cephfs-csi to ControllerVolumeContext and NodeVolumeContext: * cephfs-kernelMountOptions, * cephfs-fuseMountOptions * pass cephfs-kernelMountOptions and cephfs-fuseMountOptions to cephfs-csi * updated docs with new volume context opts

This PR refactors/moves the provider code for better readability.

…rnetes#1615) The chart assumes Kubelet uses /var/lib/kubelet, which isn't the case on k0s and microk8s (and presumably others). This allows it to be overridden in the values file to handle these cases. Also bump chart version to 1.4.7

* go.mod: bumped github.com/gophercloud/gophercloud to v0.19.0 * removed hardcoded checks for cephfs, added checks for caps in parent share This commit removes all hard-coded checks for CephFS shares, preventing them from being snapshotted. Instead, manila-csi now checks for snapshot_support and create_share_from_snapshot capabilities. * share: added handling for creating_from_snapshot status * docs: added a note about snapshots * go.sum: added k8s.io/code-generator * go.mod fix 2: added github.com/gophercloud/gophercloud v0.19.0

This was used to remove the registration socket when the container node-driver-registrar container stops. As of [1] it's done by the registrar itself, making this hook not needed anymore. [1] kubernetes-csi/node-driver-registrar#61

* csi-node-driver-registrar: v1.3.0 -> v2.2.0 * csi-provisioner: v2.0.2 -> v2.2.2 * csi-snapshotter: v2.1.3 -> v4.1.1

TokenReview, SubjectAccessReview v1beta1 apiVersions are removed in 1.22. This PR updates the docs for the same.

…ume_context (kubernetes#1616) * validator: added Validator.Fields exposing recognized field names * options: added NodeVolumeContextFields() to expose nodeVolumeCtxValidator.Fields * CreateVolume: pass all recognized CreateVolumeRequest.parameters fields as Volume.volume_context

openshift-ci · 2021-08-20T11:21:57Z

@pierreprinetti: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 1996031 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1996031: Merge upstream tag 'v1.22.0'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre

/hold

Let's only sync version tags with release branches, for example your PR contains commit 7de8a84 which we don't want in master.

pierreprinetti · 2021-08-23T09:13:25Z

/test unit

pierreprinetti · 2021-08-23T09:25:26Z

@mandre
Based on your comment, I have changed the strategy of this PR
from:

merge the upstream tag corresponding to the current k8s release

to:

merge upstream/master up to its tag corresponding to the current k8s release

pierreprinetti · 2021-08-23T16:08:06Z

/test unit

pierreprinetti · 2021-08-24T14:07:49Z

/bugzilla refresh

openshift-ci · 2021-08-24T14:07:53Z

@pierreprinetti: This pull request references Bugzilla bug 1996031, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-25T10:09:08Z

Depends on #74

mandre · 2021-08-25T13:20:02Z

@pierreprinetti can you rebase on master now that #74 has merged?

openshift-ci · 2021-08-25T20:25:41Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-csi-manila	`b93c6fa`	link	`/test e2e-openstack-csi-manila`
ci/prow/e2e-openstack-csi-cinder	`b93c6fa`	link	`/test e2e-openstack-csi-cinder`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti · 2021-08-25T21:48:37Z

This seems good to go now.
PTAL @mandre

mandre

The red tests are expected to fail, everything looks good.
/lgtm

mandre · 2021-08-26T07:14:34Z

/hold cancel

openshift-ci · 2021-08-26T07:19:12Z

@pierreprinetti: All pull requests linked via external trackers have merged:

openshift/cloud-provider-openstack#70

Bugzilla bug 1996031 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1996031: Merge upstream tag 'v1.22.0'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-26T07:20:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gman0 and others added 17 commits July 22, 2021 22:11

[cinder-csi-plugin] Remove redundant imagePullPolicy (kubernetes#1602)

2155ee9

[cinder-csi-plugin] Fix duplicate keys of tolerations (kubernetes#1609)

02cddd3

Fix chart linting (kubernetes#1612)

61bdbe5

Refactor the openstack provider code (kubernetes#1586)

9b8de65

This PR refactors/moves the provider code for better readability.

bumped sidecar versions

e45c7e2

* csi-node-driver-registrar: v1.3.0 -> v2.2.0 * csi-provisioner: v2.0.2 -> v2.2.2 * csi-snapshotter: v2.1.3 -> v4.1.1

bumped chart version

0ba23e4

bumped sidecar versions in manifests

7bcf447

[cinder-csi-plugin] Bump driver version for 1.22 release

7c07db1

[cinder-csi-plugin] Remove preStop hook

95513ae

Update k/k dependency to v1.22.0

1f88695

[docs] Update the apiVersions (kubernetes#1622)

8d484ee

TokenReview, SubjectAccessReview v1beta1 apiVersions are removed in 1.22. This PR updates the docs for the same.

Update mount-utils to 0.22.0

2df8ac3

pierreprinetti mentioned this pull request Aug 20, 2021

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #69

Closed

openshift-ci Bot requested review from adduarte and iamemilio August 20, 2021 11:23

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021

pierreprinetti force-pushed the bump_1.22 branch from 3a3180e to 4d6a7d4 Compare August 20, 2021 11:30

mandre requested changes Aug 23, 2021

View reviewed changes

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021

pierreprinetti force-pushed the bump_1.22 branch from ffa4305 to db9dc2d Compare August 23, 2021 09:21

pierreprinetti force-pushed the bump_1.22 branch from db9dc2d to a651fd8 Compare August 23, 2021 09:27

pierreprinetti mentioned this pull request Aug 23, 2021

Bug 1988374: UPSTREAM: 1988374: Disable uuid checks on XFS (#1614) #72

Merged

pierreprinetti force-pushed the bump_1.22 branch 2 times, most recently from a651fd8 to 3245cef Compare August 23, 2021 16:02

pierreprinetti force-pushed the bump_1.22 branch 4 times, most recently from fe59e97 to de83bbe Compare August 24, 2021 08:45

openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 24, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 24, 2021

openshift-ci Bot requested a review from eurijon August 24, 2021 14:07

pierreprinetti force-pushed the bump_1.22 branch from de83bbe to 3d6c77c Compare August 25, 2021 07:01

Merge upstream up to tag 'v1.22'

b93c6fa

pierreprinetti force-pushed the bump_1.22 branch from 280f5a6 to b93c6fa Compare August 25, 2021 18:55

mandre approved these changes Aug 26, 2021

View reviewed changes

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

openshift-ci Bot assigned mandre Aug 26, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021

openshift-merge-robot merged commit a6492bc into openshift:master Aug 26, 2021

pierreprinetti deleted the bump_1.22 branch August 26, 2021 07:49

mandre mentioned this pull request Jan 19, 2023

OCPBUGS-6035: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.22 into release-4.9 #170

Merged

Conversation

pierreprinetti commented Aug 20, 2021

Uh oh!

openshift-ci Bot commented Aug 20, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

openshift-ci Bot commented Aug 24, 2021

Uh oh!

pierreprinetti commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mandre commented Aug 25, 2021

Uh oh!

openshift-ci Bot commented Aug 25, 2021

Uh oh!

pierreprinetti commented Aug 25, 2021

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

mandre commented Aug 26, 2021

Uh oh!

openshift-ci Bot commented Aug 26, 2021

Uh oh!

openshift-ci Bot commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pierreprinetti commented Aug 25, 2021 •

edited

Loading