This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Openshift CI - master branch#5
Merged
openshift-merge-robot merged 55 commits intoNov 27, 2018
Merged
Conversation
* No longer use the subscribable interface. * Delete no longer used function.
* Change Channelable to match the definition in knative#482. * No longer use the subscribable interface. * Move the Channelable duck type into the eventing repo.
* Rename ClusterProvisioner -> ClusterChannelProvisioner * Remove ClusterChannelProvisioner Reconciles field * review feedback
ProvisionerReference contains a single required field. We can simplify the object model by moving the ObjectRef for a provisioner up one level.
* fix typo in the path name * remove the extra ref from the spec.provisioner
If a channel has no subscribers, it should still be in the configmap. This allows the dispatcher to respond with a 202 to a publish request (then drop the published event).
* Rename SubscriptionSpec.{From -> Channel}
* Rename SubscriptionSpec.{Call -> Subscriber}
ChannelSubscriberSpec.{CallableURI -> SubscriberURI}
SubscriptionStatusPhysicalSubscription.{CallURI -> SubscriberURI}
* Rename EndpointSpec -> SubscriberSpec
SubscriberSpec.{TargetRef -> Ref}
* Reanme SubscriptionSpec.{Result -> ReplyTo}
ChannelSubscriberSpec.{SinkableURI -> ReplyToURI}
SubscriptionStatusPhysicalSubscription.{ResultURI -> ReplyToURI}
ResultStrategy -> ReplyStrategy
ReplyStrategy.{Target -> Channel}
* Rename SubscriptionSpec.{ReplyTo -> Reply}
* target -> channel * Change error message to channel.
* Align Subscribable source with spec - renamed Channelable -> Subscribable - add ObjectReference to ChannelSubscriberSpec to track originating resource - removed Subscribable as a public interface in the spec - preserved as an internal interface * polish
* move to new model with k8s event source from event-sources * match version from head * Dump the created resources before deleting them to get more debug information in test failure cases
* Remove legacy code remove API groups: - channels.knative.dev - feeds.knative.dev - flows.knative.dev Remove code and dependencies that depended directly on those API groups. This includes all Buses and EventSources. Where practical references to Channel and Subscription in channels.knative.dev have been updated to eventing.knative.dev. The e2e suite has been decimated and will need to be reestabilished. * Fix release script * maybe allow e2e tests to pass * ClusterProvisioner -> ClusterChannelProvisioner in e2etests * Remove deleted image paths for e2e tests * pune more dead code
* Update the release script
The major change is the ability to publish a new release to GitHub automatically, just like serving or build do.
Bonus: update documentation about `//hack`, and add documentation about `release.sh`.
* Fix handling of repo
KO_DOCKER_REPO is the canonical reference.
* Fix {
* Address PR feedback on doc
* Add channel utils * Add Provisioner util and fix comments * Add unit tests * Fix logging * Fix after pr 562 * renaming * Fix import ordering and test
* Test duck types * Fix api package doc lint * Add tests for *Name functions Functions that are no longer used were deleted. * Remove unused functions
* add more unit tests * use anonymous struct as per pr comment
All we need is scripts/ and tools/dep-collector. The additional deps are dependencies of dep-collector.
Mirrors the exclusion in Serving.
* Add tests for subscription provider methods InjectClient and InjectConfig are now fully covered. * Add commented ProvideController test This can't be tested until a mock manager exists. * Test InjectClient in kafka channel controllers
* Patch channel only with subscribers in same namespace * Handle deleted channels * Minor style fix
* Kafka dispatcher * Address PR Comments * Add some more TODO's
* Initial work on defaulting channel provisioners if they are not specified.
* Patch to add /spec as {}.
* Undo the patch to add /spec as {}.
* Move to channel_defaulter.go
* Add unit tests.
* Move out of v1alpha1
* Switch to a model that allows namespace defaults, as suggested in PR comments.
* Update doc string.
* Add Kafka-channel provisioner * Feedback from @grantr, renaming kafka yaml
openshift-ci-robot
added
size/L
mvinkler
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Author
|
/retest |
1 similar comment
Author
|
/retest |
openshift-ci-robot
added
size/XXL
mvinkler
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, mvinkler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 3, 2021
* add patch of missing versions Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Patch 0.23 with missing API versions Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * remove the patch, it's not needed in other versions Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Using pre-built image from OCP registry (#2) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Apply ko publish patch to here ... (#3) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * One more thing.... (#4) Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add logs to understand rekt progress Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Adding back vendor patches (#5) * Rollback certificate algorithm changes (#1281) (#1283) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> * mute noisy metrics * [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (#1361) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI logic for master branch, in a similar way as in PR4 for release-0.2 branch.