nanointeractive bid adapter by rade-popovic · Pull Request #1627 · prebid/Prebid.js

rade-popovic · 2017-09-27T11:21:25Z

Type of change

https://github.com/nanointeractive/prebid.github.io/blob/2a57cea7d15b3e3a69b24db288d8e3364c3996b5/dev-docs/bidders/nanointeractive.md

Description of change

New bid adapter

test parameters for validating bids
{
bidder: 'nanointeractive',
params: {
sec: '04a0cb7fb9ac02840f7f33d68a883780',
dpid: '58bfec94eb0a1916fa380162',
pid: '58bfec94eb0a1916fa380163'
}
}
contact email of the adapter’s maintainer
rade@nanointeractive.com

mkendall07 · 2017-09-27T11:42:12Z

hi @nanointeractive
We have recently updated the format for adapters. Please submit the adapter in the form specified here http://prebid.org/dev-docs/bidder-adapter-1.html

You can see an example of the new format implemented here: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusAstBidAdapter.js

Thanks!

rade-popovic · 2017-10-23T11:43:51Z

Dear Matt, can you please give us an info when can we expect approval of the pull request. If there is anything from our side we can do to fasten the process please let us know.

mkendall07 · 2017-10-23T13:29:35Z

@nanointeractive
Thanks for the update. I didn't see the most recent commits. I'll review this week. Thanks!

rade-popovic · 2017-10-23T13:30:28Z

Great, thanks !

mkendall07

@nanointeractive
Few comments to address. I'm not seeing bids returned for a 300x250 ad unit with the included bid params. Please advise.

Also please include a markdown file with you bid params example. Thanks

mkendall07 · 2017-10-24T16:25:44Z

modules/nanointeractiveBidAdapter.js

+function createSingleBidResponse(serverBid) {
+  return {
+    requestId: serverBid.id,
+    bidderCode: serverBid.bidderCode,


please drop bidderCode here - we add it automatically - this was an error in our docs sorry.

mkendall07 · 2017-10-24T16:31:42Z

modules/nanointeractiveBidAdapter.js

+  return bid.params[CATEGORY] || null;
+}
+
+function getQueryParam(nq) {


I think you can use utils. getParameterByName() here:
https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L257

…n().href - bidderCode is removed - Default ALG changed to 'ihr' - added protocol to 'cors' param

rade-popovic · 2017-10-25T14:36:44Z

@mkendall07
Thanks for the overview and the help.
We deployed the requested changes.

I've also changed params for the bid validation, please use this one:
{
bidder: 'nanointeractive',
params: {
sec: '04a0cb7fb9ac02840f7f33d68a883780',
dpid: '58bfec94eb0a1916fa380162',
pid: '58bfec94eb0a1916fa380163'
}
}

Cheers

mkendall07 · 2017-10-25T14:48:39Z

@nanointeractive
thanks. Can you add the markdown file as well? see here for example: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusAstBidAdapter.md

rade-popovic · 2017-10-25T15:39:57Z

thanks, done: https://github.com/nanointeractive/Prebid.js/blob/master/modules/nanointeractiveBidAdapter.md

mkendall07 · 2017-10-25T16:10:11Z

@nanointeractive
getting a CORS error now on your endpoint: Failed to load http://tmp.audiencemanager.de/hb: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. Origin 'http://localhost:9999' is therefore not allowed access. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.

rade-popovic · 2017-10-25T16:28:31Z

strange, I know the issue but we solved it by changing dynamically 'Access-Control-Allow-Origin' for each bid request from location.origin value. Can you please send me the Response headers and Request Payload.

mkendall07 · 2017-10-25T16:51:07Z

It's because of Access-Control-Allow-Origin: * instead of Access-Control-Allow-Origin: <domain>

Date: Wed, 25 Oct 2017 16:50:10 GMT
Server: Apache/2.4.27 (Amazon) PHP/5.6.25
X-Powered-By: PHP/5.6.25
Status: 200 OK
RequestId: e082476220652d6695d50c78b790b634
Hostname: 10-75-1-58#slave3
P3P: CP="NID DSP ALL COR"
Access-Control-Allow-Origin: *
responseTime: 90
Content-Length: 835
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: application/x-javascript```

rade-popovic · 2017-10-25T20:47:36Z

mystery solved, we disabled localhost for bid requests. I have enabled localhost, now everything should be fine

mkendall07

LGTM. Thanks!

* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...

nanointeractive bid adapter

c20da14

matthewlane added the needs update label Oct 3, 2017

goranbozicic added 2 commits October 16, 2017 11:06

nanointeractive bid adapter

a60630b

Merge branch 'master' of https://github.com/prebid/Prebid.js

c402746

mkendall07 self-assigned this Oct 17, 2017

mkendall07 added needs review and removed needs update labels Oct 23, 2017

mkendall07 suggested changes Oct 24, 2017

View reviewed changes

mkendall07 added needs update not receiving bids and removed needs review labels Oct 24, 2017

- using utils.getParameterByName instead of utils.getTopWindowLocatio…

acf178f

…n().href - bidderCode is removed - Default ALG changed to 'ihr' - added protocol to 'cors' param

markdown file

9f2c50f

enabling localhost for bid requests

1cbdb97

mkendall07 approved these changes Oct 26, 2017

View reviewed changes

mkendall07 merged commit 698c330 into prebid:master Oct 26, 2017

rade-popovic mentioned this pull request Apr 23, 2018

Create docs for Nano Interactive Bid Adapter prebid/prebid.github.io#721

Merged

Conversation

rade-popovic commented Sep 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Uh oh!

mkendall07 commented Sep 27, 2017

Uh oh!

rade-popovic commented Oct 23, 2017

Uh oh!

mkendall07 commented Oct 23, 2017

Uh oh!

rade-popovic commented Oct 23, 2017

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

mkendall07 Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 Oct 24, 2017

Choose a reason for hiding this comment

Uh oh!

rade-popovic commented Oct 25, 2017

Uh oh!

mkendall07 commented Oct 25, 2017

Uh oh!

rade-popovic commented Oct 25, 2017

Uh oh!

mkendall07 commented Oct 25, 2017

Uh oh!

rade-popovic commented Oct 25, 2017

Uh oh!

mkendall07 commented Oct 25, 2017

Uh oh!

rade-popovic commented Oct 25, 2017

Uh oh!

mkendall07 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

rade-popovic commented Sep 27, 2017 •

edited

Loading