Update GetIntent adapter to 1.0 version

[kprokopchik]

Type of change

• Other

Description of change

GetIntent adapter for Prebid.js 1.0 version

• test parameters for validating bids

{
  bidder: 'getintent',
  params: {
    pid: '7',
    tid: 'test01',
    // ...
  }
}

• contact email of the adapter’s maintainer
  server-dev@getintent.com
• official adapter submission

Other information

[matthewlane]

@dhargo Thanks for the updated adapter, a few changes requested. Also when testing bid responses with the test parameters, I'm receiving a 404 error from your endpoint

http://px.adhigh.net/rtb/direct_banner?pid=12345&tid=9876&known=1&is_video=false&resp_type=JSON&size=300x250& 404 (Not Found)

Please advise so we can validate bid responses, thanks

[matthewlane]

#1748 changed the first argument of interpretResponse to:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

so doing something like

serverResponse = serverResponse.body

(or however you'd prefer) in this function should give you the expected behavior

[matthewlane]

bidderCode can be dropped from the bid response object, it'll be set automatically by bidderFactory. Docs just updated, sorry for the confusion

[matthewlane]

Adunit sizes may be defined as [300, 250], in which case sizes[0] would be 300 and cause a TypeError. Be sure to check that bidRequest.sizes[0] is an array before calling join

[matthewlane]

bid.descriptionUrl is no longer required, bid.vastUrl alone will work now

[matthewlane]

A few of the required bid response fields are missing: ttl, netRevenue, and currency. See the table in this section http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for descriptions and examples of each of these fields

[kprokopchik]

@matthewlane Thanks for the comments. I've commited fixes. Here is new parameters to use for testing bid response

http://px.adhigh.net/rtb/direct_banner?pid=7&tid=test01&known=1&is_video=false&resp_type=JSON&size=300x250& 

[matthewlane]

Great, no longer getting the 404 error with those parameters, but still a few issues with requestId and creativeId

[matthewlane]

Is your endpoint able to always return a creativeId? That's a required parameter, and if it doesn't get set this won't pass validation. It might also be on responseBody rather than bidRequest

[matthewlane]

bidId didn't appear to be on the bidRequest object during tests I ran. I was able to get bid responses from your endpoint, but because the requestId wasn't getting set, it made it appear that the bid from this adapter was empty

[matthewlane]

This should set bidId: bidRequest.bidId so that the interpretResponse function has access to it

[kprokopchik]

@matthewlane Thank you for the comments. Fixed missing fields (requestId, creativeId).

Have to notice: method signature interpretResponse: function(serverResponse, request) and example in documentation http://prebid.org/dev-docs/bidder-adapter-1.html looks like we always have BidRequest (request parameter) when interpreting server bid response; so it is unclear why do we have to pass requestId to server and back.

[matthewlane]

Sorry for the confusion about that. The second parameter to interpretResponse is the bid request object which is available for use if needed. This object is whatever was returned the buildRequests function. Bid request and response objects need to have matching ids and one way of doing that is returning the id from buildRequests, but they can also be sent and received from the server as you've done here. In any case I was able to verify bids with your adapter so this is good for merge